New issue
Advanced search Search tips

Issue 740131 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Support checkout-relative paths in path arguments to //build/android/test_runner.py

Project Member Reported by jbudorick@chromium.org, Jul 7 2017

Issue description

i.e., paths starting with //

This would allow us to more cleanly specify paths in bot specs or, if necessary, in gn.
 
Owner: shenghua...@chromium.org
Status: Assigned (was: Untriaged)
Summary: Support checkout-relative paths in path arguments to //build/android/test_runner.py (was: Support checkout-relative paths in //build/android/test_runner.py)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da447a43bfb18dec31388d70a788746b090a316b

commit da447a43bfb18dec31388d70a788746b090a316b
Author: shenghuazhang <shenghuazhang@chromium.org>
Date: Thu Jul 27 06:12:07 2017

[test_runner] support relative paths on argument --shared-prefs-file

Append checkout directory to head of path starting with '//'.

BUG=740131

Review-Url: https://codereview.chromium.org/2985013002
Cr-Commit-Position: refs/heads/master@{#489872}

[modify] https://crrev.com/da447a43bfb18dec31388d70a788746b090a316b/build/android/test_runner.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b303ad3fbe9964af40c9d00cfdf4932ef7c6c55

commit 5b303ad3fbe9964af40c9d00cfdf4932ef7c6c55
Author: Shenghua Zhang <shenghuazhang@chromium.org>
Date: Fri Jul 28 21:31:04 2017

[test runner] Buildbot json arg --shared-prefs-file supports relative path

Test_runner.py supports relative paths on argument --shared-prefs-file.
Change those argument paths to relative paths starting with '//' in
buildbot json files.

Bug: 740131
Change-Id: I1e4dc8aae74472d5601f09f56b2a8873aec879ec
Reviewed-on: https://chromium-review.googlesource.com/590153
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490514}
[modify] https://crrev.com/5b303ad3fbe9964af40c9d00cfdf4932ef7c6c55/testing/buildbot/chromium.android.json
[modify] https://crrev.com/5b303ad3fbe9964af40c9d00cfdf4932ef7c6c55/testing/buildbot/chromium.fyi.json

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bef77d46c7779b86bc4d29b097f385f7454af45

commit 8bef77d46c7779b86bc4d29b097f385f7454af45
Author: Shenghua Zhang <shenghuazhang@chromium.org>
Date: Sat Jul 29 03:26:54 2017

[test_runner] support relative paths on path arguments

Support relative paths in test_runner.py, applying to arguments:
  --replace-system-package
  --additional-apk

Bug: 740131
Change-Id: Id40931def3acf08d0b5e177d27e11f72f684e4d3
Reviewed-on: https://chromium-review.googlesource.com/591007
Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490604}
[modify] https://crrev.com/8bef77d46c7779b86bc4d29b097f385f7454af45/build/android/test_runner.py
[modify] https://crrev.com/8bef77d46c7779b86bc4d29b097f385f7454af45/testing/buildbot/chromium.android.json
[modify] https://crrev.com/8bef77d46c7779b86bc4d29b097f385f7454af45/testing/buildbot/chromium.fyi.json

Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment