The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0156251a5c6b3374b41bfc8e1ef8642f469e8d70

commit 0156251a5c6b3374b41bfc8e1ef8642f469e8d70
Author: Colin Blundell <blundell@chromium.org>
Date: Mon Jul 10 13:25:47 2017

[ProfileOAuth2TokenService] Expose whether refresh tokens are loaded

Consumers of ProfileOAuth2TokenService currently have the ability to load
credentials but no way to query whether all credentilas have been loaded.
This functionality will be needed by the Identity Service internal
implementation in order to delay responding to consumer requests until
all refresh tokens have been loaded (listening to the observer event
isn't enough because the Identity Service might be started after the
event has fired).

This CL adds this functionality.

Bug: 740117
Change-Id: Ia2d61aefa9310f05bbc58c2884a68bc19d647c08
Reviewed-on: https://chromium-review.googlesource.com/563616
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485253}
[modify] https://crrev.com/0156251a5c6b3374b41bfc8e1ef8642f469e8d70/components/signin/core/browser/profile_oauth2_token_service.cc
[modify] https://crrev.com/0156251a5c6b3374b41bfc8e1ef8642f469e8d70/components/signin/core/browser/profile_oauth2_token_service.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6430f5dc23868995c86cfbb3829978e7cb34bf32

commit 6430f5dc23868995c86cfbb3829978e7cb34bf32
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Jul 13 10:17:13 2017

Identity Service: Queue requests until internal state is stable

Chromium's signin code currently allows querying signin state before
all information has been loaded from disk at startup (e.g., before all
refresh tokens have been loaded). This forces consumers to worry about
the edge case of a refresh token not being available simply because it
hasn't been loaded yet.

The Identity Service APIs can eliminate this edge case by guaranteeing
that they do not respond to consumers until the internal state has
stabilized after startup. This CL implements this functionaliy, having
IdentityService queue pending IdentityManager connection requests until
all refresh tokens have been loaded.

Note that this change requires that consumers of the Identity Service
ensure that the PO2TS's tokens are loaded if connecting to the
Identity Service in test contexts, as otherwise the connection to the
Identity Service will hang. In production, it's guaranteed that the
PO2TS will fire OnRefreshTokensLoaded() as part of startup (see the
relevant CLs https://codereview.chromium.org/1380103004 and
https://codereview.chromium.org/1523743003).


TBR=rockot@chromium.org, achuith@chromium.org

Bug: 740117
Change-Id: Id5c9c1ef7e2975204b3c2c004b7b5a714f6499b9
Reviewed-on: https://chromium-review.googlesource.com/565407
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486332}
[modify] https://crrev.com/6430f5dc23868995c86cfbb3829978e7cb34bf32/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/6430f5dc23868995c86cfbb3829978e7cb34bf32/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/6430f5dc23868995c86cfbb3829978e7cb34bf32/services/identity/README.md
[modify] https://crrev.com/6430f5dc23868995c86cfbb3829978e7cb34bf32/services/identity/identity_manager_unittest.cc
[modify] https://crrev.com/6430f5dc23868995c86cfbb3829978e7cb34bf32/services/identity/identity_service.cc
[modify] https://crrev.com/6430f5dc23868995c86cfbb3829978e7cb34bf32/services/identity/identity_service.h
[modify] https://crrev.com/6430f5dc23868995c86cfbb3829978e7cb34bf32/services/identity/public/interfaces/identity_manager.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1

commit 4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Tue Jul 25 21:15:55 2017

Revert "Identity Service: Queue requests until internal state is stable"

This reverts commit 6430f5dc23868995c86cfbb3829978e7cb34bf32.

Reason for revert: This prevented apps from obtaining auth tokens in
Kiosk mode.

ProfileOAuth2TokenService::OnRefreshTokensLoaded() is not fired on
ChromeOS in kiosk mode, so this CL was causing calls to
chrome.identity.getAuthToken() to hang forever in that context (as the
implementation of that function connects to the Identity Service).

Original change's description:
> Identity Service: Queue requests until internal state is stable
>
> Chromium's signin code currently allows querying signin state before
> all information has been loaded from disk at startup (e.g., before all
> refresh tokens have been loaded). This forces consumers to worry about
> the edge case of a refresh token not being available simply because it
> hasn't been loaded yet.
>
> The Identity Service APIs can eliminate this edge case by guaranteeing
> that they do not respond to consumers until the internal state has
> stabilized after startup. This CL implements this functionaliy, having
> IdentityService queue pending IdentityManager connection requests until
> all refresh tokens have been loaded.
>
> Note that this change requires that consumers of the Identity Service
> ensure that the PO2TS's tokens are loaded if connecting to the
> Identity Service in test contexts, as otherwise the connection to the
> Identity Service will hang. In production, it's guaranteed that the
> PO2TS will fire OnRefreshTokensLoaded() as part of startup (see the
> relevant CLs https://codereview.chromium.org/1380103004 and
> https://codereview.chromium.org/1523743003).
>
>
> TBR=rockot@chromium.org, achuith@chromium.org
>
> Bug: 740117
> Change-Id: Id5c9c1ef7e2975204b3c2c004b7b5a714f6499b9
> Reviewed-on: https://chromium-review.googlesource.com/565407
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486332}

TBR=achuith@chromium.org,rockot@chromium.org,blundell@chromium.org,msarda@chromium.org,mkwst@chromium.org


Bug: 744708
Change-Id: I4342728570d9d0d3fde0b0caaaf0b61570041b10
Reviewed-on: https://chromium-review.googlesource.com/585550
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489434}
[modify] https://crrev.com/4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1/services/identity/README.md
[modify] https://crrev.com/4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1/services/identity/identity_manager_unittest.cc
[modify] https://crrev.com/4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1/services/identity/identity_service.cc
[modify] https://crrev.com/4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1/services/identity/identity_service.h
[modify] https://crrev.com/4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1/services/identity/public/interfaces/identity_manager.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b489297814d46d4f0e5227666d04855ad87a850c

commit b489297814d46d4f0e5227666d04855ad87a850c
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Tue Jul 25 21:48:49 2017

Revert "Identity Service: Queue requests until internal state is stable"

This reverts commit 6430f5dc23868995c86cfbb3829978e7cb34bf32.

Reason for revert: This prevented apps from obtaining auth tokens in
Kiosk mode.

ProfileOAuth2TokenService::OnRefreshTokensLoaded() is not fired on
ChromeOS in kiosk mode, so this CL was causing calls to
chrome.identity.getAuthToken() to hang forever in that context (as the
implementation of that function connects to the Identity Service).

(cherry picked from commit 4f1e4bf3e0c10626dc1fc3fdba19f49c9f7880d1)

Original change's description:
> Identity Service: Queue requests until internal state is stable
>
> Chromium's signin code currently allows querying signin state before
> all information has been loaded from disk at startup (e.g., before all
> refresh tokens have been loaded). This forces consumers to worry about
> the edge case of a refresh token not being available simply because it
> hasn't been loaded yet.
>
> The Identity Service APIs can eliminate this edge case by guaranteeing
> that they do not respond to consumers until the internal state has
> stabilized after startup. This CL implements this functionaliy, having
> IdentityService queue pending IdentityManager connection requests until
> all refresh tokens have been loaded.
>
> Note that this change requires that consumers of the Identity Service
> ensure that the PO2TS's tokens are loaded if connecting to the
> Identity Service in test contexts, as otherwise the connection to the
> Identity Service will hang. In production, it's guaranteed that the
> PO2TS will fire OnRefreshTokensLoaded() as part of startup (see the
> relevant CLs https://codereview.chromium.org/1380103004 and
> https://codereview.chromium.org/1523743003).
>
>
> TBR=rockot@chromium.org, achuith@chromium.org
>
> Bug: 740117
> Change-Id: Id5c9c1ef7e2975204b3c2c004b7b5a714f6499b9
> Reviewed-on: https://chromium-review.googlesource.com/565407
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486332}

TBR=achuith@chromium.org,rockot@chromium.org,blundell@chromium.org,msarda@chromium.org,mkwst@chromium.org

Bug: 744708
Change-Id: I4342728570d9d0d3fde0b0caaaf0b61570041b10
Reviewed-on: https://chromium-review.googlesource.com/585550
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489434}
Reviewed-on: https://chromium-review.googlesource.com/584849
Cr-Commit-Position: refs/branch-heads/3163@{#38}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b489297814d46d4f0e5227666d04855ad87a850c/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/b489297814d46d4f0e5227666d04855ad87a850c/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/b489297814d46d4f0e5227666d04855ad87a850c/services/identity/README.md
[modify] https://crrev.com/b489297814d46d4f0e5227666d04855ad87a850c/services/identity/identity_manager_unittest.cc
[modify] https://crrev.com/b489297814d46d4f0e5227666d04855ad87a850c/services/identity/identity_service.cc
[modify] https://crrev.com/b489297814d46d4f0e5227666d04855ad87a850c/services/identity/identity_service.h
[modify] https://crrev.com/b489297814d46d4f0e5227666d04855ad87a850c/services/identity/public/interfaces/identity_manager.mojom

Blocked on solving the ChromeOS issue described in  crbug.com/749535 .

As described in  crbug.com/769621 , I think that the best way to safely make this change is to first change PO2TS/SigninManager to internally guarantee that tokens are loaded as part of their startup.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdf260ef72ba767a32b772aa34cac082381b2ec6

commit bdf260ef72ba767a32b772aa34cac082381b2ec6
Author: Jochen Eisinger <jochen@chromium.org>
Date: Wed Dec 19 18:55:20 2018

Have SigninManagerBase::Initialize guarantee to load refresh tokens

This will guarantee that we always fire OnRefreshTokensLoaded during profile
startup.

Previously, on Chrome OS, this wasn't always the case, e.g., for guest mode, or
managed users, this was not invoked.

BUG= 749535 ,740117,915628
R=blundell@chromium.org

Change-Id: Ibecad59e6eb40db85a2090af4d59940c3d79b54b
Reviewed-on: https://chromium-review.googlesource.com/c/1374985
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617896}
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/browser/download/notification/download_notification_interactive_uitest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/browser/signin/fake_signin_manager_builder.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/browser/signin/signin_manager_factory.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/chrome/test/base/chrome_render_view_host_test_harness.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/search_provider_logos/logo_service_impl_unittest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/signin/core/browser/fake_signin_manager.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/signin/core/browser/fake_signin_manager.h
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/signin/core/browser/signin_manager.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/signin/core/browser/signin_manager.h
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/signin/core/browser/signin_manager_base.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/signin/core/browser/signin_manager_base.h
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/components/signin/core/browser/signin_tracker_unittest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/services/identity/identity_manager_impl_unittest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/services/identity/public/cpp/accounts_mutator.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/services/identity/public/cpp/accounts_mutator.h
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/services/identity/public/cpp/accounts_mutator_unittest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/services/identity/public/cpp/identity_manager_unittest.cc
[modify] https://crrev.com/bdf260ef72ba767a32b772aa34cac082381b2ec6/services/identity/public/cpp/identity_test_environment.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11a9a05dbff5010b373489ed176d0992841c53eb

commit 11a9a05dbff5010b373489ed176d0992841c53eb
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Dec 19 21:24:43 2018

Revert "Have SigninManagerBase::Initialize guarantee to load refresh tokens"

This reverts commit bdf260ef72ba767a32b772aa34cac082381b2ec6.

Reason for revert: SigninInteractionControllerTestCase fails on chromium.mac/ios-slimnav (see  https://crbug.com/916731  )

Original change's description:
> Have SigninManagerBase::Initialize guarantee to load refresh tokens
> 
> This will guarantee that we always fire OnRefreshTokensLoaded during profile
> startup.
> 
> Previously, on Chrome OS, this wasn't always the case, e.g., for guest mode, or
> managed users, this was not invoked.
> 
> BUG= 749535 ,740117,915628
> R=​blundell@chromium.org
> 
> Change-Id: Ibecad59e6eb40db85a2090af4d59940c3d79b54b
> Reviewed-on: https://chromium-review.googlesource.com/c/1374985
> Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617896}

TBR=blundell@chromium.org,msarda@chromium.org,jochen@chromium.org

Change-Id: I32e10a4181cafd97b2f53f17e755b870ecdfc302
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  749535 , 740117, 915628
Reviewed-on: https://chromium-review.googlesource.com/c/1384640
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617951}
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/browser/download/notification/download_notification_interactive_uitest.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/browser/signin/fake_signin_manager_builder.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/browser/signin/signin_manager_factory.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/chrome/test/base/chrome_render_view_host_test_harness.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/components/signin/core/browser/fake_signin_manager.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/components/signin/core/browser/fake_signin_manager.h
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/components/signin/core/browser/signin_manager.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/components/signin/core/browser/signin_manager.h
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/components/signin/core/browser/signin_manager_base.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/components/signin/core/browser/signin_manager_base.h
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/components/signin/core/browser/signin_tracker_unittest.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/services/identity/identity_manager_impl_unittest.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/services/identity/public/cpp/accounts_mutator.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/services/identity/public/cpp/accounts_mutator.h
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/services/identity/public/cpp/accounts_mutator_unittest.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/services/identity/public/cpp/identity_manager_unittest.cc
[modify] https://crrev.com/11a9a05dbff5010b373489ed176d0992841c53eb/services/identity/public/cpp/identity_test_environment.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19ee90e7fcaf8c82d346506e71133b7071df1ef6

commit 19ee90e7fcaf8c82d346506e71133b7071df1ef6
Author: Jochen Eisinger <jochen@chromium.org>
Date: Thu Dec 20 14:22:46 2018

Reland "Have SigninManagerBase::Initialize guarantee to load refresh tokens"

This reverts commit 11a9a05dbff5010b373489ed176d0992841c53eb.

Reason for revert: Unclear how the test failure should be related to this CL

Original change's description:
> Revert "Have SigninManagerBase::Initialize guarantee to load refresh tokens"
> 
> This reverts commit bdf260ef72ba767a32b772aa34cac082381b2ec6.
> 
> Reason for revert: SigninInteractionControllerTestCase fails on chromium.mac/ios-slimnav (see  https://crbug.com/916731  )
> 
> Original change's description:
> > Have SigninManagerBase::Initialize guarantee to load refresh tokens
> > 
> > This will guarantee that we always fire OnRefreshTokensLoaded during profile
> > startup.
> > 
> > Previously, on Chrome OS, this wasn't always the case, e.g., for guest mode, or
> > managed users, this was not invoked.
> > 
> > BUG= 749535 ,740117,915628
> > R=​blundell@chromium.org
> > 
> > Change-Id: Ibecad59e6eb40db85a2090af4d59940c3d79b54b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1374985
> > Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> > Reviewed-by: Colin Blundell <blundell@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#617896}
> 
> TBR=blundell@chromium.org,msarda@chromium.org,jochen@chromium.org
> 
> Change-Id: I32e10a4181cafd97b2f53f17e755b870ecdfc302
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  749535 , 740117, 915628
> Reviewed-on: https://chromium-review.googlesource.com/c/1384640
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617951}

TBR=blundell@chromium.org,msarda@chromium.org,jochen@chromium.org,lethalantidote@chromium.org

Change-Id: Ie84f18559a192f516d11960d2c3047291d3687e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  749535 , 740117, 915628
Reviewed-on: https://chromium-review.googlesource.com/c/1386427
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618205}
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/browser/download/notification/download_notification_interactive_uitest.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/browser/signin/fake_signin_manager_builder.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/browser/signin/signin_manager_factory.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/chrome/test/base/chrome_render_view_host_test_harness.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/components/signin/core/browser/fake_signin_manager.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/components/signin/core/browser/fake_signin_manager.h
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/components/signin/core/browser/signin_manager.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/components/signin/core/browser/signin_manager.h
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/components/signin/core/browser/signin_manager_base.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/components/signin/core/browser/signin_manager_base.h
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/components/signin/core/browser/signin_tracker_unittest.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/services/identity/identity_manager_impl_unittest.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/services/identity/public/cpp/accounts_mutator.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/services/identity/public/cpp/accounts_mutator.h
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/services/identity/public/cpp/accounts_mutator_unittest.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/services/identity/public/cpp/identity_manager_unittest.cc
[modify] https://crrev.com/19ee90e7fcaf8c82d346506e71133b7071df1ef6/services/identity/public/cpp/identity_test_environment.cc