New issue
Advanced search Search tips

Issue 740106 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 715051



Sign in to add a comment

Record metrics for Media Engagement

Project Member Reported by mlamouri@chromium.org, Jul 7 2017

Issue description

=Histograms=
The following histograms will be recorded:
 - Score buckets at service startup: in order to see the distribution of the scores across users, when the service will be started (ie. at Chrome launch), all the scores will be recorded. Knowing the distribution of scores will help us figure out where the minimum value should be put and how the score evolves with time when the algorithm is tweaked.
 - Score when playback is started: it will give an overview of how many playbacks would be whitelisted for a given score.
 - Reason why a playback isn’t significant: it will share the reasons why a playback ended up not significant and help tweak the algorithm.

=UKM=
When a visit has ended (navigation, tab closed, etc) the following UKM entry will be sent:
origin | ∑_media_playbacks | ∑_visits | ∑_score | Δ_media_playbacks

The delta playback would be the number of playbacks during that visit. This information will allow to rebuild the score of a given origin across all users sending UKM and see the impact of a change in the algorithm using the total playbacks/visits. The total score will be used to see the score of a given website across users.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6119c1994f58533842753469ef78f5d347c93ac5

commit 6119c1994f58533842753469ef78f5d347c93ac5
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Jul 14 13:28:55 2017

Media Engagement: Record score at playback.

Record the Media Engagement score at playback to a histogram
so we can see if the playback would have been blocked.

BUG= 740106 

Change-Id: I7ed9659e64fd9ffcae3eafaccdf32e6755165ccb
Reviewed-on: https://chromium-review.googlesource.com/566862
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486747}
[modify] https://crrev.com/6119c1994f58533842753469ef78f5d347c93ac5/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/6119c1994f58533842753469ef78f5d347c93ac5/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/6119c1994f58533842753469ef78f5d347c93ac5/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/6119c1994f58533842753469ef78f5d347c93ac5/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab05af768d594139922d331f6824485950cebdef

commit ab05af768d594139922d331f6824485950cebdef
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Jul 14 22:35:47 2017

Media Engagement: Record distribution of scores at startup.

Log the scores when the Media Engagement service is started to
see the distribution of scores across users.

BUG= 740106 

Change-Id: I539e0c0542caf3d0c094d76c3eb4798ae7a5e300
Reviewed-on: https://chromium-review.googlesource.com/566958
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486914}
[modify] https://crrev.com/ab05af768d594139922d331f6824485950cebdef/chrome/browser/media/media_engagement_service.cc
[modify] https://crrev.com/ab05af768d594139922d331f6824485950cebdef/chrome/browser/media/media_engagement_service.h
[modify] https://crrev.com/ab05af768d594139922d331f6824485950cebdef/chrome/browser/media/media_engagement_service_unittest.cc
[modify] https://crrev.com/ab05af768d594139922d331f6824485950cebdef/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339dedb0b988c1c41c590f67763d6fc5f338661f

commit 339dedb0b988c1c41c590f67763d6fc5f338661f
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Jul 19 10:22:09 2017

Media Engagement: Record UKM metrics

Record UKM metrics when the visit has ended (navigation, tab closed)
containing the total visits, total media playbacks, score and
new media playbacks during this visit.

BUG= 740106 

Change-Id: I6b3d3888f5019cc6cf8ebf67b8fc08cfeda681f4
Reviewed-on: https://chromium-review.googlesource.com/567183
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487815}
[modify] https://crrev.com/339dedb0b988c1c41c590f67763d6fc5f338661f/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/339dedb0b988c1c41c590f67763d6fc5f338661f/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/339dedb0b988c1c41c590f67763d6fc5f338661f/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/339dedb0b988c1c41c590f67763d6fc5f338661f/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/339dedb0b988c1c41c590f67763d6fc5f338661f/tools/metrics/ukm/ukm.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b2f33ea01342e668720763407aa1f7d66143d15

commit 6b2f33ea01342e668720763407aa1f7d66143d15
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Jul 19 13:43:38 2017

Media Engagement: Record insignificant playback reason metrics

If a player wasn't added or removed from significant players then
we should record the reason why to a histogram.

BUG= 740106 

Change-Id: I80c94c3837b8756aee10cfb457d9af849c8014d7
Reviewed-on: https://chromium-review.googlesource.com/565566
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487846}
[modify] https://crrev.com/6b2f33ea01342e668720763407aa1f7d66143d15/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/6b2f33ea01342e668720763407aa1f7d66143d15/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/6b2f33ea01342e668720763407aa1f7d66143d15/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/6b2f33ea01342e668720763407aa1f7d66143d15/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6b2f33ea01342e668720763407aa1f7d66143d15/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Blocking: 715051

Sign in to add a comment