New issue
Advanced search Search tips

Issue 740105 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 715051



Sign in to add a comment

Run the Media Engagement Service on Android

Project Member Reported by mlamouri@chromium.org, Jul 7 2017

Issue description

The service is currently disabled on Android but we should run it to gather data even if it will not be used for the autoplay policy at the moment.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a69b95bdaa7e2df899e7bb02b0c7680748bdd4

commit b3a69b95bdaa7e2df899e7bb02b0c7680748bdd4
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Jul 12 17:44:12 2017

Media Engagement: Remove the WasRecentlyAudible check on Android

Power Level Monitoring is disabled on Android so WasRecentlyAudible
will always return false. Therefore we should not perform this
check on Android.

BUG= 740105 

Change-Id: I7a4fb85e95472d95b0efc9336a46e49ea00f36f8
Reviewed-on: https://chromium-review.googlesource.com/567935
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486011}
[modify] https://crrev.com/b3a69b95bdaa7e2df899e7bb02b0c7680748bdd4/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/b3a69b95bdaa7e2df899e7bb02b0c7680748bdd4/chrome/browser/media/media_engagement_contents_observer_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1ee503633410012f1c12af6366d85a3237dabf9

commit d1ee503633410012f1c12af6366d85a3237dabf9
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jul 13 14:07:18 2017

Media Engagement: Switch the service on by default.

The Media Engagement Service should now be switched on by default.
This will only gather data to see how it will behave. Bypassing
autoplay policies will be under a different feature flag.

BUG= 740105 

Change-Id: I579ecc7ac3c87fe6d3de2604928f9e15c79751a7
Reviewed-on: https://chromium-review.googlesource.com/567980
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486364}
[modify] https://crrev.com/d1ee503633410012f1c12af6366d85a3237dabf9/media/base/media_switches.cc

Status: Fixed (was: Assigned)
Blocking: 715051

Sign in to add a comment