New issue
Advanced search Search tips

Issue 740102 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 732681



Sign in to add a comment

Add UMA for how often a service worker started for the omnibox hint was actually used

Project Member Reported by falken@chromium.org, Jul 7 2017

Issue description

This tells us the accuracy of the heuristic. 

We may also want UMA for how often a renderer process was created for the worker.
 
Cc: jdonnelly@chromium.org

Comment 2 by horo@chromium.org, Jul 10 2017

Owner: horo@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1

commit 672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Jul 12 04:11:19 2017

Fix Service Worker UMAs of NEW_PROCESS

In the current implementation, when SiteInstance was used to get the
process, the Service Worker UMAs are recorded as NEW_PROCESS. But This
is not accurate. SiteInstance can reuse the existing process.

This CL also splits the EXISTING_PROCESS UMAs to EXISTING_READY_PROCESS
and EXISTING_UNREADY_PROCESS. When PlzNavigate is enabled, the service
worker is likely to be started in an existing unready process which was
newly created for the navigation. We should record this case apart from
starting in an existing ready process.

Bug:  740102 
Change-Id: I523cea926fb78eb25e2669cfa0a3d56ca003e08c
Reviewed-on: https://chromium-review.googlesource.com/564912
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485839}
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_metrics_unittest.cc
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_process_manager.h
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/672f26e7d115ad9ef24b83f2bf9c4fbe986b0aa1/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed744dda895f088dc4a80622996acd89396f5867

commit ed744dda895f088dc4a80622996acd89396f5867
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Jul 12 06:15:01 2017

Revive ServiceWorker.NavigationHintPrecision UMA as StartHintPrecision

I removed the UMA (ServiceWorker.NavigationHintPrecision) when we stopped
"Speculatively start Service Workers on UI-events" experiment ( crbug.com/616502 ).
But we will start "Warm-up service worker on omnibox signal" experiment
( crbug.com/732681 ).
So this CL revive the UMA as ServiceWorker.StartHintPrecision.

Bug:  740102 
Change-Id: I84034f9a3c8edb9ff25e5644d6b94c624ae00f1c
Reviewed-on: https://chromium-review.googlesource.com/566138
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485876}
[modify] https://crrev.com/ed744dda895f088dc4a80622996acd89396f5867/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/ed744dda895f088dc4a80622996acd89396f5867/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/ed744dda895f088dc4a80622996acd89396f5867/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/ed744dda895f088dc4a80622996acd89396f5867/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/ed744dda895f088dc4a80622996acd89396f5867/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/ed744dda895f088dc4a80622996acd89396f5867/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ddf281f2129829bc2ee24c84e1e4b510c508135

commit 6ddf281f2129829bc2ee24c84e1e4b510c508135
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Fri Jul 14 04:02:48 2017

Record the result of starting service worker for a navigation hint.

Bug:  740102 
Change-Id: I250fde1868f3c244c8db51a2fcf54d30c946f470
Reviewed-on: https://chromium-review.googlesource.com/564958
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486668}
[modify] https://crrev.com/6ddf281f2129829bc2ee24c84e1e4b510c508135/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/6ddf281f2129829bc2ee24c84e1e4b510c508135/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/6ddf281f2129829bc2ee24c84e1e4b510c508135/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/6ddf281f2129829bc2ee24c84e1e4b510c508135/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/6ddf281f2129829bc2ee24c84e1e4b510c508135/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/6ddf281f2129829bc2ee24c84e1e4b510c508135/content/public/browser/service_worker_context.h
[modify] https://crrev.com/6ddf281f2129829bc2ee24c84e1e4b510c508135/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6ddf281f2129829bc2ee24c84e1e4b510c508135/tools/metrics/histograms/histograms.xml

Comment 6 by horo@chromium.org, Jul 14 2017

Status: Fixed (was: Started)

Sign in to add a comment