New issue
Advanced search Search tips

Issue 740090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-07-21
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Deprecate json output format for benchmark list command

Project Member Reported by nedngu...@google.com, Jul 7 2017

Issue description

Now that all benchmark are swarmed, we no longer need this.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google
The NextAction date has arrived: 2017-07-21
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f359dd1d5b17d012810de53d2609ddb385739814

commit f359dd1d5b17d012810de53d2609ddb385739814
Author: nednguyen <nednguyen@google.com>
Date: Tue Jul 25 18:12:23 2017

[tools/perf] Remove list json smoke tests

We no longer support json format for benchmark list command, hence
these tests are not needed.

Bug:  chromium:740090 , chromium:748513
Change-Id: Ibf8056be0c6f14e822ad11a33e0db5c33001a580
Reviewed-on: https://chromium-review.googlesource.com/584944
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#489371}
[modify] https://crrev.com/f359dd1d5b17d012810de53d2609ddb385739814/tools/perf/scripts_smoke_unittest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c98e5405cccddf557a9c99069d7c0e859b7a310c

commit c98e5405cccddf557a9c99069d7c0e859b7a310c
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jul 26 15:08:24 2017

Roll src/third_party/catapult/ b5d2ffa3c..624deb924 (34 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b5d2ffa3c55a..624deb924d12

$ git log b5d2ffa3c..624deb924 --date=short --no-merges --format='%ad %ae %s'
2017-07-26 kraynov Android systrace: Show memory maps in TraceViewer.
2017-07-25 benjhayden Fix LineChart's dots.
2017-07-25 benjhayden Unambiguously indicate demo dashboard builds.
2017-07-25 crouleau Add an option to enable Chrome's --v=2
2017-07-25 pcc run_dev_server_tests: Print stderr after stdout.
2017-07-25 phsilva Ownership into GenericSets
2017-07-25 benjhayden Allow users to dismiss import warnings.
2017-07-25 loloangela Fixed errors related to bad-continuation pt.24
2017-07-25 loloangela Fixed errors related to bad-continuation pt.25
2017-07-25 xunjieli [wpr-go] Minor fix to legacyformatconvertor.go
2017-07-25 eakuefner [eslint] Delete comment from .eslintrc
2017-07-25 loloangela Fixed errors related to bad-continuation pt.23
2017-07-25 benjhayden Refactor tests to use new reserved GenericSets instead of TelemetryInfo.
2017-07-25 simonhatch Tracing - Move diagnostics to use a registry instead of discover module.
2017-07-25 etienneb Add support for breakpad symbolisation of linux trace.
2017-07-25 loloangela Fixed errors related to bad-continuation pt.20
2017-07-25 loloangela Fixed errors related to bad-continuation pt.19
2017-07-25 loloangela Fixed errors related to bad-continuation pt.18
2017-07-25 kraynov Android systrace: Atrace process dump importer V1.
2017-07-25 perezju [Telemetry] Restore telemetry.util.bot_utils
2017-07-25 perezju [Telemetry] Remove CheckSharedStates in StorySetUnitTest.testSmoke
2017-07-24 loloangela Fixed errors related to bad-continuation pt.16
2017-07-24 loloangela Fixed errors related to bad-continuation part 15
2017-07-24 loloangela Fixed errors related to bad-continuation pt.17
2017-07-24 loloangela Fixed errors related to bad-continuation
2017-07-24 loloangela Fixed errors related to bad-continuation Part 14
2017-07-24 xunjieli [wpr-go] Make ephemeral port support less flaky
2017-07-24 sullivan Remove benchmark health report link from dashboard menu
2017-07-24 loloangela Fixed errors related to bad-continuation
2017-07-24 xunjieli [wpr-go] Add a temporary script to convert legacy format
2017-07-24 loloangela Fixed errors related to bad-continuation
2017-07-24 perezju [Telemetry] Remove unused story_runner.StoryGroup
2017-07-24 nednguyen Remove support for json output format for benchmark list command
2017-07-24 perezju [Telemetry] Remove support for mixed shared states

Created with:
  roll-dep src/third_party/catapult
BUG= 739783 , 740090 ,746251,746251, 740090 ,746251


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iabd4aad0c4fefd98ec4d19cc25dd942ffac9eda9
Reviewed-on: https://chromium-review.googlesource.com/586767
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489644}
[modify] https://crrev.com/c98e5405cccddf557a9c99069d7c0e859b7a310c/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b6f7365e880804491cb157cfd911e7cae7fd65b

commit 6b6f7365e880804491cb157cfd911e7cae7fd65b
Author: nednguyen <nednguyen@google.com>
Date: Thu Jul 27 04:34:11 2017

Remove usage of telemetry.utils.bot_util in sharding_map_generator.py

I verify that running tools/perf/generate_perf_data does not generate
any changes, thus proving that these code are dead code.

Bug:  740090 
Change-Id: Id1b8409cdc12e0129f4572a200b3746a5fad2715
Reviewed-on: https://chromium-review.googlesource.com/586925
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#489857}
[modify] https://crrev.com/6b6f7365e880804491cb157cfd911e7cae7fd65b/tools/perf/core/sharding_map_generator.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38dce83174a767ffdaea9c7d6f45b6391e1d4fc2

commit 38dce83174a767ffdaea9c7d6f45b6391e1d4fc2
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Jul 27 15:49:08 2017

Roll src/third_party/catapult/ 0f1f20d43..6c649ea4b (5 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0f1f20d4390e..6c649ea4b077

$ git log 0f1f20d43..6c649ea4b --date=short --no-merges --format='%ad %ae %s'
2017-07-27 simonhatch Dashboard - Add mapping from bot names to swarming dimensions.
2017-07-27 loloangela Fixed errors related to bad-continuation pt.30
2017-07-27 nednguyen Revert of [Telemetry] Restore telemetry.util.bot_utils (patchset #1 id:1 of https://codereview.chromium.org/2984953003/ )
2017-07-26 nednguyen Add win 32 bit build for wprgo binary
2017-07-26 nednguyen Update wpr binary to the latest version

Created with:
  roll-dep src/third_party/catapult
BUG= 740090 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I5b7e65b04fd62c1d350284c512eaf88cb52a8d78
Reviewed-on: https://chromium-review.googlesource.com/589289
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489944}
[modify] https://crrev.com/38dce83174a767ffdaea9c7d6f45b6391e1d4fc2/DEPS

Cc: eyaich@chromium.org
Status: Fixed (was: Assigned)
eyaich@: FYI
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment