New issue
Advanced search Search tips

Issue 740081 link

Starred by 4 users
Status: Fixed
Owner:
engedy@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on: View detail
issue 700180
issue 729021
Blocking:
issue 733029


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Complete Mojofication of the Credential Manager API

Project Member Reported by engedy@chromium.org, Jul 7 2017 
Tracking bug for making Source/modules/credentialmanager/ talk directly to the browser-side implementation in components/password_manager/content/browser/ using Mojo.

This will allow us to remove multiple layers of indirection and duplicates of data structures, namely:

 * public/platform/: everything CM API related, namely:
    -- WebCredentialManagerClient,
    -- Web*Credential* data structures.

 * Source/platform/credentialmanager/: everything, namely:
    -- Platform*Credential data structures.    

 * Source/modules/credentialmanager/:
    -- WebCredentialManagerClient,
    -- blink::CredentialManagerClient

 * components/password_manager/content/renderer/: everything, namely:
    -- password_manager::CredentialManagerClient

 * components/password_manager/content/common/: everything, namely:
    -- credential_manager.mojom is moved to public/platform/modules/credentialmanager
    -- type mappings is moved to components/password_manager/content/browser

 * components/password_manager/core/common/: everything CM API related, namely:
    -- credential_manager_types* is moved to components/password_manager/core/browser

Comment 1 by engedy@chromium.org, Jul 7 2017

Components: Blink>SecurityFeature>CredentialManagement

Comment 2 by engedy@chromium.org, Jul 8 2017

Blockedon: 700180
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8645159377621c4f703fa60a155b6abd5e583046

commit 8645159377621c4f703fa60a155b6abd5e583046
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Jul 10 14:09:54 2017

CM API: Move Mojo interface definition into Blink

Move components/password_manager/content/common/credential_manager.mojom
into third_party/WebKit/public/platform/modules/credentialmanager/.

This is preparation for letting WebKit/Source/modules/ talk to the
Credential Manager API implementation directly using Mojo, instead of
needing to go through components/password_manager/content/renderer.

Bug:  740081 
Change-Id: I5b59ac13fc088c0e6482fb2bfd5bd9dbb73b084b
Reviewed-on: https://chromium-review.googlesource.com/563407
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485259}
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/chrome/browser/BUILD.gn
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/chrome/common/BUILD.gn
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/components/password_manager/content/browser/BUILD.gn
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/components/password_manager/content/browser/credential_manager_impl.h
[delete] https://crrev.com/1ab1bcf70718cc457e34d746b27ea2dd9a94871f/components/password_manager/content/common/BUILD.gn
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/components/password_manager/content/common/OWNERS
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/components/password_manager/content/common/credential_manager.typemap
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/components/password_manager/content/common/credential_manager_struct_traits.h
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/components/password_manager/content/renderer/BUILD.gn
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/components/password_manager/content/renderer/credential_manager_client.h
[modify] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/third_party/WebKit/public/platform/modules/credentialmanager/OWNERS
[rename] https://crrev.com/8645159377621c4f703fa60a155b6abd5e583046/third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom

Comment 4 by engedy@chromium.org, Jul 17 2017

Blockedon: 729021

Comment 5 by kpaulhamus@chromium.org, Aug 10 2017

Blocking: 733029

Comment 6 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/956a40f19064fa752655033100dd2a508b192330

commit 956a40f19064fa752655033100dd2a508b192330
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Nov 24 09:17:04 2017

Clean up layouttests for Credential Manager.

 -- Convert async_tests to promise_tests.
 -- Avoid using the same name for multiple tests, which results in
    testharness.js internal errors.
 -- Remove duplicate FederatedCredential constructor test.
 -- Remove unused script import in *-create-basics.html
 -- Use more concise arrow function notation where possible.
 -- Remove now unused *-expected.txt files.

Bug:  740081 
Change-Id: Ic308fec1b7b0c437433df2ada5c400c4b1a5f77f
Reviewed-on: https://chromium-review.googlesource.com/788190
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519074}
[modify] https://crrev.com/956a40f19064fa752655033100dd2a508b192330/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/956a40f19064fa752655033100dd2a508b192330/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/956a40f19064fa752655033100dd2a508b192330/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-preventsilentaccess-basics.html
[delete] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-store-basics-expected.txt
[modify] https://crrev.com/956a40f19064fa752655033100dd2a508b192330/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-store-basics.html
[delete] https://crrev.com/ce523e632310e04ebe399f63c8a0c3ab32edac7c/third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics-expected.txt
[modify] https://crrev.com/956a40f19064fa752655033100dd2a508b192330/third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f87dd3c50743284aa8c44360424c4168d2a0552

commit 0f87dd3c50743284aa8c44360424c4168d2a0552
Author: Balazs Engedy <engedy@chromium.org>
Date: Tue Nov 28 10:04:09 2017

Resolve navigator.credentials.get() with `null`.

According to [1], if there are no credentials to return,
navigator.credentials.get() should resolve the returned promise with
`null`, and not with `undefined`. After this CL the implementation is
now in compliance with the spec.

[1]: https://www.w3.org/TR/credential-management-1/#abstract-opdef-request-a-credential

Bug:  740081 
Change-Id: I7ad62bf8d06c5e06d244ed5a3b6b067c233826b1
Reviewed-on: https://chromium-review.googlesource.com/787980
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519633}
[modify] https://crrev.com/0f87dd3c50743284aa8c44360424c4168d2a0552/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/0f87dd3c50743284aa8c44360424c4168d2a0552/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2343303104e6c14fd8ef11fd968a012c5bbb8aa

commit c2343303104e6c14fd8ef11fd968a012c5bbb8aa
Author: Balazs Engedy <engedy@chromium.org>
Date: Wed Dec 20 10:54:58 2017

Align IsIconURLEmptyOrSecure with the spec.

Align the behavior of navigator.credentials.store() with the spec [1]
when deciding if the |iconURL| of the passed in PasswordCredential or
FederatedCredential is an `a priori authenticated URL`.

[1]: https://www.w3.org/TR/mixed-content/#a-priori-authenticated-url

Bug:  740081 
Change-Id: I2d9ae6c61cc0f3cf3687dfe99aec09b08b078efd
Reviewed-on: https://chromium-review.googlesource.com/833913
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525301}
[modify] https://crrev.com/c2343303104e6c14fd8ef11fd968a012c5bbb8aa/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-store-basics.html
[modify] https://crrev.com/c2343303104e6c14fd8ef11fd968a012c5bbb8aa/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/924ad84c29d0f2278f09236f6ac7a095972bef0b

commit 924ad84c29d0f2278f09236f6ac7a095972bef0b
Author: Balazs Engedy <engedy@chromium.org>
Date: Wed Dec 20 14:29:43 2017

Reorder methods in CredentialsContainer.

Move method definitions after type definitions to comply with style guide,
and rearrange methods to make more sense.

Bug:  740081 
Change-Id: I0c77ac065203d9d917815151417ea1d24de56b61
Reviewed-on: https://chromium-review.googlesource.com/833887
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525326}
[modify] https://crrev.com/924ad84c29d0f2278f09236f6ac7a095972bef0b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6310ca186ac7c5ff7737412a4e1649b3698f2d8

commit f6310ca186ac7c5ff7737412a4e1649b3698f2d8
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Dec 21 10:05:36 2017

Remove unused Credential Management API errors.

Namely, remove the following enum values in Mojo interfaces:
 -- AuthenticatorStatus::CANCELLED,
 -- AuthenticatorStatus::SECURITY_ERROR,
 -- CredentialManagerError::DISABLED,
as well as all corresponding conversion routines and native enum values.

Bug:  740081 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic06053084846c3a2e053ebfd527da9cb3db40ec8
Reviewed-on: https://chromium-review.googlesource.com/836592
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525661}
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/components/password_manager/content/common/credential_manager_struct_traits.cc
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/components/password_manager/content/renderer/credential_manager_client.cc
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/components/password_manager/core/common/credential_manager_types.h
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/content/shell/test_runner/mock_credential_manager_client.cc
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/ios/chrome/browser/passwords/credential_manager.mm
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-errors.html
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/third_party/WebKit/public/platform/WebCredentialManagerError.h
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom
[modify] https://crrev.com/f6310ca186ac7c5ff7737412a4e1649b3698f2d8/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/593cc44ba056aa6b278a73af08bc8bf814351512

commit 593cc44ba056aa6b278a73af08bc8bf814351512
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Dec 21 16:29:46 2017

Let CredentialsContainer call mojom::CredentialManager directly.

Previously, calls were plumbed through several layers, for example, a
call to navigator.credentials.get() went through:
 1) CredentialsContainer::get (in Source/modules)
 2) CredentialManagerClient::DispatchGet (in Source/modules)
 3) WebCredentialManagerClient::DispatchGet (in public/platform)
 4) CredentialManagerClient::DispatchGet (in c/pw_m/content/renderer)
 5) mojom::CredentialManager::Get

With this CL, layers 2..4 are completely removed, and the implementation
of navigator.credentials methods in CredentialsContainer will now call
into the mojom::CredentialManager interface directly.

This allows removing:
 -- everything in components/password_manager/content/renderer,
 -- everything in WebKit/Source/platform/credentialmanager, that is, all
    Platform*Credential types.
 -- everything credential management related in WebKit/public/platform,
    and Source/platform/exported, that is, all Web*Credential* types.
 -- MockCredentialManagerClient in content/shell/test_runner.

Public-key credential related functionality from WebAuthenticationClient
was also merged into CredentialsContainer, and the former class removed.

TBR=melandory@chromium.org

Bug:  740081 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9d854ceea23a0eace69ad644339ad0cd6edf0938
Reviewed-on: https://chromium-review.googlesource.com/779819
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525709}
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/BUILD.gn
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/chrome/renderer/BUILD.gn
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/components/BUILD.gn
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/components/password_manager/content/browser/content_credential_manager.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/components/password_manager/content/browser/content_credential_manager.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/components/password_manager/content/common/credential_manager_struct_traits.cc
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/components/password_manager/content/renderer/BUILD.gn
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/components/password_manager/content/renderer/DEPS
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/components/password_manager/content/renderer/credential_manager_client.cc
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/components/password_manager/content/renderer/credential_manager_client.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/components/password_manager/core/browser/credential_manager_impl.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/components/password_manager/core/browser/credential_manager_impl_unittest.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/components/password_manager/core/common/credential_manager_types.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/content/shell/test_runner/BUILD.gn
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/content/shell/test_runner/mock_credential_manager_client.cc
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/content/shell/test_runner/mock_credential_manager_client.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/content/shell/test_runner/web_test_runner.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/ios/chrome/browser/passwords/credential_manager.mm
[add] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/external/wpt/credential-management/federatedcredential-framed-get.sub.https-expected.txt
[add] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/external/wpt/credential-management/passwordcredential-framed-get.sub.https-expected.txt
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-errors.html
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-preventsilentaccess-basics.html
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-store-basics.html
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/http/tests/credentialmanager/mock-authenticator.html
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/authenticator-helpers.js
[add] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/credential-helpers.js
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/iframed-credentialscontainer.html
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/core/CoreInitializer.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/BUILD.gn
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/Credential.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/Credential.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.cpp
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.h
[add] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerProxy.cpp
[add] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerProxy.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/DEPS
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/OWNERS
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.cpp
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/credentialmanager/PlatformCredential.cpp
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/credentialmanager/PlatformCredential.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/credentialmanager/PlatformFederatedCredential.cpp
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/credentialmanager/PlatformFederatedCredential.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/credentialmanager/PlatformPasswordCredential.cpp
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/credentialmanager/PlatformPasswordCredential.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/exported/WebCredential.cpp
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/exported/WebFederatedCredential.cpp
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/Source/platform/exported/WebPasswordCredential.cpp
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/public/platform/WebCredential.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/public/platform/WebCredentialManagerClient.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/public/platform/WebCredentialManagerError.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/public/platform/WebCredentialMediationRequirement.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/public/platform/WebFederatedCredential.h
[delete] https://crrev.com/5268d89cba8e0fe0c839255987165b76918d6893/third_party/WebKit/public/platform/WebPasswordCredential.h
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom
[modify] https://crrev.com/593cc44ba056aa6b278a73af08bc8bf814351512/third_party/WebKit/public/web/WebView.h

Comment 14 by engedy@chromium.org, Dec 21 2017

Labels: -M-61 M-65
Status: Fixed (was: Started)
►

Sign in to add a comment