A place to collect all documenting CLs in Blink Doc-a-thon. Event details: https://docs.google.com/document/d/1FbEPu1AR6bDYwjNSR4M6XDEEDLllM2cv7c6o2L_IVOg/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/166462def7034e69cdcda6cd4be472d79c970930 commit 166462def7034e69cdcda6cd4be472d79c970930 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Jul 14 01:09:22 2017 Add class comments for ResourceRequest and ResourceResponse Bug: 740070 Change-Id: I62e54dd3bad45348369007466e4a2dc777aebbba NoTry: true Reviewed-on: https://chromium-review.googlesource.com/569938 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486578} [modify] https://crrev.com/166462def7034e69cdcda6cd4be472d79c970930/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h [modify] https://crrev.com/166462def7034e69cdcda6cd4be472d79c970930/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b25fddc97fd2840cbe0d248fc0b05eda3ba0594 commit 1b25fddc97fd2840cbe0d248fc0b05eda3ba0594 Author: Charles Harrison <csharrison@chromium.org> Date: Fri Jul 14 19:13:06 2017 Add class comments for KURL Bug: 740070 Change-Id: I856930d7e54ef62d4fed8a9c669eaf3237aae8a3 Reviewed-on: https://chromium-review.googlesource.com/571941 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#486831} [modify] https://crrev.com/1b25fddc97fd2840cbe0d248fc0b05eda3ba0594/third_party/WebKit/Source/platform/weborigin/KURL.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e123a3d487295902110bd9f359c34451d48e2b3b commit e123a3d487295902110bd9f359c34451d48e2b3b Author: Steve Kobes <skobes@chromium.org> Date: Thu Jul 20 01:20:30 2017 Add documentation on bisecting layout test regressions. Bug: 740070 Change-Id: I26fa14774e0bc697346033af805dd8bf68e14d0c Reviewed-on: https://chromium-review.googlesource.com/578730 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#488078} [modify] https://crrev.com/e123a3d487295902110bd9f359c34451d48e2b3b/docs/testing/layout_tests.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42d2353c55521340b8aff55cca1e9646617abd03 commit 42d2353c55521340b8aff55cca1e9646617abd03 Author: Vincent Scheib <scheib@chromium.org> Date: Thu Jul 20 23:37:36 2017 USB/WebUSB documentation, adding README.md files in several locations. Bug: 740070 Change-Id: I9d0a7371c22856a641ad88910d55ba844aca4191 Reviewed-on: https://chromium-review.googlesource.com/572332 Commit-Queue: Vincent Scheib <scheib@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488481} [add] https://crrev.com/42d2353c55521340b8aff55cca1e9646617abd03/device/usb/README.md [modify] https://crrev.com/42d2353c55521340b8aff55cca1e9646617abd03/device/usb/mojo/device_manager_impl.h [modify] https://crrev.com/42d2353c55521340b8aff55cca1e9646617abd03/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/README.md [add] https://crrev.com/42d2353c55521340b8aff55cca1e9646617abd03/third_party/WebKit/LayoutTests/external/wpt/webusb/README.md [add] https://crrev.com/42d2353c55521340b8aff55cca1e9646617abd03/third_party/WebKit/Source/modules/webusb/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04998e8a0b7b7c8d0a5909f2a3118eb4ade1fd60 commit 04998e8a0b7b7c8d0a5909f2a3118eb4ade1fd60 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Fri Jul 21 05:50:08 2017 Add WebKit/common directory No BUILD.gn for now as it doesn't have actual files yet, but I plan to add that in the next patch. Bug: 740070 Change-Id: I6e45e864f84a27561718a144fe51bd902482ae59 Reviewed-on: https://chromium-review.googlesource.com/566794 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#488596} [modify] https://crrev.com/04998e8a0b7b7c8d0a5909f2a3118eb4ade1fd60/content/browser/DEPS [modify] https://crrev.com/04998e8a0b7b7c8d0a5909f2a3118eb4ade1fd60/third_party/WebKit/Source/DEPS [add] https://crrev.com/04998e8a0b7b7c8d0a5909f2a3118eb4ade1fd60/third_party/WebKit/common/DEPS [add] https://crrev.com/04998e8a0b7b7c8d0a5909f2a3118eb4ade1fd60/third_party/WebKit/common/OWNERS [add] https://crrev.com/04998e8a0b7b7c8d0a5909f2a3118eb4ade1fd60/third_party/WebKit/common/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0d66e725ff141666387ec7dff745c0249ed3f88 commit f0d66e725ff141666387ec7dff745c0249ed3f88 Author: Steve Kobes <skobes@chromium.org> Date: Fri Jul 21 15:43:45 2017 Add class-level comments on PaintLayerCompositor and ScrollingCoordinator. Bug: 740070 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9c3208a36dd577634c7f74f5ccf63466c8b67f44 Reviewed-on: https://chromium-review.googlesource.com/578653 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#488665} [modify] https://crrev.com/f0d66e725ff141666387ec7dff745c0249ed3f88/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h [modify] https://crrev.com/f0d66e725ff141666387ec7dff745c0249ed3f88/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75c4065ab3b4a7f3dc21c3d45e676f91fdc236e3 commit 75c4065ab3b4a7f3dc21c3d45e676f91fdc236e3 Author: Steve Kobes <skobes@chromium.org> Date: Sat Jul 22 01:46:50 2017 Add documentation to scroll animator classes. Bug: 740070 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3b4b73df9598d474af0e6f36494b06c54bbdde2a Reviewed-on: https://chromium-review.googlesource.com/578658 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by: Walter Korman <wkorman@chromium.org> Reviewed-by: Alexandre Elias <aelias@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#488838} [modify] https://crrev.com/75c4065ab3b4a7f3dc21c3d45e676f91fdc236e3/cc/animation/scroll_offset_animation_curve.h [modify] https://crrev.com/75c4065ab3b4a7f3dc21c3d45e676f91fdc236e3/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h [modify] https://crrev.com/75c4065ab3b4a7f3dc21c3d45e676f91fdc236e3/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h [modify] https://crrev.com/75c4065ab3b4a7f3dc21c3d45e676f91fdc236e3/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h [modify] https://crrev.com/75c4065ab3b4a7f3dc21c3d45e676f91fdc236e3/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h [modify] https://crrev.com/75c4065ab3b4a7f3dc21c3d45e676f91fdc236e3/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2deef7c19263d4db7d713a1d351f9c2db45f053 commit a2deef7c19263d4db7d713a1d351f9c2db45f053 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Jul 24 11:03:56 2017 Documentation/cleanup: WebServiceWorkerContextClient This class's documentation accumulated cruft for historical reasons. Make it make more sense. Also make the order of functions consistent with the subclass. Bug: 740070 Change-Id: Ic744c85a7a26cc2de10c18a049f073a0f3240373 Reviewed-on: https://chromium-review.googlesource.com/582372 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#488941} [modify] https://crrev.com/a2deef7c19263d4db7d713a1d351f9c2db45f053/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/a2deef7c19263d4db7d713a1d351f9c2db45f053/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd5eba7406551b20ce42ab74db39f983f2072515 commit bd5eba7406551b20ce42ab74db39f983f2072515 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Jul 28 16:08:06 2017 ES6 Modules: Add class-level comments for ModuleScriptFetcher This is a follow-up CL for https://chromium-review.googlesource.com/c/583968/ Bug: 726576 , 740070 Change-Id: I65b4d74e46f52f642b6f499878f2b075a6debddf Reviewed-on: https://chromium-review.googlesource.com/591587 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#490416} [modify] https://crrev.com/bd5eba7406551b20ce42ab74db39f983f2072515/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetcher.h [modify] https://crrev.com/bd5eba7406551b20ce42ab74db39f983f2072515/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp [modify] https://crrev.com/bd5eba7406551b20ce42ab74db39f983f2072515/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.h [modify] https://crrev.com/bd5eba7406551b20ce42ab74db39f983f2072515/third_party/WebKit/Source/core/loader/modulescript/WorkletModuleScriptFetcher.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aa5241921a9d62e05f6d8ece7cde2237d919841 commit 0aa5241921a9d62e05f6d8ece7cde2237d919841 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Jul 31 07:56:15 2017 Documentation: README.md for http/tests/serviceworker Bug: 740070 Change-Id: Ia51ecfea7c4b78d3328ca102ac8ece824ac1f1e7 Reviewed-on: https://chromium-review.googlesource.com/593381 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#490726} [add] https://crrev.com/0aa5241921a9d62e05f6d8ece7cde2237d919841/third_party/WebKit/LayoutTests/http/tests/serviceworker/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/979aeb4b47044335a43dbe2d570220cd07589747 commit 979aeb4b47044335a43dbe2d570220cd07589747 Author: smcgruer <smcgruer@chromium.org> Date: Tue Aug 01 15:15:22 2017 Refactor StickyPositionScrollingConstraints API and add documentation Main changes: 1. Removed unused method |NearestStickyAncestor|. 2. Removed |GetTotalStickyBoxStickyOffset| and |GetTotalContainingBlockStickyOffset|, which were only accessed in the class implementation so can be accessed directly. 3. Switched ancestor pointers to PaintLayer rather than LayoutBoxModelObject as we always just call ->Layer() on them. 4. Passed the StickyConstraintsMap into |ComputeStickyOffset| and find the ancestors internally, the same way as |GetOffsetForStickyPosition|. BUG= 730043 ,740070 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2961613002 Cr-Commit-Position: refs/heads/master@{#490996} [modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp [modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp [modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp [modify] https://crrev.com/979aeb4b47044335a43dbe2d570220cd07589747/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/472df758deea89c7c5e55141dc5d6cf8b038ce28 commit 472df758deea89c7c5e55141dc5d6cf8b038ce28 Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Aug 02 05:30:14 2017 Documentation: For service worker "providers" Bug: 740070 Change-Id: Ida0ce2080e724784cfb775d30004805cc70812f4 Reviewed-on: https://chromium-review.googlesource.com/595301 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#491275} [modify] https://crrev.com/472df758deea89c7c5e55141dc5d6cf8b038ce28/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h [modify] https://crrev.com/472df758deea89c7c5e55141dc5d6cf8b038ce28/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6329a550f123d194fe36e9b7cb69312ac2e47f72 commit 6329a550f123d194fe36e9b7cb69312ac2e47f72 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Wed Aug 02 10:39:28 2017 Clean up and document ServiceWorkerNetworkProvider's ctors Make ServiceWorkerNetworkProvider's ctors private, adds specific creation methods like: - CreateForSharedWorker - CreateForController Bug: 740070 Change-Id: Ib17d50f2bf49b3895569551f805892b4c3706d38 Reviewed-on: https://chromium-review.googlesource.com/597553 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491332} [modify] https://crrev.com/6329a550f123d194fe36e9b7cb69312ac2e47f72/content/child/service_worker/service_worker_network_provider.cc [modify] https://crrev.com/6329a550f123d194fe36e9b7cb69312ac2e47f72/content/child/service_worker/service_worker_network_provider.h [modify] https://crrev.com/6329a550f123d194fe36e9b7cb69312ac2e47f72/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/6329a550f123d194fe36e9b7cb69312ac2e47f72/content/renderer/shared_worker/embedded_shared_worker_stub.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/977b8fbde88d76a25e72b2c25734fa59cbb43e3a commit 977b8fbde88d76a25e72b2c25734fa59cbb43e3a Author: Stephen McGruer <smcgruer@chromium.org> Date: Thu Aug 03 17:50:08 2017 Add README.md for cc/animation Initial version of the README.md covers how cc/animation itself works (with some TODOs for trickier details), and dips briefly into the clients of cc/animation. Future CLs will expand on the details of how clients interact with cc/animation. Bug: 740070 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib89a29a77630e46abcd1bd0f90e4158e9ffc0f23 Reviewed-on: https://chromium-review.googlesource.com/579587 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Walter Korman <wkorman@chromium.org> Reviewed-by: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#491783} [add] https://crrev.com/977b8fbde88d76a25e72b2c25734fa59cbb43e3a/cc/animation/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d930f749211effc224347ac7314db30cc809ebf commit 3d930f749211effc224347ac7314db30cc809ebf Author: Kinuko Yasuda <kinuko@chromium.org> Date: Fri Aug 04 05:46:24 2017 Add bit more documentation in WebKit/common/README.md Bug: 740070 Change-Id: I1b0983d8f4e0c49466edf176bc4a1c7f73105539 Reviewed-on: https://chromium-review.googlesource.com/599252 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#491948} [modify] https://crrev.com/3d930f749211effc224347ac7314db30cc809ebf/third_party/WebKit/common/README.md
Not adding comments, but fixing *lots* of out-of-date ones: https://bugs.chromium.org/p/chromium/issues/detail?id=643310#c8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e224f23759c293f06d5f59a2606335e8a15b05ad commit e224f23759c293f06d5f59a2606335e8a15b05ad Author: Raymond Toy <rtoy@chromium.org> Date: Wed Aug 09 17:33:28 2017 Document VectorMath routines Add some simple descriptions to what the VectorMath routines actually do so you don't have to look at the implementation code. Bug: 740070 Test: none Change-Id: I5bd32ea4397563f390602d64bf65fbb162ec298c Reviewed-on: https://chromium-review.googlesource.com/607239 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#493041} [modify] https://crrev.com/e224f23759c293f06d5f59a2606335e8a15b05ad/third_party/WebKit/Source/platform/audio/VectorMath.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb11b7ee42a9b2fd4177f484167b22615c77bb48 commit fb11b7ee42a9b2fd4177f484167b22615c77bb48 Author: Aleks Totic <atotic@chromium.org> Date: Wed Aug 09 22:57:16 2017 Document ResizeObserver Bug: 740070 Change-Id: If69a254178d3717eb293bac658d3962242164c18 Reviewed-on: https://chromium-review.googlesource.com/607468 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#493167} [add] https://crrev.com/fb11b7ee42a9b2fd4177f484167b22615c77bb48/third_party/WebKit/Source/core/resize_observer/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b5cb79009f79d50f86434283fcac247ef832838 commit 1b5cb79009f79d50f86434283fcac247ef832838 Author: Walter Korman <wkorman@chromium.org> Date: Mon Aug 28 17:49:31 2017 Add helpful reference documents to cc animation README. Bug: 740070 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I874f334e96c91c182235f95aa1a640e51dd473ab Reviewed-on: https://chromium-review.googlesource.com/638651 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#497794} [modify] https://crrev.com/1b5cb79009f79d50f86434283fcac247ef832838/cc/animation/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cc27b749533c092226bd00693ad8ff3ae57c0e3 commit 8cc27b749533c092226bd00693ad8ff3ae57c0e3 Author: Majid Valipour <majidvp@chromium.org> Date: Mon Oct 02 14:51:19 2017 Add top-level README for Animation Worklet and class comments Bug: 740070 Change-Id: Idabdc4350f849d38c9a9f4b8fbdf94dcdc21f44a Reviewed-on: https://chromium-review.googlesource.com/579653 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505610} [modify] https://crrev.com/8cc27b749533c092226bd00693ad8ff3ae57c0e3/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h [modify] https://crrev.com/8cc27b749533c092226bd00693ad8ff3ae57c0e3/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.h [modify] https://crrev.com/8cc27b749533c092226bd00693ad8ff3ae57c0e3/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.h [modify] https://crrev.com/8cc27b749533c092226bd00693ad8ff3ae57c0e3/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.h [modify] https://crrev.com/8cc27b749533c092226bd00693ad8ff3ae57c0e3/third_party/WebKit/Source/modules/compositorworker/Animator.h [modify] https://crrev.com/8cc27b749533c092226bd00693ad8ff3ae57c0e3/third_party/WebKit/Source/modules/compositorworker/AnimatorDefinition.h [add] https://crrev.com/8cc27b749533c092226bd00693ad8ff3ae57c0e3/third_party/WebKit/Source/modules/compositorworker/README.md
Comment 1 by bugdroid1@chromium.org
, Jul 14 2017