Add a way to read externalfile: URLs from the ARC container |
||||||||||||||||||||||
Issue descriptionCurrently, ARC container cannot access the contents of files stored in MTP devices/Google Drive/File System Providers. To make file operation more smooth, we should make it possible to access these files from ARC container.
,
Jul 10 2017
Setting the target milestone. Thank you hashimoto@ san for considering this feature for M61!
,
Jul 10 2017
,
Jul 11 2017
,
Jul 26 2017
Weifang, do we need to go through the proper feature launch process, or are we good to go? A design doc (not public) is ready. https://docs.google.com/a/google.com/document/d/1srcxIq6GxspuLyKmRTsAWdm34i4TNwdVFGjWGeLdusE/edit?usp=sharing
,
Jul 26 2017
Thanks for the update hashimoto@! I don't think we need an official launch bug for this, but I will ping the security team for a quick review as this update crosses the ARC container.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/c6082c40953372b396f57a558621e8ee8ea7a6d5 commit c6082c40953372b396f57a558621e8ee8ea7a6d5 Author: Ryo Hashimoto <hashimoto@google.com> Date: Fri Jul 28 10:26:43 2017 Add virtual-file-provider user for the virtual file provider service BUG= chromium:740063 TEST=None Change-Id: I485004674700260b16295502ddab03b119f957ad Reviewed-on: https://chromium-review.googlesource.com/589307 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [add] https://crrev.com/c6082c40953372b396f57a558621e8ee8ea7a6d5/profiles/base/accounts/group/virtual-file-provider [add] https://crrev.com/c6082c40953372b396f57a558621e8ee8ea7a6d5/profiles/base/accounts/user/virtual-file-provider
,
Aug 3 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50 commit f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50 Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Aug 10 10:27:20 2017 virtual_file_provider: Add virtual-file-provider Chrome will call OpenFile D-Bus method, and this service returns a FUSE-backed FD and an ID. The FUSE-backed FD will be passed to an Android app. When the app tries to read data from the FD, virtual-file-provider sends ReadRequest signal to Chrome to receive the data. org.chromium.VirtualFileProvider.conf: D-Bus policy file org.chromium.VirtualFileProvider.service: D-Bus autostart config virtual-file-provider-jailed.sh: Wrapper script to run w/ minijail BUG= chromium:740063 TEST=emerge-caroline virtual-file-provider Change-Id: Ib7a0a4191a569620b58c275ed2dd386aa7177cbe Reviewed-on: https://chromium-review.googlesource.com/601696 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/service.cc [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/util.h [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/util.cc [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/org.chromium.VirtualFileProvider.conf [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/virtual_file_provider.gyp [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/virtual_file_provider.cc [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/org.chromium.VirtualFileProvider.service [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/fuse_main.h [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/README.md [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/fuse_main.cc [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/virtual-file-provider-jailed.sh [add] https://crrev.com/f8936a41bb1dfc5ed17f5cb6e9041a9b09b59d50/virtual_file_provider/service.h
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8fb65c8f76f7571b88aed2b9368c91e02661a20d commit 8fb65c8f76f7571b88aed2b9368c91e02661a20d Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Aug 10 10:27:21 2017 Add virtual-file-provider virtual-file-provider will run with minijail as virtual-file-provider user/group. BUG= chromium:740063 TEST=emerge-caroline virtual-file-provider CQ-DEPEND=CL:601696 Change-Id: I9d251db241bc6349a2715d9d6b43154c06d7a109 Reviewed-on: https://chromium-review.googlesource.com/603247 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/8fb65c8f76f7571b88aed2b9368c91e02661a20d/chromeos-base/virtual-file-provider/virtual-file-provider-9999.ebuild
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f6bb2f8f166d3ca3168b5dcc55ebd0dd38fb735 commit 8f6bb2f8f166d3ca3168b5dcc55ebd0dd38fb735 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Mon Aug 14 04:52:44 2017 arc: Add FileStreamForwarder This class will be used by ArcFileSystemBridge to forward data from file systems to VirtualFileProvider. BUG= 740063 TEST=unit_tests Change-Id: I26099a593701424bf7499197f4420f0176715832 Reviewed-on: https://chromium-review.googlesource.com/607839 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#494011} [modify] https://crrev.com/8f6bb2f8f166d3ca3168b5dcc55ebd0dd38fb735/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/8f6bb2f8f166d3ca3168b5dcc55ebd0dd38fb735/chrome/browser/chromeos/arc/fileapi/file_stream_forwarder.cc [add] https://crrev.com/8f6bb2f8f166d3ca3168b5dcc55ebd0dd38fb735/chrome/browser/chromeos/arc/fileapi/file_stream_forwarder.h [add] https://crrev.com/8f6bb2f8f166d3ca3168b5dcc55ebd0dd38fb735/chrome/browser/chromeos/arc/fileapi/file_stream_forwarder_unittest.cc
,
Aug 18 2017
+Test team explicitly - This feature is part of the Open/Share intents workflow, but since it involves ARC++ interaction, wanted to call it out specifically. Please let me know if any questions!
,
Aug 18 2017
How will this look when implemented? Android apps will see multiple folders in its File picker: Downloads / Google Drive / MTP device? Is there a mock?
,
Aug 22 2017
The only visible UI change is in Files app's "OPEN" menu on the top bar (shown when selecting a file) or the right click menu. When this feature becomes ready, "Open with" options for Android apps will be shown for files not only in Downloads, but also in Google Drive.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e1056461d180f400432dea15d9dce308e3d5740 commit 4e1056461d180f400432dea15d9dce308e3d5740 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Tue Aug 22 08:33:01 2017 arc: Add chrome_content_provider_url_util EncodeToChromeContentProviderUrl() converts a URL to a chrome content provider URL. DecodeChromeContentProviderUrl() converts a chrome content provider URL to the original URL. BUG= 740063 TEST=unit_tests Change-Id: I10981b3ff576ee6f8227f24e2672eb81be9874cd Reviewed-on: https://chromium-review.googlesource.com/612932 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#496252} [modify] https://crrev.com/4e1056461d180f400432dea15d9dce308e3d5740/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/4e1056461d180f400432dea15d9dce308e3d5740/chrome/browser/chromeos/arc/fileapi/chrome_content_provider_url_util.cc [add] https://crrev.com/4e1056461d180f400432dea15d9dce308e3d5740/chrome/browser/chromeos/arc/fileapi/chrome_content_provider_url_util.h [add] https://crrev.com/4e1056461d180f400432dea15d9dce308e3d5740/chrome/browser/chromeos/arc/fileapi/chrome_content_provider_url_util_unittest.cc
,
Aug 22 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/project-cheets-private/+/b634ae293652bce46b1f2c338b5abbb24dfb1039 commit b634ae293652bce46b1f2c338b5abbb24dfb1039 Author: Ryo Hashimoto <hashimoto@google.com> Date: Tue Aug 22 12:08:50 2017
,
Aug 24 2017
Updating target to M63 given current timelines and remaining work needed to support this. Test team FYI on the impact: - For M61, Open/Share intents should work as spec'd with the exception of virtual files which will behave as they do today.
,
Aug 29 2017
,
Sep 6 2017
,
Sep 6 2017
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/ddce50ea03b098299236da94748cc1476aaaf4d6 commit ddce50ea03b098299236da94748cc1476aaaf4d6 Author: Ryo Hashimoto <hashimoto@google.com> Date: Fri Sep 08 19:51:04 2017 Add D-Bus constants for VirtualFileProvider Add D-Bus constants for VirtualFileProvider service and VirtualFileRequestHandlerService (which is implemented as part of chrome). BUG= chromium:740063 TEST=emerge-caroline system_api Change-Id: Ic52205e37cae13d1cc7aaae4b35a634382fb6f66 Reviewed-on: https://chromium-review.googlesource.com/650227 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/ddce50ea03b098299236da94748cc1476aaaf4d6/dbus/service_constants.h
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f1fc96580cc29f505ca1898f57db973466177577 commit f1fc96580cc29f505ca1898f57db973466177577 Author: Ryo Hashimoto <hashimoto@google.com> Date: Fri Sep 08 22:05:12 2017 virtual_file_provider: Use method call instead of signal VirtualFileRequestHandlerService is implemented as part of chrome. Call a method of this service instead of sending signals. BUG= chromium:740063 TEST=emerge-caroline virtual_file_provider CQ-DEPEND=CL:650227 Change-Id: Ib00cec674e97a4e4a6ad16f26f4bdfa3aea42991 Reviewed-on: https://chromium-review.googlesource.com/650228 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/f1fc96580cc29f505ca1898f57db973466177577/virtual_file_provider/service.cc [modify] https://crrev.com/f1fc96580cc29f505ca1898f57db973466177577/virtual_file_provider/service.h
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37a02a0bc38dd46015a835e396d65ab4666d06cd commit 37a02a0bc38dd46015a835e396d65ab4666d06cd Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Mon Sep 11 09:37:51 2017 Roll src/third_party/cros_system_api/ 5b991d25a..f76589aaa (2 commits) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5b991d25aa29..f76589aaa750 $ git log 5b991d25a..f76589aaa --date=short --no-merges --format='%ad %ae %s' 2017-09-08 benchan shill: remove kAddIPConfigFunction constant 2017-09-05 hashimoto Add D-Bus constants for VirtualFileProvider Created with: roll-dep src/third_party/cros_system_api Bug: 740063 Change-Id: I6ba0732fe2efdeabfe118b3ab52102c1e1ccd19d Reviewed-on: https://chromium-review.googlesource.com/658006 Reviewed-by: Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#500873} [modify] https://crrev.com/37a02a0bc38dd46015a835e396d65ab4666d06cd/DEPS
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44c140b97bc2d83f630365417fee42d34d185c79 commit 44c140b97bc2d83f630365417fee42d34d185c79 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Wed Sep 13 05:10:08 2017 chromeos: Add VirtualFileProvider D-Bus client BUG= 740063 TEST=build Change-Id: Idbb52590a586dbc55bba52979eec8a2790d8ac60 Reviewed-on: https://chromium-review.googlesource.com/593427 Reviewed-by: Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#501546} [modify] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/BUILD.gn [modify] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/dbus/dbus_clients_browser.cc [modify] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/dbus/dbus_clients_browser.h [modify] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/dbus/dbus_thread_manager.cc [modify] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/dbus/dbus_thread_manager.h [add] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/dbus/fake_virtual_file_provider_client.cc [add] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/dbus/fake_virtual_file_provider_client.h [add] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/dbus/virtual_file_provider_client.cc [add] https://crrev.com/44c140b97bc2d83f630365417fee42d34d185c79/chromeos/dbus/virtual_file_provider_client.h
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/28a35a5fa39e4204c4979bc8a7048a14d9cc99a4 commit 28a35a5fa39e4204c4979bc8a7048a14d9cc99a4 Author: Ryo Hashimoto <hashimoto@google.com> Date: Wed Sep 13 08:51:04 2017 virtual_file_provider: Fix the interface name in the conf file "Interface" suffix was removed in CL:650227 BUG= chromium:740063 TEST=emerge Change-Id: I52d634a6ac6ee4f341e225e33a5b77dab061545a Reviewed-on: https://chromium-review.googlesource.com/662978 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/28a35a5fa39e4204c4979bc8a7048a14d9cc99a4/virtual_file_provider/org.chromium.VirtualFileProvider.conf
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ff1170193fb676372089bbe321287e1db5a1d51 commit 6ff1170193fb676372089bbe321287e1db5a1d51 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Wed Sep 20 06:55:03 2017 chromeos: Add VirtualFileRequestServiceProvider This service will be used by the VirtualFileProvider service to read data. ChromeVirtualFileRequestServiceProviderDelegate will have the actual implementation to handle incoming method calls. BUG= 740063 Change-Id: I607c726a5280687643a217a94ef90c188787c87f Reviewed-on: https://chromium-review.googlesource.com/662088 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#503075} [modify] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [add] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/chrome/browser/chromeos/dbus/chrome_virtual_file_request_service_provider_delegate.cc [add] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/chrome/browser/chromeos/dbus/chrome_virtual_file_request_service_provider_delegate.h [modify] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/chromeos/BUILD.gn [add] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/chromeos/dbus/services/org.chromium.VirtualFileRequestService.conf [add] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/chromeos/dbus/services/virtual_file_request_service_provider.cc [add] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/chromeos/dbus/services/virtual_file_request_service_provider.h
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/31a7e1cb8839bbeb7997bc0277bcfefbb3ae8989 commit 31a7e1cb8839bbeb7997bc0277bcfefbb3ae8989 Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Sep 21 12:41:57 2017 Add HandleIdReleased method for VirtualFileRequestService BUG= chromium:740063 TEST=emerge Change-Id: I2a5d2373f4bae9fba0cee6374be30e664c00727d Reviewed-on: https://chromium-review.googlesource.com/674491 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [modify] https://crrev.com/31a7e1cb8839bbeb7997bc0277bcfefbb3ae8989/dbus/service_constants.h
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/bcdabfcc4d2be180014996546d2a30fd15418096 commit bcdabfcc4d2be180014996546d2a30fd15418096 Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Sep 21 12:41:57 2017 virtual_file_provider: Send ID released events Chrome handles the new event to release resources. BUG= chromium:740063 TEST=emerge CQ-DEPEND=CL:674491 Change-Id: Id4bd7ae73d1805c15ab62a1d9745194137c9a11b Reviewed-on: https://chromium-review.googlesource.com/674492 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [modify] https://crrev.com/bcdabfcc4d2be180014996546d2a30fd15418096/virtual_file_provider/virtual_file_provider.cc [modify] https://crrev.com/bcdabfcc4d2be180014996546d2a30fd15418096/virtual_file_provider/service.cc [modify] https://crrev.com/bcdabfcc4d2be180014996546d2a30fd15418096/virtual_file_provider/fuse_main.cc [modify] https://crrev.com/bcdabfcc4d2be180014996546d2a30fd15418096/virtual_file_provider/fuse_main.h [modify] https://crrev.com/bcdabfcc4d2be180014996546d2a30fd15418096/virtual_file_provider/service.h
,
Sep 22 2017
Issue 767982 has been merged into this issue.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8 commit 153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8 Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Sep 28 04:13:00 2017 virtual_file_provider: Add SizeMap Chrome sends the file size when opening a new FD. This is needed to support seek. When seek is called to an FD, FUSE performs boundary check with the size value returned by getattr. BUG= chromium:740063 TEST=emerge-caroline virtual-file-provider Change-Id: Ic3a1780c7d0d0414e9bfa72493087039f5fc011e Reviewed-on: https://chromium-review.googlesource.com/612963 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [modify] https://crrev.com/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8/virtual_file_provider/service.cc [modify] https://crrev.com/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8/virtual_file_provider/virtual_file_provider.gyp [modify] https://crrev.com/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8/virtual_file_provider/virtual_file_provider.cc [add] https://crrev.com/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8/virtual_file_provider/size_map.cc [add] https://crrev.com/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8/virtual_file_provider/size_map.h [modify] https://crrev.com/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8/virtual_file_provider/fuse_main.h [modify] https://crrev.com/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8/virtual_file_provider/fuse_main.cc [modify] https://crrev.com/153d2ffed2c3312173a06c1f4c45a6b8f2d35ca8/virtual_file_provider/service.h
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a43376ea34468828b1b4f870e7a609fc41dedf64 commit a43376ea34468828b1b4f870e7a609fc41dedf64 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Mon Oct 02 11:18:45 2017 Roll src/third_party/cros_system_api/ 8dbf53880..72120182b (3 commits) https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/8dbf538802c8..72120182b44d $ git log 8dbf53880..72120182b --date=short --no-merges --format='%ad %ae %s' 2017-09-25 kitching hammerd: add dbus constant for invalid device 2017-09-22 ejcaruso dbus-constants: remove old MAC address randomization constant 2017-09-20 hashimoto Add HandleIdReleased method for VirtualFileRequestService Created with: roll-dep src/third_party/cros_system_api Bug: 740063 Change-Id: Ic14997ccfa996e4a74fd38cd875553ee20742b79 Reviewed-on: https://chromium-review.googlesource.com/694804 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#505579} [modify] https://crrev.com/a43376ea34468828b1b4f870e7a609fc41dedf64/DEPS
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c018451c572f41e4f4bb58f2cc2b74b1895724b commit 6c018451c572f41e4f4bb58f2cc2b74b1895724b Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Tue Oct 03 03:45:49 2017 arc: Add file reading methods to FileSystemHost - Add methods to file_system.mojom - Implement new methods in ArcFileSystemBridge - Implement ArcFileSystemBridge::HandleReadRequest() ArcFileSystemBridge::OpenFileToRead() returns an FD which belongs to the VirtualFileProvider service. When an app tries to read data from the FD, the VirtualFileProvider forwards the read request to Chrome via D-Bus, and it results in calling ArcFileSystemBridge::HandleReadRequest(). BUG= 740063 TEST=unit_tests Change-Id: I3abaee5327e458f9f1df89409d81ac7271c96532 Reviewed-on: https://chromium-review.googlesource.com/663803 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#505940} [modify] https://crrev.com/6c018451c572f41e4f4bb58f2cc2b74b1895724b/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/6c018451c572f41e4f4bb58f2cc2b74b1895724b/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.cc [modify] https://crrev.com/6c018451c572f41e4f4bb58f2cc2b74b1895724b/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.h [add] https://crrev.com/6c018451c572f41e4f4bb58f2cc2b74b1895724b/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge_unittest.cc [modify] https://crrev.com/6c018451c572f41e4f4bb58f2cc2b74b1895724b/chrome/browser/chromeos/dbus/chrome_virtual_file_request_service_provider_delegate.cc [modify] https://crrev.com/6c018451c572f41e4f4bb58f2cc2b74b1895724b/chromeos/dbus/fake_virtual_file_provider_client.cc [modify] https://crrev.com/6c018451c572f41e4f4bb58f2cc2b74b1895724b/chromeos/dbus/fake_virtual_file_provider_client.h [modify] https://crrev.com/6c018451c572f41e4f4bb58f2cc2b74b1895724b/components/arc/common/file_system.mojom
,
Oct 5 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8256ce4fc88493910bdebe8462026f3115d9b5df commit 8256ce4fc88493910bdebe8462026f3115d9b5df Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Wed Oct 11 09:52:02 2017 arc: Handle IDs released by VirtualFileProvider BUG= 740063 TEST=unit_tests Change-Id: I5c924c84a3d5a25aa4f9da17de0dfe79c8d9b48a Reviewed-on: https://chromium-review.googlesource.com/711677 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#507938} [modify] https://crrev.com/8256ce4fc88493910bdebe8462026f3115d9b5df/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.cc [modify] https://crrev.com/8256ce4fc88493910bdebe8462026f3115d9b5df/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge.h [modify] https://crrev.com/8256ce4fc88493910bdebe8462026f3115d9b5df/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge_unittest.cc [modify] https://crrev.com/8256ce4fc88493910bdebe8462026f3115d9b5df/chrome/browser/chromeos/dbus/chrome_virtual_file_request_service_provider_delegate.cc [modify] https://crrev.com/8256ce4fc88493910bdebe8462026f3115d9b5df/chrome/browser/chromeos/dbus/chrome_virtual_file_request_service_provider_delegate.h [modify] https://crrev.com/8256ce4fc88493910bdebe8462026f3115d9b5df/chromeos/dbus/services/virtual_file_request_service_provider.cc [modify] https://crrev.com/8256ce4fc88493910bdebe8462026f3115d9b5df/chromeos/dbus/services/virtual_file_request_service_provider.h
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05fbc1c3ea9a30433f7dcd3658b1134d64965dbf commit 05fbc1c3ea9a30433f7dcd3658b1134d64965dbf Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Wed Oct 25 13:40:43 2017 arc: Convert /special paths to ChromeContentProvider URLs BUG= 740063 TEST=unit_tests Change-Id: I2cc14da5f5f2d450c90c3bfa0019a2a9f20e2281 Reviewed-on: https://chromium-review.googlesource.com/715836 Reviewed-by: Daichi Hirono <hirono@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#511438} [modify] https://crrev.com/05fbc1c3ea9a30433f7dcd3658b1134d64965dbf/chrome/browser/chromeos/file_manager/path_util.cc [modify] https://crrev.com/05fbc1c3ea9a30433f7dcd3658b1134d64965dbf/chrome/browser/chromeos/file_manager/path_util_unittest.cc
,
Oct 26 2017
,
Feb 2 2018
Issue still existing on latest M65 dev build (Chrome OS: 10323.11.0, 65.0.3325.36). Drag and drop files from MTP/Google Drive/File System Providers/Recent folders to ARC++ apps doesn't work yet.
,
Feb 2 2018
+hirono@ and niwa@ who are familiar with the drag and drop feature. Sorry for not putting much information on this issue. This issue is about adding a way to open files with Android apps from the file manager UI. For missing features (e.g. the lack of drag and drop support), please file new bug. Thanks!
,
Feb 2 2018
Thank you for reporting! For drag and drop, we are going to track the issue at crbug.com/767982 .
,
Feb 6 2018
Issue 801858 has been merged into this issue.
,
Feb 20 2018
Issue 758682 has been merged into this issue.
,
Feb 23 2018
Assigning this issue back based on two observations: 1. MTP and FSP folders are not accessible from ARC++ app. Open an Android Gmail app> Compose an email and attach file option. MTP and FSP folders are not visible. 2. 'Open with' and 'Share menu' options' support not available for MTP/FSP/Media folders in Files app. Especially raw images, video file, doc files (docx, pptx, xlsx) of MTP/FSP/Media folders don't have open with and share menu options support. Tested on CrOS version: 10431.0.0, 66.0.3352.0 dev channel eve device.
,
Feb 24 2018
,
Feb 26 2018
,
Feb 26 2018
Please file new bugs for missing features as I described in comment #38. Thanks! > 1. MTP and FSP folders are not accessible from ARC++ app. Open an Android Gmail app> Compose an email and attach file option. MTP and FSP folders are not visible. Please file a separate bug for a new feature. > 2. 'Open with' and 'Share menu' options' support not available for MTP/FSP/Media folders in Files app. Especially raw images, video file, doc files (docx, pptx, xlsx) of MTP/FSP/Media folders don't have open with and share menu options support. It means that there is no application which can handle the said file types installed on the device.
,
Feb 26 2018
,
Feb 26 2018
Re #45, > 1. MTP and FSP folders are not accessible from ARC++ app. Open an Android Gmail app> Compose an email and attach file option. MTP and FSP folders are not visible. ------ Filed new feature request: Issue 816680 > 2. 'Open with' and 'Share menu' options' support not available for MTP/FSP/Media folders in Files app. Especially raw images, video file, doc files (docx, pptx, xlsx) of MTP/FSP/Media folders don't have open with and share menu options support. ------ Files new bug for this: Issue 816678
,
Feb 26 2018
Closing this bug as verified on CrOS version: 10431.0.0, 66.0.3352.0 dev-channel eve.
,
Feb 26 2018
|
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by kinaba@chromium.org
, Jul 10 2017