unit_tests failing on chromium.linux/Android Tests (dbg) |
||
Issue descriptionunit_tests failing on chromium.linux/Android Tests (dbg) Builders failed on: - Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Likely due to https://chromium-review.googlesource.com/562477
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b24fe8864b850e20ead1147d2f6eb41c1624515 commit 1b24fe8864b850e20ead1147d2f6eb41c1624515 Author: Vaclav Brozek <vabr@chromium.org> Date: Fri Jul 07 11:08:19 2017 Initialize PasswordFormManager in Android unittests All PasswordFormManager instances need to be initialized since https://chromium-review.googlesource.com/c/562477/, but android save password delegate somehow fell through the cracks. It only crashed on debug, and there are no debug trybots. This CL adds the Init() calls there. TBR=battre@chromium.org Bug: 725883 , 740061 Change-Id: I6e36e4604a3954e2beab5098ad6f7a03e8f262a5 Reviewed-on: https://chromium-review.googlesource.com/563377 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#484883} [modify] https://crrev.com/1b24fe8864b850e20ead1147d2f6eb41c1624515/chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc
,
Jul 7 2017
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/43826 is the build with the fix from above, so I'm watching closely.
,
Jul 7 2017
Woohoo, https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/43826 passed.
,
Jul 8 2017
Issue 740154 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by vabr@chromium.org
, Jul 7 2017Status: Started (was: Available)