New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 740056 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: 'Country/Region' text is aligned to left on changing chrome://flags to RTL.

Reported by aiman.an...@etouch.net, Jul 7 2017 
Chrome Version: 61.0.3150.0 (Official Build) (cohort: Stable)e32c608bfaee28eb9bd478073a2f222fb6c28133-refs/heads/master@{#484424} (32/64-bit).

OS: Windows (7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6).

Pre-Condition: Enable Force UI direction flag (Right-to-left) from chrome://flags.

Steps to reproduce: 
1.Launch Chrome, go to chrome://settings/autofill, Click on ADD button for Addresses.
2.On Add Addresses overlay scroll down and observe.

Actual Result: 'Country/Region' text is Left Aligned when RTL flag is enabled.
Expected Result: 'Country/Region' text should be Right Aligned.

This is Regression Issue broken in M-59 and will soon update the bisect info.

Manual Bisect Info:
Good Build: 59.0.3032.0
Bad Build: 59.0.3033.0
Actual Result.mp4
1.4 MB View Download
Expected Result.mp4
1.6 MB View Download
Actual_Result.png
19.1 KB View Download

Comment 1 by rbasuvula@chromium.org, Jul 7 2017

Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3032.0(Revision:454806).
Bad build:59.0.3033.0(Revision:455023).

You are probably looking for a change made after 454939 (known good), but no later than 454940 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/fcf82d6e5b20e104b5eaba8d802ee451092126d5..3ed5d998cc82797b116a949f75da144ec3465a6d

From the CL above, assigning the issue to the concern owner

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2726113003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3150.0

Comment 2 by scottchen@chromium.org, Aug 16 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a2b390a4b50ba8f10e68f60f700c4f58bf36dc9

commit 0a2b390a4b50ba8f10e68f60f700c4f58bf36dc9
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Aug 18 23:20:20 2017

MD Settings: in address edit dialog, fix rtl alignment for country label

Bug:  740056 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I574b948bab981bc3a5ec6b9e4714412a02572016
Reviewed-on: https://chromium-review.googlesource.com/618124
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495737}
[modify] https://crrev.com/0a2b390a4b50ba8f10e68f60f700c4f58bf36dc9/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

Comment 4 by aiman.an...@etouch.net, Aug 21 2017

Labels: TE-Verified-62.0.3192.0 TE-Verified-62
Note: Retested the above issue on latest canary #62.0.3192.0 on Windows (7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6).
Above issue is fixed and is working as intended.
Result.mov
5.1 MB Download

Comment 5 by scottchen@chromium.org, Aug 29 2017

Status: Fixed (was: Started)
►

Sign in to add a comment