Issue metadata
Sign in to add a comment
|
Regression : Tab Focus is seen Missing in Uber Tray when Files App is opened |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3150.0/9720.0.0 dev channel Kip,Daisy and Minnie OS: Chrome What steps will reproduce the problem? (1)Browse as Guest -> Open App Launcher and select 'Files App' (2)Open Files App -> Now click on Uber Tray -> Press 'Tab' button and observe Focus is not seen in Uber Tray (Please refer Video) Expected: On Pressing 'Tab' button blue Focus should be seen in Uber Tray Actual: Instead Focus is seen in Files App i.e. on 'Search','Sort options' etc This is Regression issue as same is working fine in 61.0.3136.5/9672.0.0 dev-channel Minnie @tbuckley : Please confirm the Issue
,
Jul 7 2017
This is not Web UI so this is not Blink issue.
,
Jul 19 2017
Issue is seen in Signed in User also i.e. on pressing 'Tab' button Focus is not seen in Uber Tray instead seen on 'Search','Sort options' etc in Files App. Attaching Video for reference
,
Jul 27 2017
@tdanderson do you know what might have changed this? I can repro on 62.0.3166.0 canary
,
Jul 27 2017
I think oshima@ recently(?) changed behavior of when tray bubbles capture focus, so that could be to blame. Handing over to oshima@ to verify.
,
Jul 27 2017
Works fine on 60 (60.0.3112.26), so must be recent regression. Could be crrev.com/2958693002. yawano-san, can you take a look? The problem seems to happen only with chrome apps, but not browser nor ARC++ apps.
,
Aug 31 2017
yawano@ any updates on this stable blocker? This issue hasn't been updated since July 27th. Please update with latest status and close if no longer repro.
,
Sep 1 2017
,
Sep 1 2017
,
Sep 5 2017
yawano@ any update on this fix?
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bef6b21c56e44850e3241d92d282bda1117705e commit 6bef6b21c56e44850e3241d92d282bda1117705e Author: Yuki Awano <yawano@chromium.org> Date: Wed Sep 06 02:53:21 2017 Capture key events by pre target handler for tray bubble view Captures key events by pre target handler for activating tray bubble view when user tries to interact the tray with keyboard. icon and open it. Press Tab key. Confirm that focus moves on the system tray. Confirm the same thing for Android window as well. ash_unittests::SystemTrayTest.KeyboardNavigationWithOtherWindow exo_unittests::ShellSurfaceTest.KeyboardNavigationWithSystemTray Bug: 740055 , 731748 Test: Open a chrome packaged app (e.g. Files app). Click system tray Change-Id: I2251f1cdaf7bda3ab8b472c671e9f3089086302e Reviewed-on: https://chromium-review.googlesource.com/603547 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#499859} [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/ime_menu/ime_menu_tray.h [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/palette/palette_tray.cc [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/palette/palette_tray.h [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/tray/system_tray.cc [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/tray/system_tray.h [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/tray/system_tray_unittest.cc [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/system/web_notification/web_notification_tray.h [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/test/ash_test_views_delegate.cc [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ash/test/ash_test_views_delegate.h [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/6bef6b21c56e44850e3241d92d282bda1117705e/ui/views/bubble/tray_bubble_view.h
,
Sep 6 2017
The CL has landed on master. Request the CL to merge for both M61 and M62.
,
Sep 6 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
Merge approved for 62, please ensure this CL makes it into ToT Chrome OS first, this does not appear to be in the last successful Chrome PFQ run, but it should be in by tomorrow (63.0.3208.0+ should pass PFQ first).
,
Sep 6 2017
Approving merge to M61.
,
Sep 7 2017
Could this cause problems with accelerator keys? See issue 762155
,
Sep 7 2017
No, I don't think the CL causes the issue. I've quickly checked my local build which contains the CL (based on the old ToT), I couldn't see the issue. Also, the CL installs PreTargetHandler only when tray bubble view is shown (and it's not activated yet).
,
Sep 7 2017
Waiting this CL come into the ToT Chrome OS before merging them.
,
Sep 11 2017
The CL is now in ToT Chrome OS. I'm going to cherry pick the CL now.
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c9202986574e296a7dcfe42d0d2dc9ca9fff067 commit 1c9202986574e296a7dcfe42d0d2dc9ca9fff067 Author: Yuki Awano <yawano@chromium.org> Date: Mon Sep 11 01:16:12 2017 Capture key events by pre target handler for tray bubble view Captures key events by pre target handler for activating tray bubble view when user tries to interact the tray with keyboard. icon and open it. Press Tab key. Confirm that focus moves on the system tray. Confirm the same thing for Android window as well. ash_unittests::SystemTrayTest.KeyboardNavigationWithOtherWindow exo_unittests::ShellSurfaceTest.KeyboardNavigationWithSystemTray Bug: 740055 , 731748 Test: Open a chrome packaged app (e.g. Files app). Click system tray Change-Id: I2251f1cdaf7bda3ab8b472c671e9f3089086302e Reviewed-on: https://chromium-review.googlesource.com/603547 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499859}(cherry picked from commit 6bef6b21c56e44850e3241d92d282bda1117705e) Reviewed-on: https://chromium-review.googlesource.com/657541 Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#115} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/ime_menu/ime_menu_tray.h [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/palette/palette_tray.cc [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/palette/palette_tray.h [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/tray/system_tray.cc [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/tray/system_tray.h [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/tray/system_tray_unittest.cc [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/system/web_notification/web_notification_tray.h [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/test/ash_test_views_delegate.cc [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ash/test/ash_test_views_delegate.h [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/1c9202986574e296a7dcfe42d0d2dc9ca9fff067/ui/views/bubble/tray_bubble_view.h
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7003113b1eab183b159c1459d2ddb40c9e1d1640 commit 7003113b1eab183b159c1459d2ddb40c9e1d1640 Author: Yuki Awano <yawano@chromium.org> Date: Mon Sep 11 01:41:29 2017 Capture key events by pre target handler for tray bubble view Captures key events by pre target handler for activating tray bubble view when user tries to interact the tray with keyboard. icon and open it. Press Tab key. Confirm that focus moves on the system tray. Confirm the same thing for Android window as well. ash_unittests::SystemTrayTest.KeyboardNavigationWithOtherWindow exo_unittests::ShellSurfaceTest.KeyboardNavigationWithSystemTray TBR=yawano@chromium.org (cherry picked from commit 6bef6b21c56e44850e3241d92d282bda1117705e) Bug: 740055 , 731748 Test: Open a chrome packaged app (e.g. Files app). Click system tray Change-Id: I2251f1cdaf7bda3ab8b472c671e9f3089086302e Reviewed-on: https://chromium-review.googlesource.com/603547 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499859} Reviewed-on: https://chromium-review.googlesource.com/659457 Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1155} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/ime_menu/ime_menu_tray.h [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/palette/palette_tray.cc [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/palette/palette_tray.h [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/tray/system_tray.cc [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/tray/system_tray.h [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/tray/system_tray_unittest.cc [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/system/web_notification/web_notification_tray.h [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/test/ash_test_views_delegate.cc [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ash/test/ash_test_views_delegate.h [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/components/exo/shell_surface_unittest.cc [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/7003113b1eab183b159c1459d2ddb40c9e1d1640/ui/views/bubble/tray_bubble_view.h
,
Sep 11 2017
Merged to M61 and M62. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Jul 7 201714.4 MB
14.4 MB View Download