New issue
Advanced search Search tips

Issue 740051 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 833482
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

CQ should have some coverage with DCHECK off

Project Member Reported by primiano@chromium.org, Jul 7 2017

Issue description

It seems that https://chromium-review.googlesource.com/c/562676/ got reverted twice because the author had a bug like this:

DCHECK(function_with_side_effects())

which works fine in debug/dcheck_always_on=true cases but is clearly buggy in official/release modes.

IMHO this should have been caught by the CQ
 
Components: -Infra>CQ Infra>Client>Chrome
Labels: -OS-Mac OS-All
Mergedinto: 833482
Status: Duplicate (was: Unconfirmed)

Sign in to add a comment