Issue metadata
Sign in to add a comment
|
CQ should have some coverage with DCHECK off |
||||||||||||||||||||||||
Issue descriptionIt seems that https://chromium-review.googlesource.com/c/562676/ got reverted twice because the author had a bug like this: DCHECK(function_with_side_effects()) which works fine in debug/dcheck_always_on=true cases but is clearly buggy in official/release modes. IMHO this should have been caught by the CQ
,
Jul 11 2017
,
Jun 4 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tandrii@chromium.org
, Jul 7 2017