New issue
Advanced search Search tips

Issue 740047 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Use PointerEvents instead of MouseEvents in media controls

Project Member Reported by mlamouri@chromium.org, Jul 7 2017

Issue description

This is a TODO that was added by mustaq@ a while ago. Because we use MouseEvents, there are a few small differences in behaviour and in general, we should move to the new paradigms in our own code.
 
Cc: nzolghadr@chromium.org
Components: Blink>Input
Labels: -Pri-2 Pri-3
Owner: eirage@chromium.org
Status: Assigned (was: Available)
Hi eirage@: Any chance you can take a look sometime this quarter? It's not urgent, btw.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbc088c92a94014f4592048a7658334991f1c4fd

commit cbc088c92a94014f4592048a7658334991f1c4fd
Author: Ella Ge <eirage@chromium.org>
Date: Sat Jul 22 20:59:07 2017

Use PointerEvents instead of MouseEvents in media controls

Change code in Media control elements using MouseEvent to 
PointerEvent

Bug:  740047 
Change-Id: Ib693c8939eda3d191d0d3a11543dd013d13e1224
Reviewed-on: https://chromium-review.googlesource.com/567131
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488872}
[modify] https://crrev.com/cbc088c92a94014f4592048a7658334991f1c4fd/third_party/WebKit/LayoutTests/media/video-controls-mouse-events-captured.html
[modify] https://crrev.com/cbc088c92a94014f4592048a7658334991f1c4fd/third_party/WebKit/Source/core/html/media/MediaRemotingElements.cpp
[modify] https://crrev.com/cbc088c92a94014f4592048a7658334991f1c4fd/third_party/WebKit/Source/core/html/media/MediaRemotingElements.h
[modify] https://crrev.com/cbc088c92a94014f4592048a7658334991f1c4fd/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/cbc088c92a94014f4592048a7658334991f1c4fd/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.cpp
[modify] https://crrev.com/cbc088c92a94014f4592048a7658334991f1c4fd/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
[modify] https://crrev.com/cbc088c92a94014f4592048a7658334991f1c4fd/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.cpp

Comment 4 by eirage@chromium.org, Jul 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment