New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740046 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Focus is lost when items are deleted on chrome://settings/content/location

Project Member Reported by divya.pa...@techmahindra.com, Jul 7 2017

Issue description

Chrome Version: 61.0.3150.0
OS: Ubuntu 14.04, win 7

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://settings/content/location
(2)Keep tabbing until focus reaches delete button
     (i)press "Enter" key (ii) and then "tab" key(once)


Expected:
(i)On pressing Enter default Focus should be seen on first item 
(ii)Else, on tabbing the focus should be seen on first item

Actual:
(i)Instead Focus is lost 
(ii)On tabbing focus is seen on 2nd item instead of first item

Note: Same issue exist when we delete cookies, Attached screens-cast for reference

This is a regression issue broken in M-61. 
===============================
Manual Bisect info:
Good build:61.0.3131.0
Bad Build :61.0.3132.0
 
Actual_focus.ogv
3.9 MB View Download
Expected_Focus.ogv
2.9 MB View Download
Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on mac 10.12.5 using latest canary #61.0.3150.0

Labels: -Needs-Bisect hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Untriaged)
Bisect Information:
--------------------
Using per revision bisect providing information below.

You are probably looking for a change made after 479873 (known good), but no later than 479874 (first known bad).

Change Log URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/f3c3acf46bb30d7f15f7baffda2b8013664cba50..bf4adbb1a2b7066a30297d5df51707fd468d391d

From the above CL suspecting the below change
Review-Url: https://codereview.chromium.org/2848973003
 
scottchen@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. 

Thanks!

Summary: Regression: Focus is lost when items are deleted on chrome://settings/content/location (was: Regression: Focus is lost when items are deleted)
Cc: dschuyler@chromium.org
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
This behavior is expected for lists that are rendered with dom-repeat. We *could* potentially convert the list to an iron-list, but there are other problems associated with multiple iron-lists on the same page. Also, the settings/content/* UI might change more drastically (discussion led by dschuyler@), so de-prioritizing until further discussion.

(FYI: for lists that ARE iron-lists, a similar item-removal focus issue can be avoided by adding a <iron-list preserve-focus> flag.)
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: aee@chromium.org
@aee: Can you triage this? Does it still happen?
Status: Started (was: Untriaged)
It's still happening. The site list on the chrome://settings/content/location page is using dom-repeat. The entire site list is replaced for every update.

Option 1:
Use ListPropertyUpdateBehavior in site list. This will allow for a single tab press to focus on the correct remove button.

Option 2:
Replace dom-repeat with iron-list and use FocusRowBehavior. This will allow the entire list be focused as a single entity. The focused item is remembered after subsequent focusing of the list. Row controls can be focused using arrows. After remove is clicked, the correct remove button will be focused without pressing tab.

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92dca0eac0e950e7978272c01bcdc3adb32d50e1

commit 92dca0eac0e950e7978272c01bcdc3adb32d50e1
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Jul 19 03:39:59 2018

Settings: only update parts of the list that changed in site list

After removing a site, the next site is focused with a single tab press.


Bug:  740046 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ifcd05b623e1f98361b9dc14e0ed2c41c4889f876
Reviewed-on: https://chromium-review.googlesource.com/1141360
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576352}
[modify] https://crrev.com/92dca0eac0e950e7978272c01bcdc3adb32d50e1/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/92dca0eac0e950e7978272c01bcdc3adb32d50e1/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/92dca0eac0e950e7978272c01bcdc3adb32d50e1/chrome/browser/resources/settings/site_settings/site_list.js

Status: Fixed (was: Started)
Labels: TE-Verified-M69 TE-Verified-69.0.3494.0
Able to reproduce the issue on chrome version 61.0.3150.0 (build without fix) as per the comment #0.
Verified the fix on Mac 10.13.5, Windows 10 and Ubuntu 17.10  using Chrome version # 69.0.3497.0 .
Attaching screen-cast for reference.
Observed that  " After removing a site, the next site is focused with a single tab press " 
The fix is working as expected, adding Verified labels

Thanks...!
740046.mp4
531 KB View Download
Labels: -TE-Verified-69.0.3494.0 TE-Verified-69.0.3497.0

Sign in to add a comment