"IS_RECOVERY_INSTALL: parameter not set" error when running chromeos-install |
|||
Issue descriptionWhat steps will reproduce the problem? Run /usr/sbin/chromeos-install from a freshly built test image booted from a USB stick What is the expected result? Installation should complete successfully. What happens instead? The following happens: Installing the stateful partition... ./chromeos-install: 1: IS_RECOVERY_INSTALL: parameter not set Running a hw diagnostics test -- this might take a couple minutes. ....
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6bee748cf8b210aa703963ccaa8ce99ecdcb65d5 commit 6bee748cf8b210aa703963ccaa8ce99ecdcb65d5 Author: Alexandre Courbot <acourbot@chromium.org> Date: Mon Jul 10 18:22:36 2017 installer: fix when IS_RECOVERY_INSTALL is not set The installer was evaluating the IS_RECOVERY_INSTALL environment variable in a -u environment, making it fail if the variable is undeclared (which is the case if the installer is run normally): ./chromeos-install: 1: IS_RECOVERY_INSTALL: parameter not set Fix this by making the variable expand to the empty string if not declared. Fixes c4972eb847 "Report recovery metrics to UMA after recovery". BUG= chromium:740042 TEST=chromeos-install completes successfully when run as-is. Change-Id: Id0fe2d653cff4e1286670be57f6df437423504f2 Reviewed-on: https://chromium-review.googlesource.com/563277 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Alexandre Courbot <acourbot@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/6bee748cf8b210aa703963ccaa8ce99ecdcb65d5/installer/chromeos-install
,
Jul 10 2017
Closing as fix has been merged.
,
Jul 11 2017
For reference, bug introduced by https://chromium-review.googlesource.com/c/540828/ in 9718.0.0, and should be fixed by #2 in 9733.0.0.
,
Jul 12 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by acourbot@chromium.org
, Jul 7 2017