New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 740011 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Focus highlight is seen behind 'Remove this person' dialog and dialog doesn't disappear.

Reported by rp...@etouch.net, Jul 7 2017

Issue description

Version: 61.0.3150.0 e32c608bfaee28eb9bd478073a2f222fb6c28133-refs/heads/master@{#484424}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Launch chrome and click on avatar icon in top RHS of browser window and click on 'Manage people' to open overlay.
2. Now open 'Remove this person' dialog using 'Tab' and 'Enter' key and then press 'Shift + Tab' key to reverse focus travel,observe
 
Actual: After pressing 'Shift + Tab' key focus highlight is seen behind 'Remove this person' dialog and window doesn't disappear 
Expected: After pressing 'Shift + Tab' key 'Remove this person' dialog should disappear and focus highlight should not be seen behind it.

This is regression issue, broken in ‘M 52’ and will soon update other info :
Good build:52.0.2713.0
Bad build: 52.0.2714.0
 
Actual_video.mp4
451 KB View Download
Expected_video.mp4
404 KB View Download
Actual_screenshot.png
221 KB View Download
Labels: hasbisect
Owner: mahmadi@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/6bf9cf81374dfdbd6fc0bd6420c260d9a8793ce8..47fcf60157c8e5e4898e8fc4eeafbe5a92159589?pretty=fuller&n=10000

Suspecting: r388503?

@mahmadi: Kindly help to re-assign if your change is not the cause for this issue.
Owner: msarda@chromium.org
+msarda@ for triage.

Comment 3 by msarda@chromium.org, Jul 10 2017

Labels: -Pri-1 Hotlist-Polish Pri-2
This has been broken for 8 releases, so moving it to P2. Re-assigning to Jerome who is now the owner for Use Manager.

Note that awe have a lot of bugs now, so I am not sure when we'll get to this one.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 9 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by msarda@chromium.org, Oct 30 2017

Owner: scottchen@chromium.org
Status: Assigned (was: Available)
Scott may have some time to get to this bug.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cc7f4968ca571be6acd71583ee69f6423bfa4d4

commit 5cc7f4968ca571be6acd71583ee69f6423bfa4d4
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Nov 27 09:47:42 2017

MD User Manager: close action menu when focus moves to icon-button.

Currently the keyboard focus can move off of a user's action menu but the
menu will stay open. This CL forces it to close when the focus is moved to
the icon-element via shift+tab.

Bug:  740011 
Change-Id: I243d5affe0e6b93310d7973c4db89490bc5a7878
Reviewed-on: https://chromium-review.googlesource.com/749813
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519258}
[modify] https://crrev.com/5cc7f4968ca571be6acd71583ee69f6423bfa4d4/ui/login/account_picker/user_pod_row.js

Labels: TE-Verified-M64 TE-Verified-64.0.3279.0
Rechecked the above issue on  OS Win(7,8,10),Mac(10.12.6,10.13.2),Linux(14.04 LTS) with latest canary chrome version :64.0.3279.0 and the issue is working as intended.Kindly refer the attached screen cast for reference.
Result.mov
1.5 MB Download
Status: Fixed (was: Started)

Sign in to add a comment