New issue
Advanced search Search tips

Issue 740009 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

MacSandboxTest tests leak temp folders

Project Member Reported by tapted@chromium.org, Jul 7 2017

Issue description

Chrome Version       : 61.0.3150.0
OS Version: OS X 10.12.5

What steps will reproduce the problem?
1. For extra info, something like,

diff --git a/base/files/scoped_temp_dir.cc b/base/files/scoped_temp_dir.cc
index a04e825156b6..e62f5527ac2e 100644
--- a/base/files/scoped_temp_dir.cc
+++ b/base/files/scoped_temp_dir.cc
@@ -21,7 +21,7 @@ ScopedTempDir::ScopedTempDir() {

 ScopedTempDir::~ScopedTempDir() {
   if (!path_.empty() && !Delete())
-    DLOG(WARNING) << "Could not delete temp dir in dtor.";
+    PLOG(WARNING) << "Could not delete temp dir in dtor." << path_.value();
 }

 bool ScopedTempDir::CreateUniqueTempDir() {


2. run $ content_unittests --gtest_filter=MacSandboxTest.*

What is the expected result?

No warnings about leaked folders


What happens instead of that?

17 leaked tempdirs: `ls -d ${TMPDIR}/.org.chromium.Chromium*`

Output like

[19692:775:0707/153527.880022:975110812416200:WARNING:scoped_temp_dir.cc(24)] Could not delete temp dir in dtor./var/folders/00/1_wbr000h01000cxqpysvccm005bjg/T/.org.chromium.Chromium.hK3uin: Operation not permitted


 
Summary: MacSandboxTest tests leak temp folders (was: MacSandboxTest tests leak file descriptors)
Cc: wfh@chromium.org
Labels: M-61

Comment 3 by lgrey@chromium.org, Jul 12 2017

Status: Available (was: Unconfirmed)
Cc: rsesek@chromium.org
Labels: -M-61
Cc: kerrnel@chromium.org
Greg: Just FYI since you're redoing these tests.
Owner: kerrnel@chromium.org
Status: Started (was: Available)
Indeed I am rewriting those tests completely.
Fixed by  issue 902597  now?
Status: Fixed (was: Started)

Sign in to add a comment