New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739988 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Rename OnTextInputTypeChanged to clarify it's called only by mock

Project Member Reported by oka@chromium.org, Jul 7 2017

Issue description

Comment 1 by oka@chromium.org, Jul 7 2017

I realized it can be removed.
OnTextInputTypeChanged is only utilized by TextInputTestHelper, but it can use OnTextInputStateChanged instead.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/878de580c1c74bafbbd1d3045075b6d13fbdd4f1

commit 878de580c1c74bafbbd1d3045075b6d13fbdd4f1
Author: oka@chromium.org <oka@chromium.org>
Date: Thu Jul 13 03:45:13 2017

Remove OnTextInputTypeChanged, which is only called by mock.

Bug:  739988 
Change-Id: Ic484a862e25700611581989f6e660267a01a2cbe
Reviewed-on: https://chromium-review.googlesource.com/562844
Commit-Queue: Keigo Oka <oka@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486261}
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.h
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/chrome/browser/chromeos/input_method/textinput_test_helper.cc
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/chrome/browser/chromeos/input_method/textinput_test_helper.h
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/content/public/test/text_input_test_utils.cc
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/content/public/test/text_input_test_utils.h
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/ui/base/ime/input_method_base_unittest.cc
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/ui/base/ime/input_method_observer.h
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/ui/base/ime/mock_input_method.cc
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/ui/views/win/hwnd_message_handler.cc
[modify] https://crrev.com/878de580c1c74bafbbd1d3045075b6d13fbdd4f1/ui/views/win/hwnd_message_handler.h

Comment 3 by oka@chromium.org, Jul 13 2017

Status: Fixed (was: Available)
Status: Verified (was: Fixed)

Sign in to add a comment