New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739981 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Refactoring: Remove unused virtualKeyboardPrivate.onTextInputBoxFocused

Project Member Reported by oka@chromium.org, Jul 7 2017

Issue description

Looks like it's usage had been removed with https://codereview.chromium.org/730573002, while the effort to open-source google-input-tools.

I think we can remove ChromeKeyboardUI::SetUpdateInputType consequently.
 

Comment 1 by oka@chromium.org, Jul 7 2017

Components: UI>Input>VirtualKeyboard
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5ccccd11d40341dc3cda365d50b48fce0c58563

commit d5ccccd11d40341dc3cda365d50b48fce0c58563
Author: oka@chromium.org <oka@chromium.org>
Date: Wed Jul 12 18:07:15 2017

Remove virtualKeyboardPrivate.OnTextInputTypeChanged.

Bug:  739981 
Change-Id: Idc363ceddee581c07317921f5f04c107ebeda427
Reviewed-on: https://chromium-review.googlesource.com/562946
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486024}
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/ash/test/test_keyboard_ui.cc
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/ash/test/test_keyboard_ui.h
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/chrome/browser/ui/ash/chrome_keyboard_ui.h
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/extensions/common/api/virtual_keyboard_private.json
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/ui/keyboard/content/keyboard_ui_content_unittest.cc
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/ui/keyboard/keyboard_controller_unittest.cc
[modify] https://crrev.com/d5ccccd11d40341dc3cda365d50b48fce0c58563/ui/keyboard/keyboard_ui.h

Comment 3 by oka@chromium.org, Jul 12 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment