New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739972 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Media Remoting: Source content bitrate estimation and network bandwidth estimation tracker.

Project Member Reported by x...@chromium.org, Jul 7 2017

Issue description

To avoid the immediately falling back to mirroring after remoting started, when media remoting is ready to start (other conditions satisfy), we should check whether the network bandwidth is sufficient for remoting the content. This tracks the implementation of content bitrate estimation and network bandwidth estimation for media remoting.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92ec9bd3c7863410f457d03aa741f999bf3f224

commit c92ec9bd3c7863410f457d03aa741f999bf3f224
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Tue Jul 25 21:56:42 2017

Remove the viewport fill debouncer timer.

This CL removed the viewport fill debouncer timer and added a delayed 
start mechanism to monitor that all requirements are met and held 
stable for a short period of time before switching to media remoting. 
The content bitrate will also be estimated and evaluated in this period
in an incoming change. 

Also stopped using fullscreen status in the remoting switching logic to
avoid conflict and racing between fullscreen status change and dominant
status change.

Bug:  739815 ,  739972 
Change-Id: I924d8fbdce7dddd2f1f334aeacae4cdc2b58c455
Reviewed-on: https://chromium-review.googlesource.com/571238
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489455}
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/base/media_observer.h
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/remoting/renderer_controller.cc
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/remoting/renderer_controller.h
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/remoting/renderer_controller_unittest.cc
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/third_party/WebKit/Source/core/html/MediaElementFillingViewportTest.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41

commit 8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Wed Aug 02 07:12:42 2017

Media Remoting: Add content bitrate estimation and condition check.

When network bandwidth is not sufficient to remote the content directly
to the receiver, media remoting will fallback to mirroring. To avoid
this fallback happen immediately after remoting starts, estimate the
content bitrate and only start remoting when the network bandwidth is
sufficient.

Bug:  739972 
Change-Id: I2bae3bed042ab1f6d6946877213729b18043dc7d
Reviewed-on: https://chromium-review.googlesource.com/567031
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491289}
[modify] https://crrev.com/8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41/media/base/media_observer.h
[modify] https://crrev.com/8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41/media/remoting/metrics.cc
[modify] https://crrev.com/8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41/media/remoting/metrics.h
[modify] https://crrev.com/8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41/media/remoting/renderer_controller.cc
[modify] https://crrev.com/8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41/media/remoting/renderer_controller.h
[modify] https://crrev.com/8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41/media/remoting/renderer_controller_unittest.cc
[modify] https://crrev.com/8f6cf3ba941c2df27c9d416c0eb1e21bb492ad41/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a33c3333033a98e80130522c9455b94020ea60

commit 64a33c3333033a98e80130522c9455b94020ea60
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Thu Aug 03 17:14:20 2017

Media Remoting: Get estimated network bandwidth from Remoter.

This CL adds the interface to get estimated network capacity from
Remoter. A follow up CL will check whether the network bandwidth is
sufficient to activate media remoting.

Bug:  739972 
Change-Id: Ica6aee81b23894748951fc8f27afcf74dabb6a28
Reviewed-on: https://chromium-review.googlesource.com/587507
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491772}
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/chrome/browser/media/cast_remoting_connector.cc
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/chrome/browser/media/cast_remoting_connector.h
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/chrome/browser/media/cast_remoting_connector_unittest.cc
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/mojo/interfaces/mirror_service_remoting.mojom
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/mojo/interfaces/remoting.mojom
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/remoting/end2end_test_renderer.cc
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/remoting/fake_remoter.cc
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/remoting/fake_remoter.h
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/remoting/renderer_controller.cc
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/remoting/renderer_controller.h
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/remoting/shared_session.cc
[modify] https://crrev.com/64a33c3333033a98e80130522c9455b94020ea60/media/remoting/shared_session.h

Comment 4 by mfo...@chromium.org, Mar 15 2018

xjz@:  It looks like work wrapped up on this in August 2017.  Should this be kept open (at a lower priority) or closed?


Comment 5 by x...@chromium.org, Mar 15 2018

Labels: -Pri-1 Pri-3
Status: Fixed (was: Started)
Close this for now. May open another issue later to get the true network bandwidth estimate with mirroring service.

Comment 6 by mfo...@chromium.org, Mar 15 2018

Labels: -Pri-3 Pri-1
Thanks!

I think it was Pri-1 at the time you worked on it :-)  But change it back if you feel strongly.

Sign in to add a comment