New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739965 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[DevTools] inspector/console/console-log-linkify-stack-in-errors.html NeedsManualRebaseline

Project Member Reported by kozyatinskiy@chromium.org, Jul 7 2017

Issue description

I'm going to move LoadNamedProperty source position by one to the right in [1].

[1] https://chromium-review.googlesource.com/c/543047
 
Summary: [DevTools] inspector/console/console-log-linkify-stack-in-errors.html NeedsManualRebaseline (was: [DevTools] inspector/console/console-log-linkify-stack-in-errors.js NeedsManualRebaseline)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a1ea85d513d78b51f14136c94f43c5e19d52803

commit 6a1ea85d513d78b51f14136c94f43c5e19d52803
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jul 07 03:22:19 2017

[DevTools] console-log-linkify-stack-in-errors.html NeedsManualRebaseline

We need to mark this test to land V8 CL [1].

[1] https://chromium-review.googlesource.com/c/543047

TBR=pfeldman@chromium.org

Bug:  chromium:739965 
Change-Id: I918cae55c1406c1d2b2d511cdf056d83f25c4c8f
Reviewed-on: https://chromium-review.googlesource.com/562750
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484818}
[modify] https://crrev.com/6a1ea85d513d78b51f14136c94f43c5e19d52803/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6a1ea85d513d78b51f14136c94f43c5e19d52803/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac2e9a9d1186e1c1a45108ce4eefe9172b4e0687

commit ac2e9a9d1186e1c1a45108ce4eefe9172b4e0687
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Jul 10 21:48:10 2017

Marks fast/events/window-onerror-12.html as NeedsManualRebaseline

TBR=pfeldman@chromium.org

Bug:  chromium:739965 
Change-Id: Id0a4e0b9e336c78107c0fee82ec764d842c1f2f8
Reviewed-on: https://chromium-review.googlesource.com/565195
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485408}
[modify] https://crrev.com/ac2e9a9d1186e1c1a45108ce4eefe9172b4e0687/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ac2e9a9d1186e1c1a45108ce4eefe9172b4e0687/third_party/WebKit/LayoutTests/fast/events/window-onerror-12-expected.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/653667cfaf73a73c6e9c449d8f7d8412c79cfa31

commit 653667cfaf73a73c6e9c449d8f7d8412c79cfa31
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Jul 11 22:47:21 2017

[DevTools] enable tests back

Related V8 change was rolled.

TBR=pfeldman@chromium.org

Bug:  chromium:739965 
Change-Id: I1618f0dec3d928888e0d94347cb51075f432e027
Reviewed-on: https://chromium-review.googlesource.com/567279
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485723}
[modify] https://crrev.com/653667cfaf73a73c6e9c449d8f7d8412c79cfa31/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment