Harmonize High Contrast extension prompt bubble [needs mock] |
|||||||||||||
Issue descriptionDidn't find an existing bug for this dialog. Attaching a screenshot of what it looks like right now.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8beb72634fdd04bb6b4ad35e87888ceae17b9693 commit 8beb72634fdd04bb6b4ad35e87888ceae17b9693 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jul 12 18:45:44 2017 Add BrowserDialogTests for AppInfoDialog and InvertBubbleView. Bug: 700189, 739961 Change-Id: I07b708d3a21e8a9af485ed1320af8564d4271abe Reviewed-on: https://chromium-review.googlesource.com/562897 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#486036} [modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc [modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/apps/app_info_dialog.h [modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view.cc [modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view.h [add] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view_browsertest.cc [modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc [add] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc [modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/hung_renderer_view_browsertest.cc [modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/webui/ntp/app_launcher_handler.cc [modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/test/BUILD.gn
,
Aug 9 2017
,
Aug 9 2017
,
Aug 9 2017
,
Aug 22 2017
I need more info on how to trigger this / what this is
,
Aug 22 2017
Trigger by enabling high-contrast mode on Windows (Settings>Ease of Access>High Contrast). There's probably an equivalent for other platforms but I don't know of it. This dialog will pop up.
,
Aug 22 2017
Also, the links (from the left) open these pages when clicked: 1. https://chrome.google.com/webstore/detail/high-contrast/djcfdncoelnlbldjfhinnjlhdjlikmph 2. https://chrome.google.com/webstore/category/collection/dark_themes 3. https://productforums.google.com/forum/#!topic/chrome/Xrco2HsXS-8/discussion 4. Just closes the dialog
,
Aug 22 2017
Thanks Bret. I cringe thinking we're linking to a product forum about m19. I've attached a general layout for this, but let's first ask if we even need this dialog. Hwi & Shimi: We have a high contrast dialog that we need to Harmonize. Most important question is: Do we need to have this UI at all? Users enable a OS level high contrast mode. Once they open the chrome window, we 1.) tell them something they already know and 2.) promote chrome extensions that they theoretically don't need.
,
Aug 22 2017
dmazzoni, lpalmaro - could you confirm whether to keep the InvertBubbleView dialog (screenshot on the top of the thread)?
,
Aug 22 2017
I think the information provided is valuable. Setting an OS-level high contrast doesn't make the internet high contrast; that's what the extension is for. If a user wants one they probably want the other. Of course the value of that information might not outweigh the cost of showing a dialog.
,
Aug 22 2017
Yes, we want to keep the dialog, but I'm hoping that later this year we'll replace it with a dialog prompting users to use native high-contrast mode instead.
,
Aug 24 2017
Thanks dmazzoni! Let's refine messaging and layout via: go/cr-739961-mock
,
Aug 25 2017
,
Sep 5 2017
,
Sep 5 2017
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Jan 10 2018
It looks like the design work on this bug is finished. Load balancing to engineering
,
Jan 19 2018
Here's the dialog based on the Mock from the document here: go/cr-739961-mock
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b48670528739d2fe5b54e3ce9a98d0ebbead210 commit 1b48670528739d2fe5b54e3ce9a98d0ebbead210 Author: Allen Bauer <kylixrd@chromium.org> Date: Wed Jan 24 18:39:01 2018 Harmonize the High-contrast mode dialog. The proposal and mocks live here: https://docs.google.com/document/d/1p1s_oBI5X7Z0FQdag9WjO4sNcoEcICkkTvhBOIVF6LQ/edit?ts=599e73e2 TBR=grt@chromium.org Bug: 739961 Change-Id: I28858f4113ac84dc6e660808144de1eab18b297d Reviewed-on: https://chromium-review.googlesource.com/874950 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#531620} [modify] https://crrev.com/1b48670528739d2fe5b54e3ce9a98d0ebbead210/chrome/app/generated_resources.grd [modify] https://crrev.com/1b48670528739d2fe5b54e3ce9a98d0ebbead210/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
,
Jan 25 2018
Verified the fix on Windows10 using Chrome version #66.0.3331.0 as per the comment #0. Attaching screen shot for reference. Observed that the dialog appeared is similar to that the attachement found in C#19. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jan 26 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by pkasting@chromium.org
, Jul 7 2017