New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739961 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Windows
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta



Sign in to add a comment

Harmonize High Contrast extension prompt bubble [needs mock]

Project Member Reported by bsep@chromium.org, Jul 7 2017

Issue description

Didn't find an existing bug for this dialog. Attaching a screenshot of what it looks like right now.
 
high-contrast-prompt-bubble.PNG
80.9 KB View Download
Is this InvertBubbleView?

That's pretty gross.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8beb72634fdd04bb6b4ad35e87888ceae17b9693

commit 8beb72634fdd04bb6b4ad35e87888ceae17b9693
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jul 12 18:45:44 2017

Add BrowserDialogTests for AppInfoDialog and InvertBubbleView.

Bug: 700189, 739961
Change-Id: I07b708d3a21e8a9af485ed1320af8564d4271abe
Reviewed-on: https://chromium-review.googlesource.com/562897
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486036}
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/apps/app_info_dialog.h
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view.h
[add] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/accessibility/invert_bubble_view_browsertest.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
[add] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/views/hung_renderer_view_browsertest.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/8beb72634fdd04bb6b4ad35e87888ceae17b9693/chrome/test/BUILD.gn

Labels: -Pri-3 Pri-2
Status: Assigned (was: Untriaged)
Summary: Harmonize High Contrast extension prompt bubble (needs mocks) (was: Harmony - High Contrast extension prompt bubble)
Summary: Harmonize High Contrast extension prompt bubble [needs mock] (was: Harmonize High Contrast extension prompt bubble (needs mocks))

Comment 6 by bettes@chromium.org, Aug 22 2017

Owner: bsep@chromium.org
I need more info on how to trigger this / what this is 

Comment 7 by bsep@chromium.org, Aug 22 2017

Labels: OS-Windows
Owner: bettes@chromium.org
Trigger by enabling high-contrast mode on Windows (Settings>Ease of Access>High Contrast). There's probably an equivalent for other platforms but I don't know of it. This dialog will pop up.

Comment 9 by bettes@chromium.org, Aug 22 2017

Cc: bsep@chromium.org
Owner: hwi@chromium.org
Thanks Bret. I cringe thinking we're linking to a product forum about m19. I've attached a general layout for this, but let's first ask if we even need this dialog. 

Hwi & Shimi: 
We have a high contrast dialog that we need to Harmonize. Most important question is: Do we need to have this UI at all? 

Users enable a OS level high contrast mode. Once they open the chrome window, we 1.) tell them something they already know and 2.) promote chrome extensions that they theoretically don't need. 


Screen Shot 2017-08-21 at 6.36.29 PM.png
145 KB View Download

Comment 10 by hwi@chromium.org, Aug 22 2017

Cc: lpalmaro@chromium.org dmazz...@chromium.org
dmazzoni, lpalmaro - could you confirm whether to keep the InvertBubbleView dialog (screenshot on the top of the thread)?

Comment 11 by bsep@chromium.org, Aug 22 2017

I think the information provided is valuable. Setting an OS-level high contrast doesn't make the internet high contrast; that's what the extension is for. If a user wants one they probably want the other. Of course the value of that information might not outweigh the cost of showing a dialog.
Yes, we want to keep the dialog, but I'm hoping that later this year we'll replace it with a dialog prompting users to use native high-contrast mode instead.

Comment 13 by hwi@chromium.org, Aug 24 2017

Thanks dmazzoni!

Let's refine messaging and layout via: go/cr-739961-mock

Comment 14 by hwi@chromium.org, Aug 25 2017

Cc: hwi@chromium.org
 Issue 601942  has been merged into this issue.
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
The NextAction date has arrived: 2017-11-10

Comment 18 by bsep@chromium.org, Jan 10 2018

Owner: kylixrd@chromium.org
It looks like the design work on this bug is finished. Load balancing to engineering
Here's the dialog based on the Mock from the document here: go/cr-739961-mock
HighContrastDialog.png
4.6 KB View Download
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b48670528739d2fe5b54e3ce9a98d0ebbead210

commit 1b48670528739d2fe5b54e3ce9a98d0ebbead210
Author: Allen Bauer <kylixrd@chromium.org>
Date: Wed Jan 24 18:39:01 2018

Harmonize the High-contrast mode dialog.

The proposal and mocks live here: https://docs.google.com/document/d/1p1s_oBI5X7Z0FQdag9WjO4sNcoEcICkkTvhBOIVF6LQ/edit?ts=599e73e2

TBR=grt@chromium.org

Bug: 739961
Change-Id: I28858f4113ac84dc6e660808144de1eab18b297d
Reviewed-on: https://chromium-review.googlesource.com/874950
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531620}
[modify] https://crrev.com/1b48670528739d2fe5b54e3ce9a98d0ebbead210/chrome/app/generated_resources.grd
[modify] https://crrev.com/1b48670528739d2fe5b54e3ce9a98d0ebbead210/chrome/browser/ui/views/accessibility/invert_bubble_view.cc

Labels: TE-Verified-66.0.3331.0 TE-Verified-M66
Verified the fix on Windows10 using Chrome version #66.0.3331.0 as per the comment #0.
Attaching screen shot for reference.
Observed that the dialog appeared is similar to that the attachement found in C#19.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
739961.PNG
53.9 KB View Download
Cc: abdulsyed@chromium.org kylixrd@chromium.org
Owner: bettes@chromium.org

Sign in to add a comment