New issue
Advanced search Search tips

Issue 739941 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

FileMetricsProvider::ProvideIndependentMetrics() trying to access IO on thread that disallows IO

Project Member Reported by xhw...@chromium.org, Jul 6 2017

Issue description

[21447:21447:0706/161816.609660:FATAL:thread_restrictions.cc(38)] Check failed: false. Function marked as IO-only was called from a thread that disallows IO!  If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup.  If this task is running inside the TaskScheduler, the TaskRunner used to post it needs to have MayBlock() in its TaskTraits.
#0 0x7fe3d8f1e84d base::debug::StackTrace::StackTrace()
#1 0x7fe3d8f1ce8c base::debug::StackTrace::StackTrace()
#2 0x7fe3d8fad00a logging::LogMessage::~LogMessage()
#3 0x7fe3d9160d27 base::ThreadRestrictions::AssertIOAllowed()
#4 0x7fe3d8f76165 base::(anonymous namespace)::CallStat()
#5 0x7fe3d8f79656 base::GetFileInfo()
#6 0x55ebe2e08af1 metrics::FileMetricsProvider::ProvideIndependentMetrics()
#7 0x55ebe2e0e2c5 metrics::MetricsLog::LoadIndependentMetrics()
#8 0x55ebe2e194d2 metrics::MetricsService::PrepareProviderMetricsLog()
#9 0x55ebe2e16399 metrics::MetricsService::PrepareProviderMetricsTask()
#10 0x55ebe077e24f _ZN4base8internal13FunctorTraitsIMN11google_apis19UrlFetchRequestBaseEFvvEvE6InvokeIRKNS_7WeakPtrINS2_5drive30SingleBatchableDelegateRequestEEEJEEEvS5_OT_DpOT0_
#11 0x55ebe2e1ac8a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN7metrics14MetricsServiceEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_
#12 0x55ebe2e1ac20 _ZN4base8internal7InvokerINS0_9BindStateIMN7metrics14MetricsServiceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#13 0x55ebe2e1ab6c _ZN4base8internal7InvokerINS0_9BindStateIMN7metrics14MetricsServiceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#14 0x7fe3d8eca161 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#15 0x7fe3d8f232f7 base::debug::TaskAnnotator::RunTask()
#16 0x7fe3d8fdbdad base::MessageLoop::RunTask()
#17 0x7fe3d8fdc037 base::MessageLoop::DeferOrRunPendingTask()
#18 0x7fe3d8fdd6db base::MessageLoop::DoDelayedWork()
#19 0x7fe3d8fe41aa base::MessagePumpGlib::HandleDispatch()
#20 0x7fe3d8fe4901 base::(anonymous namespace)::WorkSourceDispatch()
#21 0x7fe3c2cdce04 g_main_context_dispatch
#22 0x7fe3c2cdd048 <unknown>
#23 0x7fe3c2cdd0ec g_main_context_iteration
#24 0x7fe3d8fe425f base::MessagePumpGlib::Run()
#25 0x7fe3d8fdb6d4 base::MessageLoop::Run()
#26 0x7fe3d908f41d base::RunLoop::Run()
#27 0x55ebe229486e ChromeBrowserMainParts::MainMessageLoopRun()
#28 0x7fe3d258a816 content::BrowserMainLoop::RunMainMessageLoopParts()
#29 0x7fe3d259323f content::BrowserMainRunnerImpl::Run()
#30 0x7fe3d257f0eb content::BrowserMain()
#31 0x7fe3d41665e4 content::RunNamedProcessTypeMain()
#32 0x7fe3d41691bf content::ContentMainRunnerImpl::Run()
#33 0x7fe3d416409d content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#34 0x7fe3d980da4a service_manager::Main()
#35 0x7fe3d416545f content::ContentMain()
#36 0x55ebe061270e ChromeMain
#37 0x55ebe0612622 main
#38 0x7fe3c1d97f45 __libc_start_main
#39 0x55ebe0612504 <unknown>

 
Status: Started (was: Untriaged)
It's this:
https://codereview.chromium.org/2966773002/

This was a temporary metric for analysis of the feature so I'll just remove it.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2903545a51ae356bf297cdd5735f98521daa410

commit f2903545a51ae356bf297cdd5735f98521daa410
Author: Brian White <bcwhite@chromium.org>
Date: Sat Jul 08 03:31:14 2017

Remove temporary metric that violates I/O restrictions.

BUG= 739941 

Change-Id: I385237e7643707381109879908bf5d493bf62345
Reviewed-on: https://chromium-review.googlesource.com/563542
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485137}
[modify] https://crrev.com/f2903545a51ae356bf297cdd5735f98521daa410/components/metrics/file_metrics_provider.cc
[modify] https://crrev.com/f2903545a51ae356bf297cdd5735f98521daa410/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment