What steps will reproduce the problem? (1) Go to https://sheriff-o-matic.appspot.com/chromeos (2) Click Resolve on a resolved ticket. What is the expected result? Ticket is resolved / disappears. What happens instead? Nothing.
Clarification to "Click Resolve on a resolved ticket." by which I mean an open ticket that I am trying to mark as resolved.
zhangtiff: I think this was broken by one of your grouping changes maybe?
Thanks! Yup, I am indeed guilty on this one. It looks like this is a side effect of some refactoring I did not so long ago..
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6252ba601a4a5347117a493cace77ce341829854 commit 6252ba601a4a5347117a493cace77ce341829854 Author: Tiff Zhang <zhangtiff@google.com> Date: Fri Jul 07 19:58:46 2017 SoM: Fix resolve button. Bug:739937 Change-Id: I467e26e585d5d298e40738685446c1cbe232f36a Reviewed-on: https://chromium-review.googlesource.com/563466 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> [modify] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.html [modify] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js [modify] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js [modify] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.js [modify] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html [modify] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html [add] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-post-behavior.html [modify] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/index.html [modify] https://crrev.com/6252ba601a4a5347117a493cace77ce341829854/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-view-test.html
Comment 1 by akes...@chromium.org
, Jul 6 2017