New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739928 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Gerrit: git cl upload: allow description modification on upload

Project Member Reported by rsesek@chromium.org, Jul 6 2017

Issue description

Chrome Version: depot_tools bc9c5ccf00e8e3d3e2937d49ddbc02818f80c351
OS: macOS 10.12.5

What steps will reproduce the problem?
Frequently when making large changes to a CL, I will want to modify the CL description to reflect changes that have been made to the code. Both in Rietveld and Gerrit, this can be done at any time using `git cl description` or the web UI. However in Gerrit, because the description is now part of the patch set, editing it creates another patch set. This clutters the patch set list and messages list.

It would be handy to be able update the CL description on upload, to make the act of "uploading new patch set" and "updating the description" one logical, atomic patch set. Perhaps this could be `git cl upload --edit-description`, which would bring up $EDITOR with the existing description.

What is the expected result?
A way to edit the CL description when uploading a new patch set.

What happens instead?
Have to create another patch set to just edit the CL description, either via web or `git cl description`.

Please use labels and text to provide additional information.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by aga...@chromium.org, Jul 10 2017

Cc: aga...@chromium.org
Components: Infra>SDK
Labels: Milestone-Afterglow Proj-Gerrit-Migration
Status: Available (was: Untriaged)
Yep, this totally makes sense as a feature request. I can't promise I'll get to it soon, and patches are of course always welcome. The main blocker for me doing this right away is that adding things (especially things like new flags) to git-cl is really hard while the Rietveld support is still there. Adding this feature will get much easier after that all gets ripped out.
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Cc: mcchou@google.com
 Issue 750863  has been merged into this issue.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment