Notifications from Twitter Lite web app occasionally fail to navigate to tweet |
||||
Issue descriptionChrome Version: 61.0.3142.0 (Official Build) dev (32-bit) OS: Android 7.1.2 NHG47O What steps will reproduce the problem? (1) Add Twitter Lite PWA to home screen via Chrome Dev. (2) Enable notifications. (3) Wait for notification of interesting tweet and tap it. What is the expected result? Expect to navigate to tweet. What happens instead? Intermittently, the app only goes back to the user's profile page and not to the specific tweet. This was seen before in Issue 726901 and it seemed to have been fixed, but I've seen it again over the past couple of days. It's very intermittent so not high priority, but probably has something to do with the service worker's child process being suspended or stopped. When it happened there was a long pause before opening up my profile page in Twitter Lite. Here's a bug report (Google employees only, sorry) captured immediately after I tapped a notification about a tweet by philogb@, and it didn't navigate there successfully: https://drive.google.com/open?id=0B5DES7PYkZBLWWs3MlNqRU5ZcmM Not sure if there's anything interesting in there. If not, would appreciate any guidance about how to capture useful information if this happens again. Thanks.
,
Jul 10 2017
This did happen once for me over the weekend. I have a theory that it occurs when the browser process has been evicted. We probably reinitialize history (cause getSavedInstanceState has data) and ignore the fact that there was a url override request.
,
Jul 10 2017
Ya - WebappActivity.initializeUI looks wrong when in the context of a WebApk deep link.
,
Jul 10 2017
Great diagnosis yfriedman@! BTW, it's happened a few more times for me since. One time at least the navigation was pretty quick, so I wonder whether the browser process was evicted in that case. One thing I've noticed is that sometimes the navigations seem to go to a Twitter Lite tab running in my instance of Chrome Dev, and sometimes to the Chrome custom tab (?) for the Twitter Lite shortcut from my desktop. (The Twitter Lite PWA shows up as a separate app in the app switcher.) I don't think I explicitly opened a link to twitter.com in Chrome Dev, so wonder whether the notifications are targeting the right Chrome instance all the time.
,
Jul 16 2017
Assigning this bug to ranj@ as this bug has the same fix as Issue 696720 When a non-null savedInstanceState is passed to Activity#onCreate() Activity#getIntent() is the intent that the WebAPK was originally created with, not the new intent
,
Jul 16 2017
I've observed the same behavior in current Chrome Beta (60) in a PWA I made[1]. When it's installed as WebAPK, clicking on notification only focuses the PWA, not opens the page requested. This with openWindow(); method. Previously it was performing a navigate in WebAPK. [1] https://m.omroepwest.nl
,
Jul 16 2017
Sorry, failed to mention: it happens eight of the install and all the time, not after "some time".
,
Jul 17 2017
pkotwicz: but that's still different from re-initing a WebApkInfo. Perhaps they could be solved with one patch but I think it's two different issues. For 696720, I imagine the WebApkInfo would be stored in memory merely between WebappLauncherActivity and WebApkActivity and not persisted for a long time which is different than how we init based on saved instance state. Regardless, we should try and get this fixed in time for 61 whereas 696720 is just an optimizatino
,
Jul 17 2017
I think that WebappLauncherActivity gets the new intent but that WebApkActivity gets the old intent
,
Jul 17 2017
Oh interesting. I hadn't considered that. I would've thoguht it was gone cause it's excluded from history but it's possible so it'll need some investigation. Either way, I'm pretty sure we can repro this by opening the twitterlite wbapk, hitting home, adb shell kill com.google.android.apps.chrome and then launching a deeplink. Note that swiping away twitter lite won't work since that clobbers savedinstancestate.
,
Jul 17 2017
Yaron: I was able to repro the failure (which is why I know its root cause). I stupidly implemented (and wrote comments for) the wrong fix before finding out that the fix does not work
,
Jul 17 2017
We have the same issues for webapps. If: 1) Chrome is unexpectedly killed 2) The user had several webapps open 3) The user tries to launch a webapp from the homescreen The wrong webapp might be launched
,
Jul 17 2017
,
Aug 11 2017
Is this really blocked by issue 744843 or is it the same thing? Should we just dup them? kbr/nekr.fabula: a CL just landed this morning so I'm interested to hear on reproducibility with the next canary (presumably tomorrow) and dev caught from trunk (I think possibly the next one)
,
Aug 11 2017
It's no blocking. I gonna submit a cl base on previous submitted one after.
,
Aug 11 2017
nevermind #14, the cl was changed along the way so it was just preparing for the fix. :S still one CL to go..
,
Aug 11 2017
That's OK. Please do ping this bug when the fix is in. I have been seeing this periodically, usually coinciding with long start times after tapping the notification, so may be able to confirm that it's reliably fixed within a few days.
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86578d527048a212767618e16ed461f80400ff8b commit 86578d527048a212767618e16ed461f80400ff8b Author: Ran Ji <ranj@chromium.org> Date: Mon Aug 14 16:16:02 2017 Fix not navigating to proper page when open from notifications in Twitter Clean saved state if open from notification, otherwise WebApk will return to previous opened page. Bug: 739927 Change-Id: Ic0c95a4a718aa137451f4bed5c7dd1fd9e4f3805 Reviewed-on: https://chromium-review.googlesource.com/612826 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#494064} [modify] https://crrev.com/86578d527048a212767618e16ed461f80400ff8b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
,
Aug 14 2017
Ok, stay tuned for next canary/dev (assuming it's 62) :)
,
Aug 15 2017
,
Aug 15 2017
Marking this as fixed. Please re-open it if the issue still occurs.
,
Aug 22 2017
Anecdotally I haven't seen this in latest dev push, curious if others are also seeing this behave better
,
Aug 23 2017
Haven't run it long enough personally to tell for sure.
,
Aug 23 2017
(I did see it happen again a couple of times last week before the fix above went to Dev.) |
||||
►
Sign in to add a comment |
||||
Comment 1 by pkotw...@chromium.org
, Jul 7 2017Status: Assigned (was: Untriaged)