[WPT Export] Exporter failing due to lack of account information |
||
Issue descriptionCloning GitHub w3c/web-platform-tests into /tmp/wpt Rejecting CL with over 1000 files: Delete non-SPInvalidation code paths. (ID: I80d51e7e4fd9f50a6fd53c630c2b95d546326265) Found Gerrit in-flight CL: "Use UTF-16 strings in the USB Mojo interface" https://chromium-review.googlesource.com/c/530036 In-flight PR found: https://github.com/w3c/web-platform-tests/pull/6476 New revision found, updating PR... Traceback (most recent call last): File "/b/rr/tmpWDgKxx/w/src/third_party/WebKit/Tools/Scripts/wpt-export", line 59, in <module> main() File "/b/rr/tmpWDgKxx/w/src/third_party/WebKit/Tools/Scripts/wpt-export", line 54, in main dry_run=args.dry_run File "/b/rr/tmpWDgKxx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 39, in run self.process_gerrit_cls(open_gerrit_cls) File "/b/rr/tmpWDgKxx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 75, in process_gerrit_cls self.create_or_update_pull_request_from_cl(cl, pull_request) File "/b/rr/tmpWDgKxx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 208, in create_or_update_pull_request_from_cl self.local_wpt.create_branch_with_patch(branch_name, message, patch, cl.owner_email, force_push=True) File "/b/rr/tmpWDgKxx/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py", line 80, in owner_email return self._data['owner']['email'] KeyError: 'email' step returned non-zero exit code: 1 Culprit is https://chromium-review.googlesource.com/c/559836/ which landed mid-day today PDT.
,
Jul 6 2017
https://crrev.com/c/559836 removed `&o=DETAILED_ACCOUNTS` from the Gerrit API query string, which was also relied upon by GerritCL.owner_email. I ran a manual export locally and I'm creating a CL for this.
,
Jul 6 2017
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51da2c60872af869b2a2aeaa42952943fa3872ad commit 51da2c60872af869b2a2aeaa42952943fa3872ad Author: Jeff Carpenter <jeffcarp@chromium.org> Date: Fri Jul 07 02:38:15 2017 [WPT Export] Add DETAILED_ACCOUNTS back to Gerrit API query string The flag was removed in https://crrev.com/c/559836, however it is relied upon by GerritCL.owner_email. Bug: 739924 Change-Id: Ib244ce2c111da8270ca9cbb6a452d3fb00e02f6d TBR: qyearsley@chromium.org Reviewed-on: https://chromium-review.googlesource.com/562661 Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#484806} [modify] https://crrev.com/51da2c60872af869b2a2aeaa42952943fa3872ad/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py
,
Jul 7 2017
Now the exporter is encountering another exception due to the new WPTGitHub.remove_label: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-exporter%2F26569%2F%2B%2Frecipes%2Fsteps%2FExport_Chromium_commits_and_in-flight_CLs_to_WPT%2F0%2Fstdout I think GitHub will return a 400 if you try to remove a label that doesn't exist, which locally is thrown as a urllib2.HTTPError. I'm running the exporter on a 10 minute loop on my workstation in the meantime.
,
Jul 7 2017
Makes sense, thanks for looking into this Jeff -- I just filed a separate bug for that error: bug 740176 . Meanwhile, the original issue here (not having owner email) is now fixed, right?
,
Jul 7 2017
Yes, running the exporter locally from the master branch passes (until it hits bug 740176 ). |
||
►
Sign in to add a comment |
||
Comment 1 by jeffcarp@chromium.org
, Jul 6 2017