New issue
Advanced search Search tips

Issue 739922 link

Starred by 3 users
Status: Duplicate
Merged: issue gerrit:6441
Owner: ----
Closed: Jul 2017
Cc:
primiano@chromium.org
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Gerrit: git cl upload --find-copies doesn't work

Project Member Reported by rsesek@chromium.org, Jul 6 2017 
Chrome Version: depot_tools bc9c5ccf00e8e3d3e2937d49ddbc02818f80c351
OS: macOS 10.12.5

What steps will reproduce the problem?
(1) Copy a file from one location to another
(2) Add it to a CL
(3) `git cl upload --find-copies`

What is the expected result?
Expect that Gerrit correctly identifies the copy.

What happens instead?
It doesn't. Only renames with default similarity seem to be detected.

Please use labels and text to provide additional information.
I tried this on the following CL: https://chromium-review.googlesource.com/c/562776/

PS 1: Copied sandbox_bpf_base_policy_android.cc to baseline_policy_android.cc, `git cl upload` without options, not detected as copy
PS 2: `git cl upload --find-copies`, not detected as copy
PS 4: Change the file copy to a move, uploaded without options, detected properly as rename

It seems that copy detection doesn't work, but automatic rename detection does.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by primiano@chromium.org, Jul 7 2017

Cc: primiano@chromium.org aga...@chromium.org
AFAIK --find-copies won't make any difference anymore. It made a difference in rietveld as we were sending the diff from the client there.
But here we are just sending the blobs and the diff happens server side.
What is missing here IMHO is a way to configure (and change) the copy-detection threashold server side.
I find gerrit seriously regressed in terms of diff-algorithm smartness and end up more and more having to fetch the CL locally and use kdiff to review CLs.

Comment 2 by aga...@chromium.org, Jul 7 2017

Mergedinto: gerrit:6441
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment