New issue
Advanced search Search tips

Issue 739921 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: device emulation code is too involved.

Project Member Reported by pfeldman@chromium.org, Jul 6 2017

Issue description

We have several layers of no-trivial logic in the emulation pipeline, need to bring some sense into it.

Some anecdotal findings: emulation_params_.view_size == params.view_size check in DevToolsEmulator exists by accident, just because we pass 0 there. Not that it is important, but definitely misleading.

We also store old values in all 3 layers and also modify those values from layer to layer (dsf is always from host on the renderer side).

We need a model where setDeviceMetricsOverride is playing nicely with the setVisibleSize, etc.

This can wait :)
 
GetMemoryCache()->EvictResources() is also never called - DevToolsEmulator only gets host device scale factor...
Status: Archived (was: Assigned)

Sign in to add a comment