New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739898 link

Starred by 4 users
Status: Available
Owner: ----
Cc:
sadrul@chromium.org
thestig@chromium.org
thomasanderson@chromium.org
mmanchala@chromium.org
varkha@chromium.org
█ timbrown@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 634084


Sign in to add a comment

Reduce the number of slow Xlib calls on browser UI thread

Project Member Reported by kylec...@chromium.org, Jul 6 2017 
There are a number of Xlib calls on the UI thread that are sometimes super slow. This ends up increasing the queuing delay for other tasks, including compositor tasks, and might result in jank.

I've identified a few areas from a tracing run of creating and destroying a new XWindow by dragging a tab into a new window and then back into the original window.

XTranslateCoordinates took up to 30ms:
https://cs.chromium.org/chromium/src/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc?type=cs&sq=package:chromium&l=2011

XQueryPointer took up to 10ms:
https://cs.chromium.org/chromium/src/ui/views/widget/desktop_aura/desktop_screen_x11.cc?type=cs&l=145

ui::IsWindowVisible() took up to 45ms:
https://cs.chromium.org/chromium/src/ui/base/x/x11_util.cc?type=cs&sq=package:chromium&l=502

Comment 1 by sadrul@chromium.org, Jul 6 2017

Cc: thestig@chromium.org thomasanderson@chromium.org varkha@chromium.org
/cc+ a few more folks.

Thanks for filing the bug! Just to be sure: what window-manager are you on?

I suspect we are doing the XTranslateCoordinates for window-resizes too? And considering window-resize with a mouse can trigger a lot of configure events, this is likely fairly expensive!

Comment 2 by kylec...@chromium.org, Jul 6 2017 

I'm using Cinnamon.

Comment 3 by thestig@chromium.org, Jul 6 2017

Cc: timbrown@chromium.org
Need more people with user names that start with the letter 't'.

Comment 4 by thomasanderson@chromium.org, Jul 11 2017

Blockedon: 634084
I have an old open CL that adds an X11 window cache that could be used to solve this issue https://codereview.chromium.org/2177823002/

Just a matter of actually getting around to landing it :)
If anyone wants to volunteer, please go ahead!
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mmanchala@chromium.org, Nov 22

Cc: mmanchala@chromium.org
Labels: Hotlist-DesktopUIChecked
Status: WontFix (was: Untriaged)
*** UI Mass Triage *** 

Closing, since there is no updates since the past few weeks. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue.

Thanks..!!

Comment 7 by thomasanderson@chromium.org, Nov 22

Status: Available (was: WontFix)
►

Sign in to add a comment