New issue
Advanced search Search tips

Issue 739896 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Initialize TaskScheduler in cronet

Project Member Reported by eroman@chromium.org, Jul 6 2017

Issue description

//net code is already using the TaskScheduler, and likely to keep growing more such dependencies. Right now reaching those dependencies on cronet will result in a crash. (Prohibiting the TaskScheduler in //net code does not seem like the correct path forward).

The iOS build of cronet is already initializing (albeit not shutting it down) the TaskScheduler, due to a dependency introduced a while ago.

There are concerns with enabling TaskScheduler for cronet:

  * Is initialization/teardown process-wide? Cronet is a library and could in theory be loaded with other libraries that use a TaskScheduler.

  * Tune down the number of threads used. The default thread provisioning seems heavy-weight for cronet's purposes. A more appropriate policy might be to limit to 1-2 extra threads total, created lazily, and reclaimed shortly after becoming idle.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e3c14af2dcee49b2ed00dc9960f474b7d69f7ac

commit 3e3c14af2dcee49b2ed00dc9960f474b7d69f7ac
Author: Eric Roman <eroman@chromium.org>
Date: Fri Jul 07 21:49:10 2017

Initialize TaskScheduler on cronet.

BUG= 739896 

Change-Id: Ia15bd6da393cbc4b0ad35ad727fa73bcd850b988
Reviewed-on: https://chromium-review.googlesource.com/562562
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485061}
[modify] https://crrev.com/3e3c14af2dcee49b2ed00dc9960f474b7d69f7ac/components/cronet/android/cronet_library_loader.cc

Status: Fixed (was: Untriaged)
Owner: eroman@chromium.org

Sign in to add a comment