New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739870 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

chrome only autofill last password on accounts.google.com

Reported by taligah...@gmail.com, Jul 6 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.50 Safari/537.36

Steps to reproduce the problem:
1. Have multiple accounts added to accounts.google.com screen
2. Click on first account, and when the password is not auto filled just pick it with the picker. Proceed with the login.
3. Logout and try to login another account. The password field will won't populate auto filled password. Pick it with the picker and proceed with the login.
4. Logout and login with previous account (from step 1) the password will be auto filled.
5. Logout and try any other account the password will not be auto filled.

What is the expected behavior?
The autofill mechanism should work as it did in v58

What went wrong?
https://bugs.chromium.org/p/chromium/issues/detail?id=723679 

This change must have something to do with this problem.

Did this work before? Yes V58

Chrome version: 60.0.3112.50  Channel: beta
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

It would be nice to have a QA team to test basic features before slipping any change to public versions
 
Update. The reproduce steps were invalid, read correction below:

1. Have multiple accounts added to accounts.google.com screen
2. Click on first account, and when the password is not auto filled just pick it with the picker. Proceed with the login.
3. Logout and try to login another account. The password field will won't populate auto filled password. Do not proceed, just go back to previous screen.
4. Click on first account (from step 1) the password will be auto filled.
5. Go back to previous screen and select another account. The password will not be auto filled.
6. Extra step is to close browser. Open again, and navigate to accounts.google.com. The first account's password (from step 1) will be auto filled but not any other accounts.

Comment 2 by b...@chromium.org, Jul 7 2017

Components: -UI UI>Browser>Passwords
Labels: Needs-Triage-M60 Needs-Bisect

Comment 4 by ajha@chromium.org, Jul 12 2017

Cc: ajha@chromium.org
Labels: -Needs-Triage-M60 M-61 Needs-Feedback OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
I am able to reproduce the behavior on the latest canary(61.0.3155.0) of Windows-10,Mac OS 10.12.5 and Linux Ubuntu 14.04, as well as the reported version:60.0.3112.50. Doesn't seem to be regression as similar behavior is observed on the 58.0.3029.110 and as shown in the attached screen-cast.

taligahack@: Could you please review the attached screen-cast and confirm if anything being missed here.

Note: On older chrome version: 45.0.2454.101 there is no autofill doesn't populate on clicking inside the password field.
739870.mp4
2.4 MB View Download
Thank you for looking into this issue.

The reproduction steps are valid however your results are not. As you may noticed, on your screencast once you click on login chrome will ask you to save the password AGAIN, however the existing autofill record suggests the password should be saved already, which means you probably have a broken or invalid chrome profile running in the screencast (thus you were managed to produce a similar but different bug which was not present for me in v58 64bit), therefore your reproduction is not quite valid according this issue.

As for proving my point i have managed to record a V58 behavior and the following video will show you the expected behavior of autofill which is no longer available in V60 64.

Please delete my video after confirmation, just for security reasons.
Upon second review your screencast i did noticed that you are not resaving an existing password record but it will be an inconsistency in the way accounts.google handles account names, since your record was saved without the gmail.com domain tag while your login will save it as a new record with the domain post tag. That's irrelevant then, so you can dismiss that part of my previous message.

This however does not provide enough information to see why your v58 is unable to autofill the records whereas the build running on my computer is doing it just fine (and previous versions down to v4x were able to fill up the fields all the time) - except maybe an inconsistent behavior between 32bit/64bit versions so it would seem, tho i cannot verify this on my side.

The broken autofill feature have had many issues on previous chrome versions as well (i am in fact posted similar issues before), and it is keep bugging out on new versions too which has grow way beyond my understanding at this point.

This feature must be rigorously reviewed and fixed permanently and properly, weld the codebase shut and never touch it again - unless security reasons would make it absolutely necessary.
Labels: -Needs-Feedback Needs-Triage-M61
Team, please re-triage.

Comment 8 by ajha@chromium.org, Aug 2 2017

Labels: -Pri-2 -Needs-Bisect -M-61 hasbisect-per-revision ReleaseBlock-Stable M-62 Pri-1
Owner: dvadym@chromium.org
Status: Assigned (was: Untriaged)
Thanks for the clarification in C#5 and C#6.

I am able to reproduce the scenario as per the below test steps:

1. Go to accounts.google.com, enter username1@gmail.com and password. Save the password and log out.
2. Click on 'User another account' and start entering username2@gmail.com and save the password and log out.
3. Now click on either of the account and observe that password is not autofilled in first profile.

Observation: C#4 didn't work and couldn't get the regression as record was being saved without the gmail.com domain tag.

Issue is reproducible on the latest canary(62.0.3174.0) and the latest stable(60.0.3112.78) of Windows-10, Mac OS 10.12.5 and Linux Ubuntu 14.04. 

This has regressed in M-59.

Last good build: 59.0.3040.0
First bad build: 59.0.3041.0

Changelog:
==========
https://chromium.googlesource.com/chromium/src/+log/19e4c274dd7efd8731cceb5f0c0ac0a2860ea064..bb38ea3085965823c24ac636a2d560631448c18d

dvadym@: Could you please take a look at this.

Thank you!

Comment 9 Deleted

Status: Assigned (was: Fixed)
Your bug is tagged as Release block Stable. 

M62 is branching soon and We will be taking only CRITICAL merges. Please plan accordingly.

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e2e8d1b7ed48de0c8ddc096e9daa8c5750f470b

commit 4e2e8d1b7ed48de0c8ddc096e9daa8c5750f470b
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Tue Aug 22 18:39:10 2017

[Password Manager] Fix filling when username is given on page.

On CL https://codereview.chromium.org/2736393003/ it was introduced clearing of passwords except of preferred match before sending to renderer. But in case when the username is given on a page (for example like on account.google.com) not a preferred match but a match that corresponds to the given username should be autofilled. This CL leaves clearing of passwords only in case when passwords should be filled on account select.

Bug:  739870 
Change-Id: Id2571c959588c537d9399df1f5c964e4d7c5c2ef
Reviewed-on: https://chromium-review.googlesource.com/626060
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496382}
[modify] https://crrev.com/4e2e8d1b7ed48de0c8ddc096e9daa8c5750f470b/chrome/browser/password_manager/password_manager_browsertest.cc
[add] https://crrev.com/4e2e8d1b7ed48de0c8ddc096e9daa8c5750f470b/chrome/test/data/password/hidden_username.html
[modify] https://crrev.com/4e2e8d1b7ed48de0c8ddc096e9daa8c5750f470b/components/autofill/core/common/password_form_fill_data.cc
[modify] https://crrev.com/4e2e8d1b7ed48de0c8ddc096e9daa8c5750f470b/components/password_manager/content/browser/content_password_manager_driver_unittest.cc

Labels: -hasbisect-per-revision -Needs-Triage-M61 Merge-Request-62
Project Member

Comment 14 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: We don't branch M62 until 2017-08-31.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62
M62 is not branched yet.
Status: Fixed (was: Assigned)
Cc: jmukthavaram@chromium.org hdodda@chromium.org dvadym@chromium.org ligim...@chromium.org
 Issue 762447  has been merged into this issue.

Sign in to add a comment