New issue
Advanced search Search tips

Issue 739864 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Make "Useful links" more structured

Project Member Reported by zhangtiff@chromium.org, Jul 6 2017

Issue description

Screenshot example: https://screenshot.googleplex.com/7MEPJ7cpCgR.png 

It seems most of the time the "Useful Links" field in Sheriff-o-Matic mostly contains a long list of links to information on timed out shards. 

This is probably a bit stressful for sheriffs to look through and make sense of. I think it might be a good idea to somehow coalesce the main types of useful links that are shown to the user and surface them on the UI in a more structured way. 
 
Owner: ----
Status: Available (was: Assigned)
Cc: scheib@chromium.org
 Issue 772962  has been merged into this issue.
Useful context from the merged bug: "We currently show a list of links that were attached to the build by the recipe output.  They have labels like "shard #0 (failed)" vs "shard #9" - we should highlight the failure links or otherwise make them more prominent in the "Useful links" section."
 Issue 778393  has been merged into this issue.
Owner: seanmccullough@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d5d1b7e2e24dc7cf961b68c2480617326cbc0091

commit d5d1b7e2e24dc7cf961b68c2480617326cbc0091
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Dec 12 18:56:18 2017

[som] Separate alert links into "Useful" and less prominent "All"

This currently just looks for "(failed)" in the link title.

Bug:  739864 
Change-Id: I6ef191bfb1f68f762056b1e0745da255d30df2b3
Reviewed-on: https://chromium-review.googlesource.com/818626
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/d5d1b7e2e24dc7cf961b68c2480617326cbc0091/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/d5d1b7e2e24dc7cf961b68c2480617326cbc0091/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js

Comment 7 by scheib@chromium.org, Dec 12 2017

Cc: -scheib@chromium.org
Status: Fixed (was: Started)
this is now live on prod

Sign in to add a comment