Figure out how to persist opaque setting in WebLayer for video |
|||||
Issue descriptionWhen using a WebLayerImpl, the WebMediaPlayerImpl sets SetContentsOpaqueIsFixed; However, when switching to use a SurfaceLayer instead of a VideoLayer, we have changed to using a WebLayer object. The only function not included that cannot be trivially worked around is the SetContentsOpaqueIsFixed. There should be something done about it not being set.
,
Jul 19 2017
,
Jul 19 2017
,
Sep 9 2017
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f04c41c0514e8dc7fdb5b21fd43f68d6cd459d2c commit f04c41c0514e8dc7fdb5b21fd43f68d6cd459d2c Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Thu Sep 14 01:21:08 2017 Persists Opaque Setting in WebLayer for video BUG= 739859 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8b21a1920755f9f61974b958f7498bfba6917371 Reviewed-on: https://chromium-review.googlesource.com/657303 Reviewed-by: enne <enne@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#501827} [modify] https://crrev.com/f04c41c0514e8dc7fdb5b21fd43f68d6cd459d2c/cc/blink/web_layer_impl.h [modify] https://crrev.com/f04c41c0514e8dc7fdb5b21fd43f68d6cd459d2c/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/f04c41c0514e8dc7fdb5b21fd43f68d6cd459d2c/third_party/WebKit/public/platform/WebLayer.h
,
Sep 14 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by lethalantidote@chromium.org
, Jul 6 2017