New issue
Advanced search Search tips

Issue 739854 link

Starred by 5 users
Status: Fixed
Owner:
lethalantidote@chromium.org
Closed: Sep 2017
Cc:
liber...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 746182



Sign in to add a comment

Handle destruction of compositor for surface layer

Project Member Reported by lethalantidote@chromium.org, Jul 6 2017 
In WebMediaPlayerImpl's destructor, when using a VideoLayer, we call StopUsingProvider to make sure that we can safely destroy the VideoFrameProvider (|compositor_|). 

We will need to address this relationship once the class that will be pulling the frames from the VideoFrameProvider (to be implemented as VideoFrameSubmitter atm) is designed/implemented.

Comment 1 by lethalantidote@chromium.org, Jul 6 2017

Blocking: 726619

Comment 2 by lethalantidote@chromium.org, Jul 6 2017

Summary: Handle destruction of compositor for surface layer (was: Handle destruction of surface layer dependencies.)

Comment 3 by lethalantidote@chromium.org, Jul 19 2017

Blocking: -726619

Comment 4 by lethalantidote@chromium.org, Jul 19 2017

Blocking: 746182
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2302d2015a29612979ec1990f9dd8491a2b07f3e

commit 2302d2015a29612979ec1990f9dd8491a2b07f3e
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Aug 31 08:38:04 2017

Creates VideoFrameSubmitter.

This CL allows for a switch-enabled rerouting of VideoFrames into the
VideoFrameSubmitter, which commits frames to the CompositorFrameSink.
This allows video frames to be rendered onto a Surface.

BUG: 746182,  739854 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic4bd3f135e351c8a94c38524c69d5f59f296a0f3
Reviewed-on: https://chromium-review.googlesource.com/592398
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498788}
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/content/renderer/media/media_factory.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/content/renderer/media/media_factory.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/content/renderer/render_frame_impl.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/DEPS
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/video_frame_compositor.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/video_frame_compositor.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/CoreInitializer.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/exported/WebSurfaceLayerBridge.cpp
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/exported/WebVideoFrameSubmitter.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.h
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.h
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.h
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/public/platform/WebSurfaceLayerBridge.h
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/public/platform/WebVideoFrameSubmitter.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/public/web/WebFrameClient.h

Comment 6 by lethalantidote@chromium.org, Sep 8 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment