New issue
Advanced search Search tips

Issue 739850 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Feedback integration (V1)

Project Member Reported by yuweih@chromium.org, Jul 6 2017

Issue description

This bug tracks the feedback tool integration.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acdc0e5f4424a22fa186d5a31d3607df0221a6e3

commit acdc0e5f4424a22fa186d5a31d3607df0221a6e3
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Jul 06 22:26:16 2017

[CRD iOS] Add feedback support in Chromium

This CL adds the HelpAndFeedback class in Chromium and hook it up to the send
feedback button in the settings menu.

The official HelpAndFeedback implementation will be done in the internal repo
in a separate CL.

Bug:  739850 
Change-Id: Icc88fbab222ee3556e076f8378bcc0f3e89fc073
Reviewed-on: https://chromium-review.googlesource.com/562362
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484754}
[modify] https://crrev.com/acdc0e5f4424a22fa186d5a31d3607df0221a6e3/remoting/ios/app/BUILD.gn
[modify] https://crrev.com/acdc0e5f4424a22fa186d5a31d3607df0221a6e3/remoting/ios/app/app_delegate.h
[modify] https://crrev.com/acdc0e5f4424a22fa186d5a31d3607df0221a6e3/remoting/ios/app/app_delegate.mm
[add] https://crrev.com/acdc0e5f4424a22fa186d5a31d3607df0221a6e3/remoting/ios/app/help_and_feedback.h
[add] https://crrev.com/acdc0e5f4424a22fa186d5a31d3607df0221a6e3/remoting/ios/app/help_and_feedback.mm
[modify] https://crrev.com/acdc0e5f4424a22fa186d5a31d3607df0221a6e3/remoting/ios/app/main.mm
[modify] https://crrev.com/acdc0e5f4424a22fa186d5a31d3607df0221a6e3/remoting/ios/app/settings/remoting_settings_view_controller.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/dfa916fe31085301729c7e6686c254979070cd4d

commit dfa916fe31085301729c7e6686c254979070cd4d
Author: yuweih <yuweih@google.com>
Date: Fri Jul 07 21:32:12 2017

Comment 3 by yuweih@chromium.org, Oct 19 2017

Status: Fixed (was: Assigned)
Summary: [CRD iOS] Feedback integration (V1) (was: [CRD iOS] Feedback integration)
V2 UI integration has lower priority.

Sign in to add a comment