New issue
Advanced search Search tips

Issue 739844 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-02-01
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 546347
issue 787497



Sign in to add a comment

Use custom protocol handlers for WebUI

Project Member Reported by justincohen@chromium.org, Jul 6 2017

Issue description

Consider using custom protocol handlers for WebUI
 
Cc: kkhorimoto@chromium.org
Components: Mobile>WebView>Glue
Labels: Hotlist-iOS11
Owner: eugene...@chromium.org
Status: Assigned (was: ass)
Cc: -kkhorimoto@chromium.org michaeldo@chromium.org
Components: -Mobile>WebView>Glue UI>Browser>WebUI
Labels: -Type-Bug -Pri-2 Pri-3 Type-Task
Problem:
Chrome for iOS implements WebUI by fetching main html document and its subresources from net stack, flattening html and force feeding it to WKWebView. This approach uses simple html parser, regexps and large strings concatenation all because iOS 10 and lower does not support custom url protocols for WKWebView. Current solution works fine, but the code is quite complex 

Solution:
Starting from ios 11 WKWebView supports custom URL protocols via WKURLSchemeHandler API. There are no visible user benefits in using new API, and because Chrome has to support iOS10, there is no reason to switch. WKURLSchemeHandler works just fine as demonstrated in https://chromium-review.googlesource.com/c/566091/ and we should switch to use new API after dropping iOS 10.

Design doc:
https://docs.google.com/document/d/1vZFxG8ml2yKanIEzMEEosXJDGKfJRUDwlkz5qKkR1w8/edit#

 Issue 740772  has been merged into this issue.
Blocking: 546347
Cc: eugene...@chromium.org
NextAction: 2018-12-01
Owner: ----
Status: Available (was: Assigned)
Blocking: 787497
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 22

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Is this still blocking and needed?
Cc: gambard@chromium.org
Labels: -Restrict-View-Google
Owner: ----
Status: Available (was: Assigned)
Summary: Use custom protocol handlers for WebUI (was: Consider using custom protocol handlers for WebUI)
We still need this refactoring.
The NextAction date has arrived: 2018-12-01
NextAction: 2019-02-01
Owner: gambard@chromium.org
Status: Started (was: Available)

Sign in to add a comment