New issue
Advanced search Search tips

Issue 739840 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

Implement new snapshot API for WKWebView (use takeSnapshotWithConfiguration:)

Project Member Reported by justincohen@chromium.org, Jul 6 2017

Issue description

Labels: -Type-Bug Type-Task
Components: -UI>Browser>Core Mobile>WebView>Glue
Summary: Implement new snapshot API for WKWebView (use takeSnapshotWithConfiguration:) (was: Implement new snapshot API for WKWebView)
Labels: -M-62
Labels: -Pri-2 small Q2 Pri-0
Labels: -Restrict-View-Google
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 10 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-0 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37

commit 98e594cc7c552d45c0fa6fbfb7ae838ffc040d37
Author: edchin <edchin@chromium.org>
Date: Tue Sep 18 18:02:40 2018

[ios] Add experiment flag for WKWebView snapshotting

This CL simply adds the flag so that it can be used in
a future CL. This flag controls whether the WKWebView
snapshotting API is used to take snapshots for web pages
(not native pages) on iOS 11+.

The crbug to remove the flag is crbug.com/885003.

Bug:  739840 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id00c4da93f5046e4a2b2af179abe3794a99a248e
Reviewed-on: https://chromium-review.googlesource.com/1229703
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592108}
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/app/tests_fake_hook.mm
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/app/tests_hook.h
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/ui/tab_grid/tab_grid_egtests_hook.mm
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_eg_tests_hook.mm
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/ui/ui_feature_flags.cc
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/ui/ui_feature_flags.h
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/98e594cc7c552d45c0fa6fbfb7ae838ffc040d37/ios/chrome/test/earl_grey/eg_tests_hook.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff791da796f659a39bf89fdce5b93f73d84f8e51

commit ff791da796f659a39bf89fdce5b93f73d84f8e51
Author: edchin <edchin@chromium.org>
Date: Wed Sep 19 00:04:59 2018

[ios] Support WKWebView snapshotting API in web

Implements the snapshotting API for WKWebView for iOS 11+.

Bug:  739840 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1fbd39337c978f5d10773d91a0af3f7cd50b0b35
Reviewed-on: https://chromium-review.googlesource.com/1231820
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592273}
[modify] https://crrev.com/ff791da796f659a39bf89fdce5b93f73d84f8e51/ios/web/public/test/fakes/test_web_state.h
[modify] https://crrev.com/ff791da796f659a39bf89fdce5b93f73d84f8e51/ios/web/public/test/fakes/test_web_state.mm
[modify] https://crrev.com/ff791da796f659a39bf89fdce5b93f73d84f8e51/ios/web/public/web_state/web_state.h
[modify] https://crrev.com/ff791da796f659a39bf89fdce5b93f73d84f8e51/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/ff791da796f659a39bf89fdce5b93f73d84f8e51/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/ff791da796f659a39bf89fdce5b93f73d84f8e51/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/ff791da796f659a39bf89fdce5b93f73d84f8e51/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/ff791da796f659a39bf89fdce5b93f73d84f8e51/ios/web/web_state/web_state_unittest.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c7741d254584fa8d4c0924a69ba0398d0bbdb47

commit 6c7741d254584fa8d4c0924a69ba0398d0bbdb47
Author: edchin <edchin@chromium.org>
Date: Wed Sep 19 16:40:35 2018

[ios] Refactor SnapshotCacheObserver, add test, and add to TabGridMediator

This CL:
1) Notifies observers when the SnapshotCache removes a snapshot.
This approach gives symmetry since observers are notified when a
snapshot is added.
2) Adds a unittest for notifying observers on setting and removing
a snapshot.
3) Adds TabGridMediator as an observer.

Bug:  739840 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib6fa854670537a1d225f92adbc51a361a1714623
Reviewed-on: https://chromium-review.googlesource.com/1231897
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592439}
[modify] https://crrev.com/6c7741d254584fa8d4c0924a69ba0398d0bbdb47/ios/chrome/browser/snapshots/snapshot_cache.mm
[modify] https://crrev.com/6c7741d254584fa8d4c0924a69ba0398d0bbdb47/ios/chrome/browser/snapshots/snapshot_cache_observer.h
[modify] https://crrev.com/6c7741d254584fa8d4c0924a69ba0398d0bbdb47/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
[modify] https://crrev.com/6c7741d254584fa8d4c0924a69ba0398d0bbdb47/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/716114301facb965707db82df94a6433a21b2969

commit 716114301facb965707db82df94a6433a21b2969
Author: edchin <edchin@chromium.org>
Date: Tue Sep 25 19:31:34 2018

[ios] Update snapshotting to use WKWebView API

This CL creates a codepath that utilizes the WKWebView snapshotting
API when IsWKWebViewSnapshotsEnabled() is true. This CL intentionally
keeps the original codepath intact so as to minimize the risk of
refactoring errors.

Bug:  739840 , 869256,  711455 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I80324e82573851b1a62cda75242679cf59008c3e
Reviewed-on: https://chromium-review.googlesource.com/1235714
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594055}
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/BUILD.gn
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/snapshot_generator.h
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/snapshot_generator.mm
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/snapshot_tab_helper.h
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/snapshot_tab_helper.mm

Status: Fixed (was: Started)

Sign in to add a comment