New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739815 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Media Remoting: Disable viewport intersection monitoring when controlled by enter/exit fullscreen.

Project Member Reported by x...@chromium.org, Jul 6 2017

Issue description

When media remoting is triggered by video entering/exiting fullscreen, disable the viewport intersection monitor to avoid racing that might cause a remoting session immediately starts/stops after exiting fullscreen.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92ec9bd3c7863410f457d03aa741f999bf3f224

commit c92ec9bd3c7863410f457d03aa741f999bf3f224
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Tue Jul 25 21:56:42 2017

Remove the viewport fill debouncer timer.

This CL removed the viewport fill debouncer timer and added a delayed 
start mechanism to monitor that all requirements are met and held 
stable for a short period of time before switching to media remoting. 
The content bitrate will also be estimated and evaluated in this period
in an incoming change. 

Also stopped using fullscreen status in the remoting switching logic to
avoid conflict and racing between fullscreen status change and dominant
status change.

Bug:  739815 ,  739972 
Change-Id: I924d8fbdce7dddd2f1f334aeacae4cdc2b58c455
Reviewed-on: https://chromium-review.googlesource.com/571238
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489455}
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/base/media_observer.h
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/remoting/renderer_controller.cc
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/remoting/renderer_controller.h
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/media/remoting/renderer_controller_unittest.cc
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/c92ec9bd3c7863410f457d03aa741f999bf3f224/third_party/WebKit/Source/core/html/MediaElementFillingViewportTest.cpp

Comment 2 by x...@chromium.org, Jul 25 2017

Status: Fixed (was: Started)

Sign in to add a comment