[Payments] For some locales, currency formatting is unexpected |
||||
Issue description1. Set phone to English (Australia) 2. go to https://rsolomakhin.github.io/pr Expected USD $55.00 Actual USD 55.00
,
Jul 6 2017
Good find!
,
Jul 6 2017
,
Jul 6 2017
Did we strip the "$" overzealously in https://cs.chromium.org/chromium/src/components/payments/core/currency_formatter.cc?rcl=9da63a8364a4cdec18db79b537ac819d29dd4284&l=107 or is it actually absent? If latter, then this is WontFix.
,
Jul 6 2017
Guessing the latter, but I want to understand why ICU would do this by testing a few locales first.
,
Sep 21 2017
The ICU data is explicitely dictating to strip the currency symbol of quite a few currencies in the en_AU locale: https://cs.chromium.org/chromium/src/third_party/icu/source/data/curr/en_AU.txt?type=cs
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53d37500e78aa4a089696e429bd11a77530c7b30 commit 53d37500e78aa4a089696e429bd11a77530c7b30 Author: Mathieu Perreault <mathp@chromium.org> Date: Thu Sep 21 16:26:08 2017 [Payments] Document some oddities about currency formatting in en_AU Bug: 739812 Test: components_unittests Change-Id: Ie833a4450adc0872cba139b90db1f51df67be37e Reviewed-on: https://chromium-review.googlesource.com/676661 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#503465} [modify] https://crrev.com/53d37500e78aa4a089696e429bd11a77530c7b30/components/payments/core/currency_formatter_unittest.cc
,
Sep 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ma...@chromium.org
, Jul 6 2017