DCHECK hit upon launch of iOS showcase app. |
||
Issue descriptionA DCHECK is hit upon launch of the iOS showcase app. This DCHECK was introduced in CL: https://chromium-review.googlesource.com/c/558977/ The DCHECK log: FATAL:service_manager_context.mm(59)] Check failed: !contents.empty(). Note that none of the showcase egtests caught this error (that bug is tracked separately in Issue 739808 )
,
Jul 7 2017
https://chromium-review.googlesource.com/c/562759/ out for review.
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1295f7b381ba68280d4143cc638f3928e4128d72 commit 1295f7b381ba68280d4143cc638f3928e4128d72 Author: Colin Blundell <blundell@chromium.org> Date: Fri Jul 07 09:23:45 2017 [iOS] Pack resources in Showcase app The Showcase app is a web embedder and hence should pack web resources. A previous CL had made the same change for the Showcase Earl Grey tests app, but at that time I had failed to realize that the Showcase app was a different beast. TEST=Possible to start Showcase app in debug mode :). Bug: 739811 Change-Id: If82f106ba0bc04b9a93fd17e217b985d69eb8f47 Reviewed-on: https://chromium-review.googlesource.com/562759 Commit-Queue: Colin Blundell <blundell@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#484866} [modify] https://crrev.com/1295f7b381ba68280d4143cc638f3928e4128d72/ios/showcase/BUILD.gn
,
Jul 7 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by blundell@chromium.org
, Jul 7 2017