If importer has some failing builds but no expectations need to be updated, it aborts. |
||
Issue descriptionIn auto-import: https://chromium-review.googlesource.com/c/561596/ And manual import: https://chromium-review.googlesource.com/c/561917/ The importer logged: Waiting. 5680 seconds passed. Adding test expectations lines to LayoutTests/TestExpectations. All jobs finished. No results for build Build(builder_name=u'android_blink_rel', build_number=2856) Tests to rebaseline: Lines to write to TestExpectations: # ret> 1 # out> On branch update_wpt # out> Your branch is ahead of 'origin/master' by 1 commit. # out> (use "git push" to publish your local commits) # out> nothing to commit, working tree clean step returned non-zero exit code: 1 This is because in TestImporter we have: if try_results and self.git_cl.has_failing_try_results(try_results): self.fetch_new_expectations_and_baselines() message = 'Update test expectations and baselines.' self.check_run(['git', 'commit', '-a', '-m', message]) self._upload_patchset(message) (An exception is raised in check_run if there's nothing to commit) Commit/upload should only be done if there are changes.
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d19e2e4529deb467950928a150b0f494047673f commit 9d19e2e4529deb467950928a150b0f494047673f Author: Quinten Yearsley <qyearsley@google.com> Date: Thu Jul 06 23:36:47 2017 Only upload second patchset if there were new expectations. Currently, the importer does this: 1. Copy new files 2. Upload initial CL 3. Run try jobs 4. If there were any failures, try to fetch baselines and expectations 5. Assume that there were changes and try to upload second patchset This changes step 5 so if there were no changes, the second patchset is skipped and we continue on with CQ. Bug: 739810 Change-Id: Id8d541bd20d326ee94c0a5b1bbafde3a8a02f333 Reviewed-on: https://chromium-review.googlesource.com/562498 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#484768} [modify] https://crrev.com/9d19e2e4529deb467950928a150b0f494047673f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
,
Jul 7 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Jul 6 2017