Public Session: Keyboard options displayed for English(United States) contains invalid values. |
||||||||||||
Issue descriptionEnroll Device.Enable PS.Select language as English(United States and see options in select your keyboard. Peppy M ChromeOS Chrome ARC Type Channel 61 9718.0.0 61.0.3150.0 (multiple) release dev Keyboard options displayed for English(United States) contains invalid values.
,
Jul 7 2017
,
Jul 7 2017
Hi Trapti, I assume it is a bug ONLY in M61? Ivan, why did we make it Pri-3?
,
Jul 7 2017
This could be related to the Login Refresh initiative.
,
Jul 7 2017
Yes it's only in M61.Checked in M60, values look fine.
,
Jul 7 2017
It shouldn't be related to new login refresh. Can you check if the issue is still there after adding --show-non-md-login in chrome.conf?
,
Jul 7 2017
This looks horrible - why is this P3?
,
Jul 7 2017
It's not related to login refresh.Even after adding flags,these invalid values exist.
,
Jul 26 2017
Is there any update on this?
,
Jul 26 2017
,
Jul 27 2017
Took a stab at it today. This is what the log says: [3986:3986:0727/163835.223010:ERROR:input_method_util.cc(432)] Resource ID is not found for: _comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:intl_pc:eng, xkb:us:intl_pc:eng Searching git history for "intl_pc" came up with https://codereview.chromium.org/2942423002 [Adds us(intl_pc) IME to xkb extension]. I don't see the wrong string with a checkout one commit before that one, and I do see it at that one so I guess that is the culprit. I don't have any good ideas about what went wrong at this point, but I'll continue investigating. Maybe we can CC someone on the bug that is better versed in this area?
,
Jul 27 2017
Actually got a fix up https://chromium-review.googlesource.com/c/590227/
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34836cc78e7eb47c4f0fe708fe369171181184f8 commit 34836cc78e7eb47c4f0fe708fe369171181184f8 Author: Ivan Sandrk <isandrk@google.com> Date: Fri Jul 28 11:02:32 2017 US International (PC) Keyboard layout was missing resourceId Symbol xkb:us:intl_pc:eng wasn't being properly decoded and was being displayed as something like the following in UI elements: _comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:intl_pc:eng See linked bug for more info Bug: 739809 Change-Id: I95f20736b2de39cb86db956dc582d8a8bdf3b9bb Reviewed-on: https://chromium-review.googlesource.com/590227 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#490356} [modify] https://crrev.com/34836cc78e7eb47c4f0fe708fe369171181184f8/ui/base/ime/chromeos/input_method_util.cc [modify] https://crrev.com/34836cc78e7eb47c4f0fe708fe369171181184f8/ui/chromeos/ui_chromeos_strings.grd
,
Jul 28 2017
,
Jul 28 2017
Approving merge to M61 Chrome OS.
,
Aug 1 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/473178198f08e9071cfa76a74c9fc5cd53269890 commit 473178198f08e9071cfa76a74c9fc5cd53269890 Author: Ivan Sandrk <isandrk@google.com> Date: Thu Aug 03 10:36:46 2017 [Merge to M61] US International (PC) Keyboard layout was missing resourceId Symbol xkb:us:intl_pc:eng wasn't being properly decoded and was being displayed as something like the following in UI elements: _comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:intl_pc:eng See linked bug for more info TBR=isandrk@google.com (cherry picked from commit 34836cc78e7eb47c4f0fe708fe369171181184f8) Bug: 739809 Change-Id: I95f20736b2de39cb86db956dc582d8a8bdf3b9bb Reviewed-on: https://chromium-review.googlesource.com/590227 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490356} Reviewed-on: https://chromium-review.googlesource.com/599948 Cr-Commit-Position: refs/branch-heads/3112@{#704} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [add] https://crrev.com/473178198f08e9071cfa76a74c9fc5cd53269890/ui/base/ime/chromeos/input_method_util.cc [modify] https://crrev.com/473178198f08e9071cfa76a74c9fc5cd53269890/ui/chromeos/ui_chromeos_strings.grd
,
Aug 3 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42b2104cd67a4234ee9b8424342b75103a9caf60 commit 42b2104cd67a4234ee9b8424342b75103a9caf60 Author: Ivan Šandrk <isandrk@chromium.org> Date: Fri Aug 04 11:04:39 2017 Revert "[Merge to M61] US International (PC) Keyboard layout was missing resourceId" This reverts commit 473178198f08e9071cfa76a74c9fc5cd53269890. Reason for revert: Merged to the wrong branch number (M60 instead of M61). Original change's description: > [Merge to M61] US International (PC) Keyboard layout was missing resourceId > > Symbol xkb:us:intl_pc:eng wasn't being properly decoded and was being displayed as something like the following in UI elements: > _comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:intl_pc:eng > > See linked bug for more info > > TBR=isandrk@google.com > > (cherry picked from commit 34836cc78e7eb47c4f0fe708fe369171181184f8) > > Bug: 739809 > Change-Id: I95f20736b2de39cb86db956dc582d8a8bdf3b9bb > Reviewed-on: https://chromium-review.googlesource.com/590227 > Reviewed-by: Ivan Šandrk <isandrk@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Commit-Queue: Ivan Šandrk <isandrk@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#490356} > Reviewed-on: https://chromium-review.googlesource.com/599948 > Cr-Commit-Position: refs/branch-heads/3112@{#704} > Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} TBR=stevenjb@chromium.org,shuchen@chromium.org,isandrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 739809 Change-Id: I38e0912b06a472c89f6957619c6828b19a7fbe0c Reviewed-on: https://chromium-review.googlesource.com/601991 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#708} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [delete] https://crrev.com/5a58c883b09d478f9f798258dc027837c0ccaa12/ui/base/ime/chromeos/input_method_util.cc [modify] https://crrev.com/42b2104cd67a4234ee9b8424342b75103a9caf60/ui/chromeos/ui_chromeos_strings.grd
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b06d3d7c6578d285214b411ee36fe61b3aaefaa5 commit b06d3d7c6578d285214b411ee36fe61b3aaefaa5 Author: Ivan Sandrk <isandrk@google.com> Date: Fri Aug 04 11:07:39 2017 [Merge to M61] US International (PC) Keyboard layout was missing resourceId Symbol xkb:us:intl_pc:eng wasn't being properly decoded and was being displayed as something like the following in UI elements: _comp_ime_jkghodnilhceideoidjikpgommlajknkxkb:us:intl_pc:eng See linked bug for more info TBR=isandrk@google.com (cherry picked from commit 34836cc78e7eb47c4f0fe708fe369171181184f8) Bug: 739809 Change-Id: I95f20736b2de39cb86db956dc582d8a8bdf3b9bb Reviewed-on: https://chromium-review.googlesource.com/590227 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490356} Reviewed-on: https://chromium-review.googlesource.com/601972 Cr-Commit-Position: refs/branch-heads/3163@{#310} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/b06d3d7c6578d285214b411ee36fe61b3aaefaa5/ui/base/ime/chromeos/input_method_util.cc [modify] https://crrev.com/b06d3d7c6578d285214b411ee36fe61b3aaefaa5/ui/chromeos/ui_chromeos_strings.grd
,
Aug 16 2017
Verified in Candy Device.Keyboard options displayed for English(United States) contains only valid values. M ChromeOS Chrome ARC Type Channel 61 9765.29.0 61.0.3163.47 (multiple) release dev |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by trapti@chromium.org
, Jul 6 2017