iframe.sandbox.supports() does not recognize 3 tokens that are actually supported |
|||||
Issue descriptionDOMTokenList validator for the sandbox attribute (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTMLIFrameElementSandbox.cpp) is missing allow-orientation-lock, allow-presentation, and allow-top-navigation-by-user-activation. They are not recognized by iframe.sandbox.supports() but are actually supported. Is there a reason behind it? Thanks
,
Apr 9 2018
Do you have any updates for this?
I faced issue that iframe.sandbox.supports('allow-top-navigation-by-user-activation') returns false. It is bad behavior.
,
Apr 10 2018
I found commit to fix https://chromium.googlesource.com/chromium/src/+/aa16224b6dd03cf35c5167cc5a2ce11b533b63b1 and works on current Beta. Thanks
,
Apr 10 2018
Thanks -- it looks like the other two are still missing; those should get fixed.
,
Apr 10 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/763d8cc7561615b7c3f7bdea8de2d4521c104781 commit 763d8cc7561615b7c3f7bdea8de2d4521c104781 Author: Ian Clelland <iclelland@chromium.org> Date: Fri Apr 13 17:42:20 2018 Fix the set of sandbox tokens recognized by iframe.sandbox.supports() Two tokens were missing from the list: allow-orientation-lock and allow-presentation. In addition, allow-downloads was reported as being supported, when it actually depends on a runtime flag which is off by default. Bug: 739787 Change-Id: Iadea9ebf45c7c0b63e8775f5c10aaa0c764a6807 Reviewed-on: https://chromium-review.googlesource.com/1005414 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#550673} [modify] https://crrev.com/763d8cc7561615b7c3f7bdea8de2d4521c104781/third_party/WebKit/LayoutTests/fast/dom/HTMLIFrameElement/sandbox-feature-detection.html [modify] https://crrev.com/763d8cc7561615b7c3f7bdea8de2d4521c104781/third_party/blink/renderer/core/html/html_iframe_element_sandbox.cc
,
Apr 13 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/763d8cc7561615b7c3f7bdea8de2d4521c104781 commit 763d8cc7561615b7c3f7bdea8de2d4521c104781 Author: Ian Clelland <iclelland@chromium.org> Date: Fri Apr 13 17:42:20 2018 Fix the set of sandbox tokens recognized by iframe.sandbox.supports() Two tokens were missing from the list: allow-orientation-lock and allow-presentation. In addition, allow-downloads was reported as being supported, when it actually depends on a runtime flag which is off by default. Bug: 739787 Change-Id: Iadea9ebf45c7c0b63e8775f5c10aaa0c764a6807 Reviewed-on: https://chromium-review.googlesource.com/1005414 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#550673} [modify] https://crrev.com/763d8cc7561615b7c3f7bdea8de2d4521c104781/third_party/WebKit/LayoutTests/fast/dom/HTMLIFrameElement/sandbox-feature-detection.html [modify] https://crrev.com/763d8cc7561615b7c3f7bdea8de2d4521c104781/third_party/blink/renderer/core/html/html_iframe_element_sandbox.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by iclell...@chromium.org
, Jul 9 2017