New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739779 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

SpareChildConnection.isEmpty() can return false incorrectly

Project Member Reported by jcivelli@chromium.org, Jul 6 2017 
org.chromium.content.browser.SpareChildConnection.isEmpty() should return false if no connection is available, meaning the next call to getConnection will return a non null connection.
However a call to isEmpty can return false even if no connection is available: after a call to getConnection where a connection was returned but that connection was not ready yet.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61a18de7e11675622a5e6fb7834057973ad37790

commit 61a18de7e11675622a5e6fb7834057973ad37790
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Jul 06 19:08:43 2017

Fix for SpareChildConnection.isEmpty() returning false incorrectly.

SpareChildConnection.isEmpty() would return false incorrectly if a
connection was previously retrieved but that connection was then not
ready.

Bug:  739779 
Change-Id: If610dfbacea975819342e7f914ca7b032d4a0cb3
Reviewed-on: https://chromium-review.googlesource.com/561941
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484699}
[modify] https://crrev.com/61a18de7e11675622a5e6fb7834057973ad37790/content/public/android/java/src/org/chromium/content/browser/SpareChildConnection.java
[modify] https://crrev.com/61a18de7e11675622a5e6fb7834057973ad37790/content/public/android/junit/src/org/chromium/content/browser/SpareChildConnectionTest.java

Comment 2 by jcivelli@chromium.org, Jul 6 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment