New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739776 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

clang-format quality problem

Project Member Reported by jdoerrie@chromium.org, Jul 6 2017

Issue description

clang-format produced code that (choose all that apply): 
- Riles my finely honed stylistic dander

Here's the code before formatting:
  Column column = {name, type, false, sealed_version_ + 1, kInvalidVersion, false, false};

Here's the code after formatting (note the double space after name):
  Column column = {name,  type, false, sealed_version_ + 1, kInvalidVersion,
                   false, false};

Here's how it ought to look:
  Column column = {name, type, false, sealed_version_ + 1, kInvalidVersion,
                   false, false};

Code review link for full files/context:
https://chromium-review.googlesource.com/c/556034/1/components%252Fpassword_manager%252Fcore%252Fbrowser%252Fsql_table_builder.cc#79
 

Comment 1 by vabr@chromium.org, Jul 7 2017

Now that I see this isolated, I can see that clang-format is trying to organise the values into columns, that's why |type| is aligned with |false|.

If we still consider this bug, and unless this is something specific to Chromium's clang-format config, an internal bug filed through the button at go/clang-format might help clarify this.

Comment 2 by thakis@chromium.org, Jul 11 2017

Status: WontFix (was: Untriaged)
IIRC this is intentional, as comment 1 says.
Cc: -vabr@chromium.org

Sign in to add a comment