New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739751 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Catapult / Devil: adb_wrapper.py edge cases and Windows line-endings.

Project Member Reported by kraynov@chromium.org, Jul 6 2017

Issue description

In catapult repo at
//devil/devil/android/sdk/adb_wrapper.py
there are following issues:

1. PersistentShell::RunCommand::run_cmd receives \r\r\n as a new-line separator on Windows. It leads to empty string at the end of list produced by splitlines(). [kraynov@ gonna fix it]

2. If run_cmd runs a command not ending with a new-line it leads to get exit code concatenated with the last line.

3. Long commands passed to run_cmd lead in getting command echo-ed back by interactive shell which implements interactive scrolling. It pollutes the output.

... and, for sure, some other bugs we're not aware of yet

It worked fine because PersistentShell::RunCommand used only once in catapult codebase (in //systrace/systrace/tracing_agents/atrace_agent.py) and it doesn't seems to be tested on Windows.

So basically I'd expect:
1. Fixing these issues
2. Tests

I gonna land a CL quick-fixing systrace on Windows, but not going to fix other problems. Anyone willing to fix it is really welcome to take this bug ;) Thanks!
 
Cc: jbudorick@chromium.org
Thanks for looking into these. Do add me as reviewer on any changes/fixes.

+jbudorick FYI
This CL is link to this issue (not propogated automatically)
https://crrev.com/2974463002
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ddb024b125ccc37cda944c999cb5503efde26eb

commit 8ddb024b125ccc37cda944c999cb5503efde26eb
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Jul 06 19:16:04 2017

Roll src/third_party/catapult/ 5d065952a..6539cc70d (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5d065952a0d8..6539cc70d9e1

$ git log 5d065952a..6539cc70d --date=short --no-merges --format='%ad %ae %s'
2017-07-06 kraynov Quick fix systrace on Windows.

Created with:
  roll-dep src/third_party/catapult
BUG= 739751 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If7474db661c5cbf4514d667a0a8f4a33dcb5ae78
Reviewed-on: https://chromium-review.googlesource.com/561978
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484703}
[modify] https://crrev.com/8ddb024b125ccc37cda944c999cb5503efde26eb/DEPS

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment