Android lint unable to lint certain java files due to API level |
||||||
Issue descriptionUnexpected failure during lint analysis of GeolocationHeader.java (this is a bug in lint or one of the libraries it depends on) AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of LocationBarLayout.java (this is a bug in lint or one of the libraries it depends on) AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of ContextualSearchPolicy.java (this is a bug in lint or one of the libraries it depends on) AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of ChromeContextMenuPopulator.java (this is a bug in lint or one of the libraries it depends on) AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of UrlUtilities.java (this is a bug in lint or one of the libraries it depends on) AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of CreateRouteRequest.java (this is a bug in lint or one of the libraries it depends on) AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of CastSessionImpl.java (this is a bug in lint or one of the libraries it depends on) AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
,
Jul 6 2017
,
Jul 6 2017
Current platform-tools version is 25.0.3. @John - I presume we are planning to roll to 26.0.0 soonish? :)
,
Jul 6 2017
Yeah, I wanted to handle platform-tools separately because it (specifically adb) has been a problem historically. I intend to upgrade within the next couple of weeks.
,
Jul 12 2017
Sounds great, thanks John! I'll wait for platform-tools to be updated before turning on lint for unused resources again. Any bug I can star for the roll?
,
Jul 12 2017
,
Jul 19 2017
I'll add a suppression for the NewApi warnings from mismatching lint/platform-tools versions. We need lint working again as I'm seeing code go in that violate basic lint errors. (e.g. issue 746409 )
,
Jul 19 2017
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a207e0dd9000045034b473c5ccf2b8cbf4722205 commit a207e0dd9000045034b473c5ccf2b8cbf4722205 Author: Peter Wen <wnwen@chromium.org> Date: Wed Jul 19 18:14:31 2017 Android: Re-enable lint Android lint has been failing due to API level mismatch between lint and platform-tools (26 vs 25). This is causing new lint errors to be introduced. Ignore the API mismatch for now and re-enable lint so it at least catches all other issues. API warning will be re-enabled after platform-tools is rolled. Bug: 739746 , 746409 Change-Id: I339560498544462732300c5030381a0c67f25f1b Reviewed-on: https://chromium-review.googlesource.com/577593 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487918} [modify] https://crrev.com/a207e0dd9000045034b473c5ccf2b8cbf4722205/build/android/lint/suppressions.xml [modify] https://crrev.com/a207e0dd9000045034b473c5ccf2b8cbf4722205/build/config/android/config.gni [modify] https://crrev.com/a207e0dd9000045034b473c5ccf2b8cbf4722205/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75542186279074de8d13aa11d7e9b0c658624835 commit 75542186279074de8d13aa11d7e9b0c658624835 Author: Tien-Ren Chen <trchen@chromium.org> Date: Wed Jul 19 21:13:29 2017 Revert "Android: Re-enable lint" This reverts commit a207e0dd9000045034b473c5ccf2b8cbf4722205. Reason for revert: Lint error in downstream code. Original change's description: > Android: Re-enable lint > > Android lint has been failing due to API level mismatch between lint and > platform-tools (26 vs 25). This is causing new lint errors to be > introduced. Ignore the API mismatch for now and re-enable lint so it at > least catches all other issues. > > API warning will be re-enabled after platform-tools is rolled. > > Bug: 739746 , 746409 > Change-Id: I339560498544462732300c5030381a0c67f25f1b > Reviewed-on: https://chromium-review.googlesource.com/577593 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487918} TBR=mthiesse@chromium.org,wnwen@chromium.org,agrieve@chromium.org Change-Id: I4857cf1ba5f10b009155693a803df922036f1878 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 739746 , 746409 Reviewed-on: https://chromium-review.googlesource.com/578059 Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487983} [modify] https://crrev.com/75542186279074de8d13aa11d7e9b0c658624835/build/android/lint/suppressions.xml [modify] https://crrev.com/75542186279074de8d13aa11d7e9b0c658624835/build/config/android/config.gni [modify] https://crrev.com/75542186279074de8d13aa11d7e9b0c658624835/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jul 19 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/bcf96c82822f785b35b935d25eb5281555bc93d1 commit bcf96c82822f785b35b935d25eb5281555bc93d1 Author: Peter Wen <wnwen@google.com> Date: Wed Jul 19 23:01:29 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99ff879f6fc416a1181e9a8a68c1686281b8c7e2 commit 99ff879f6fc416a1181e9a8a68c1686281b8c7e2 Author: Peter Wen <wnwen@chromium.org> Date: Thu Jul 20 13:06:33 2017 Reland "Android: Re-enable lint" Original CL: http://crrev.com/c/577593 Fixes: Suppress lint errors for downstream targets. TBR=mthiesse@chromium.org,agrieve@chromium.org Bug: 739746 , 746409 Change-Id: Ib069fed8e77d1a55d75ae71592cea6096c46ff47 Reviewed-on: https://chromium-review.googlesource.com/577966 Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488220} [modify] https://crrev.com/99ff879f6fc416a1181e9a8a68c1686281b8c7e2/build/android/lint/suppressions.xml [modify] https://crrev.com/99ff879f6fc416a1181e9a8a68c1686281b8c7e2/build/config/android/config.gni [modify] https://crrev.com/99ff879f6fc416a1181e9a8a68c1686281b8c7e2/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Aug 15 2017
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e39219b5dd904f4ab75192ba97f0ce720cd7b58e commit e39219b5dd904f4ab75192ba97f0ce720cd7b58e Author: Peter Wen <wnwen@chromium.org> Date: Wed Sep 06 15:47:34 2017 Android: Roll src/third_party/android_tools Picking up platform-tools version 26 for lint. Will update lint suppression in a follow-up CL. https://chromium.googlesource.com/android_tools.git/+/aadb2fed04af8606545b0afe4e3060bc1a15fad7 BUG= 739746 , 735481 Change-Id: I2c2fb0e489d6007b8b71fd1e84b50ad815cc7f42 Reviewed-on: https://chromium-review.googlesource.com/652767 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#499973} [modify] https://crrev.com/e39219b5dd904f4ab75192ba97f0ce720cd7b58e/DEPS
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41228577f586871e139fe554d532e4938cca9d6e commit 41228577f586871e139fe554d532e4938cca9d6e Author: Peter Wen <wnwen@chromium.org> Date: Mon Sep 11 14:57:49 2017 Android: Re-enable lint NewApi check Now that platform-tools is rolled to version 26, we no longer need to ignore lint failures due to platform differences. Prevents hard to debug failures down the line due to API level mismatch. Added suppressions and filed bugs for errors that crept in during the time this was disabled. Effort should be put in next upgrade to not allow this time to elapse. BUG= 739746 , 762551 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I28b1fa0e17a361bef8bfb522fb3ed59147b05d32 Reviewed-on: https://chromium-review.googlesource.com/652964 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#500917} [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/android_webview/java/src/org/chromium/android_webview/AwAutofillManager.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/android_webview/java/src/org/chromium/android_webview/variations/AwVariationsConfigurationService.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/build/android/lint/suppressions.xml [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/res/drawable/ic_photo_camera_grey.xml [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/res/drawable/new_tab_icon.xml [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/DeviceConditions.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PictureInPictureControllerTest.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializerTest.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdaterTest.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/SiteChannelsManagerTest.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActionsNotificationTest.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/content/public/android/java/res/menu/select_action_menu.xml [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/content/public/android/java/src/org/chromium/content/browser/SmartSelectionProvider.java [modify] https://crrev.com/41228577f586871e139fe554d532e4938cca9d6e/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java
,
Sep 11 2017
Should be fixed now. :) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wnwen@chromium.org
, Jul 6 2017