New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739719 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Improve Render Test usability

Project Member Reported by peconn@chromium.org, Jul 6 2017

Issue description

This is an overarching bug for all the small feature requests to make Render Tests useful.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d08610f384082a7a38319d714486a00ffbec60c

commit 0d08610f384082a7a38319d714486a00ffbec60c
Author: Peter E Conn <peconn@chromium.org>
Date: Thu Jul 06 15:57:05 2017

📷 Link to golden file in repo on Render Test results page.

Adds a link to a chromium code search for the golden for a Render Test
render.

Bug: 739719
Change-Id: I268bdd664526aa6069d0ed1bc96e8a441f563e14
Reviewed-on: https://chromium-review.googlesource.com/561716
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484612}
[modify] https://crrev.com/0d08610f384082a7a38319d714486a00ffbec60c/build/android/pylib/instrumentation/render_test.html.jinja

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66dd294dc661ed945009139a2979c2cf51d8969d

commit 66dd294dc661ed945009139a2979c2cf51d8969d
Author: Mike Case <mikecase@google.com>
Date: Thu Jul 06 19:35:21 2017

Sort links in results details logs column.

Sorting the links in the logs column alphabetically.

Bug: 739719
Change-Id: If6500ef080b16858a7faa1a436f38540ce7121be
Reviewed-on: https://chromium-review.googlesource.com/562016
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Michael Case <mikecase@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484712}
[modify] https://crrev.com/66dd294dc661ed945009139a2979c2cf51d8969d/build/android/pylib/results/presentation/test_results_presentation.py

Cc: bauerb@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ac98faa7ca7d9c426d4491324f3485e3d0ea677

commit 8ac98faa7ca7d9c426d4491324f3485e3d0ea677
Author: Peter E Conn <peconn@chromium.org>
Date: Fri Jul 21 13:48:02 2017

📷 Display No Golden when golden is missing on Render Tests.

Bug: 739719
Change-Id: I24f44759324ae715a9d8abbd71753f0d3e85ab5b
Reviewed-on: https://chromium-review.googlesource.com/581189
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488646}
[modify] https://crrev.com/8ac98faa7ca7d9c426d4491324f3485e3d0ea677/build/android/pylib/instrumentation/render_test.html.jinja

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e4413eadc4492fa3e6cbff7dee859efcdee1531

commit 5e4413eadc4492fa3e6cbff7dee859efcdee1531
Author: Peter E Conn <peconn@chromium.org>
Date: Tue Aug 08 10:46:34 2017

📷 Fix Render Tests output directory logic.

Bug: 739719
Change-Id: I6b41c7894dd8111ff6a51ccec43642928de3757f
Reviewed-on: https://chromium-review.googlesource.com/594409
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492589}
[modify] https://crrev.com/5e4413eadc4492fa3e6cbff7dee859efcdee1531/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderTestRule.java

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49677dd52cc6ddbe4d72d2a0c62edf8b02aa5272

commit 49677dd52cc6ddbe4d72d2a0c62edf8b02aa5272
Author: Peter E Conn <peconn@chromium.org>
Date: Tue Aug 08 13:14:18 2017

📷 Update RenderTestRule documentation.

Made it explicit that the RenderTest feature is required for the bots to do their magic.

Bug: 739719
Change-Id: Ie1cb4f2495cd153fddb7745a732bb6f30da82849
Reviewed-on: https://chromium-review.googlesource.com/594768
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492607}
[add] https://crrev.com/49677dd52cc6ddbe4d72d2a0c62edf8b02aa5272/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OWNERS
[modify] https://crrev.com/49677dd52cc6ddbe4d72d2a0c62edf8b02aa5272/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderTestRule.java

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/923ca0b3a172608408687e5099f49e8e0c70d91a

commit 923ca0b3a172608408687e5099f49e8e0c70d91a
Author: Peter E Conn <peconn@chromium.org>
Date: Wed Oct 18 16:26:39 2017

📷 Add save failure link to Render Test result page.

The link will allow you to download the failed render image with the
correct name.

Bug: 739719
Change-Id: Id7415d426dd128f4e1ca93960c805f45027ac5ca
Reviewed-on: https://chromium-review.googlesource.com/725344
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509786}
[modify] https://crrev.com/923ca0b3a172608408687e5099f49e8e0c70d91a/build/android/pylib/instrumentation/render_test.html.jinja

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a55ac0bf85cf80e0dc7c10c2474f8daed43f893

commit 0a55ac0bf85cf80e0dc7c10c2474f8daed43f893
Author: Peter E Conn <peconn@chromium.org>
Date: Fri Oct 20 13:07:04 2017

📷 Make Save failure link instructions more explicit.

Bug: 739719
Change-Id: I47a7462c071c7041955048a1e50d74a78d30b5d0
Reviewed-on: https://chromium-review.googlesource.com/730007
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510414}
[modify] https://crrev.com/0a55ac0bf85cf80e0dc7c10c2474f8daed43f893/build/android/pylib/instrumentation/render_test.html.jinja

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0342133487e16835724a0eba6b8ecb0deab8bdf

commit f0342133487e16835724a0eba6b8ecb0deab8bdf
Author: Peter E Conn <peconn@chromium.org>
Date: Fri Nov 10 13:09:04 2017

📷 Add Render Tests documentation.

Add a markdown file giving some basic documentation for render tests.
This should hopefully be the first port of call when someone see a
render test failure.

Bug: 739719
Change-Id: Id514286bcf257848cea73459b1d4fcb801c6e2f9
Reviewed-on: https://chromium-review.googlesource.com/758589
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515539}
[add] https://crrev.com/f0342133487e16835724a0eba6b8ecb0deab8bdf/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RENDER_TESTS.md
[modify] https://crrev.com/f0342133487e16835724a0eba6b8ecb0deab8bdf/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderTestRule.java

Sign in to add a comment